* [PATCH v1] CIFS: display noacl and locallease in the mount options
@ 2019-04-09 13:17 XiaoLi Feng
2019-04-09 13:59 ` Kenneth Dsouza
0 siblings, 1 reply; 3+ messages in thread
From: XiaoLi Feng @ 2019-04-09 13:17 UTC (permalink / raw)
To: linux-cifs; +Cc: fengxiaoli0714@gmai.com
From: "fengxiaoli0714@gmai.com" <fengxiaoli0714@gmail.com>
The mount option noacl and locallease aren't shown in /proc/mounts
even if they are mounted successfully. Now display them.
Signed-off-by: fengxiaoli0714@gmai.com <fengxiaoli0714@gmail.com>
---
fs/cifs/cifsfs.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index f9b71c12cc9f..44dbace210d2 100644
--- a/fs/cifs/cifsfs.c
+++ b/fs/cifs/cifsfs.c
@@ -503,6 +503,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
seq_puts(s, ",unix");
else
seq_puts(s, ",nounix");
+ if (tcon->local_lease)
+ seq_puts(s, ",locallease");
if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NO_DFS)
seq_puts(s, ",nodfs");
if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_POSIX_PATHS)
@@ -535,6 +537,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
seq_puts(s, ",dynperm");
if (root->d_sb->s_flags & SB_POSIXACL)
seq_puts(s, ",acl");
+ else
+ seq_puts(s, ",noacl");
if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MF_SYMLINKS)
seq_puts(s, ",mfsymlinks");
if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_FSCACHE)
--
2.18.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] CIFS: display noacl and locallease in the mount options
2019-04-09 13:17 [PATCH v1] CIFS: display noacl and locallease in the mount options XiaoLi Feng
@ 2019-04-09 13:59 ` Kenneth Dsouza
2019-04-10 2:35 ` Xiaoli Feng
0 siblings, 1 reply; 3+ messages in thread
From: Kenneth Dsouza @ 2019-04-09 13:59 UTC (permalink / raw)
To: XiaoLi Feng; +Cc: CIFS, fengxiaoli0714@gmai.com
We already have locallease patch in for next.
https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=1d4fcc75b71f8a9f9807a000da53d9885546e2f3
Can you resend this patch only for noacl?
On Tue, Apr 9, 2019 at 6:47 PM XiaoLi Feng <xifeng@redhat.com> wrote:
>
> From: "fengxiaoli0714@gmai.com" <fengxiaoli0714@gmail.com>
>
> The mount option noacl and locallease aren't shown in /proc/mounts
> even if they are mounted successfully. Now display them.
>
> Signed-off-by: fengxiaoli0714@gmai.com <fengxiaoli0714@gmail.com>
> ---
> fs/cifs/cifsfs.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
> index f9b71c12cc9f..44dbace210d2 100644
> --- a/fs/cifs/cifsfs.c
> +++ b/fs/cifs/cifsfs.c
> @@ -503,6 +503,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
> seq_puts(s, ",unix");
> else
> seq_puts(s, ",nounix");
> + if (tcon->local_lease)
> + seq_puts(s, ",locallease");
> if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NO_DFS)
> seq_puts(s, ",nodfs");
> if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_POSIX_PATHS)
> @@ -535,6 +537,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
> seq_puts(s, ",dynperm");
> if (root->d_sb->s_flags & SB_POSIXACL)
> seq_puts(s, ",acl");
> + else
> + seq_puts(s, ",noacl");
> if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MF_SYMLINKS)
> seq_puts(s, ",mfsymlinks");
> if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_FSCACHE)
> --
> 2.18.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] CIFS: display noacl and locallease in the mount options
2019-04-09 13:59 ` Kenneth Dsouza
@ 2019-04-10 2:35 ` Xiaoli Feng
0 siblings, 0 replies; 3+ messages in thread
From: Xiaoli Feng @ 2019-04-10 2:35 UTC (permalink / raw)
To: Kenneth Dsouza; +Cc: CIFS, fengxiaoli0714@gmai.com
Hi Kenneth,
Now re-sended it. By the way, suddenly I have an idea. Such as for your this
patch, I suppose you see the bug
https://bugzilla.redhat.com/show_bug.cgi?id=1662406
Bug 1662406 - [RHEL8 cifs]: the option locallease isn't shown in /proc/mounts
and then send this patch. I think it's better that add the bugzilla info in the
commit log. Just my opinion. But if you didn't see this bugzilla, ignore what
I said.
Thanks.
----- Original Message -----
> From: "Kenneth Dsouza" <kdsouza@redhat.com>
> To: "XiaoLi Feng" <xifeng@redhat.com>
> Cc: "CIFS" <linux-cifs@vger.kernel.org>, "fengxiaoli0714@gmai.com" <fengxiaoli0714@gmail.com>
> Sent: Tuesday, April 9, 2019 9:59:39 PM
> Subject: Re: [PATCH v1] CIFS: display noacl and locallease in the mount options
>
> We already have locallease patch in for next.
> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=1d4fcc75b71f8a9f9807a000da53d9885546e2f3
> Can you resend this patch only for noacl?
>
> On Tue, Apr 9, 2019 at 6:47 PM XiaoLi Feng <xifeng@redhat.com> wrote:
> >
> > From: "fengxiaoli0714@gmai.com" <fengxiaoli0714@gmail.com>
> >
> > The mount option noacl and locallease aren't shown in /proc/mounts
> > even if they are mounted successfully. Now display them.
> >
> > Signed-off-by: fengxiaoli0714@gmai.com <fengxiaoli0714@gmail.com>
> > ---
> > fs/cifs/cifsfs.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
> > index f9b71c12cc9f..44dbace210d2 100644
> > --- a/fs/cifs/cifsfs.c
> > +++ b/fs/cifs/cifsfs.c
> > @@ -503,6 +503,8 @@ cifs_show_options(struct seq_file *s, struct dentry
> > *root)
> > seq_puts(s, ",unix");
> > else
> > seq_puts(s, ",nounix");
> > + if (tcon->local_lease)
> > + seq_puts(s, ",locallease");
> > if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NO_DFS)
> > seq_puts(s, ",nodfs");
> > if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_POSIX_PATHS)
> > @@ -535,6 +537,8 @@ cifs_show_options(struct seq_file *s, struct dentry
> > *root)
> > seq_puts(s, ",dynperm");
> > if (root->d_sb->s_flags & SB_POSIXACL)
> > seq_puts(s, ",acl");
> > + else
> > + seq_puts(s, ",noacl");
> > if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MF_SYMLINKS)
> > seq_puts(s, ",mfsymlinks");
> > if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_FSCACHE)
> > --
> > 2.18.1
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-10 2:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09 13:17 [PATCH v1] CIFS: display noacl and locallease in the mount options XiaoLi Feng
2019-04-09 13:59 ` Kenneth Dsouza
2019-04-10 2:35 ` Xiaoli Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).