* [PATCH] [-next] cifsd: remove duplicated argument
@ 2021-06-07 4:54 ` Wan Jiabing
2021-06-07 5:43 ` Namjae Jeon
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-06-07 4:54 UTC (permalink / raw)
To: Namjae Jeon, Sergey Senozhatsky, Steve French, Hyunchul Lee,
linux-cifs, linux-cifsd-devel, linux-kernel
Cc: Wan Jiabing
Fix the following coccicheck warning:
./fs/cifsd/smb2pdu.c:1713:27-41: duplicated argument to & or |
FILE_DELETE_LE is duplicated. Remove one and reorder argument to
make coding style reasonable.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
fs/cifsd/smb2pdu.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/cifsd/smb2pdu.c b/fs/cifsd/smb2pdu.c
index 3e112fbdc2d9..9a46897d39c9 100644
--- a/fs/cifsd/smb2pdu.c
+++ b/fs/cifsd/smb2pdu.c
@@ -1710,10 +1710,10 @@ int smb2_tree_connect(struct ksmbd_work *work)
KSMBD_TREE_CONN_FLAG_WRITABLE)) {
rsp->MaximalAccess |= FILE_WRITE_DATA_LE |
FILE_APPEND_DATA_LE | FILE_WRITE_EA_LE |
- FILE_DELETE_CHILD_LE | FILE_DELETE_LE |
- FILE_WRITE_ATTRIBUTES_LE | FILE_DELETE_LE |
- FILE_READ_CONTROL_LE | FILE_WRITE_DAC_LE |
- FILE_WRITE_OWNER_LE | FILE_SYNCHRONIZE_LE;
+ FILE_DELETE_LE | FILE_WRITE_ATTRIBUTES_LE |
+ FILE_DELETE_CHILD_LE | FILE_READ_CONTROL_LE |
+ FILE_WRITE_DAC_LE | FILE_WRITE_OWNER_LE |
+ FILE_SYNCHRONIZE_LE;
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] [-next] cifsd: remove duplicated argument
2021-06-07 4:54 ` [PATCH] [-next] cifsd: remove duplicated argument Wan Jiabing
@ 2021-06-07 5:43 ` Namjae Jeon
0 siblings, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2021-06-07 5:43 UTC (permalink / raw)
To: 'Wan Jiabing'
Cc: 'Sergey Senozhatsky', 'Steve French',
'Hyunchul Lee',
linux-cifs, linux-cifsd-devel, linux-kernel
> Fix the following coccicheck warning:
> ./fs/cifsd/smb2pdu.c:1713:27-41: duplicated argument to & or |
>
> FILE_DELETE_LE is duplicated. Remove one and reorder argument to make coding style reasonable.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
I will apply it, Thanks for your patch!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-07 5:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210607045501epcas1p169d50fec8f89cc86b83a4672be75098f@epcas1p1.samsung.com>
2021-06-07 4:54 ` [PATCH] [-next] cifsd: remove duplicated argument Wan Jiabing
2021-06-07 5:43 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).