From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: dhowells@redhat.com, sfrench@samba.org,
linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] cifs: Don't use iov_iter::type directly
Date: Fri, 06 Dec 2019 08:35:27 +0000 [thread overview]
Message-ID: <26836.1575621327@warthog.procyon.org.uk> (raw)
In-Reply-To: <20191121160725.GA19291@infradead.org>
Christoph Hellwig <hch@infradead.org> wrote:
> > However, all the code that is doing direct accesses using '&' has to
> > change to make that work - so I've converted it all to using accessors so
> > that I only have to change the header file, except that the patch to do
> > that crossed with a cifs patch that added more direct accesses, IIRC.
>
> But I still don't really see the point of the wrappers. Maybe they are
> ok as a migration strategy, but in that case this patch mostly makes
> sense as part of the series only.
Can we at least push this patch? All the other users have been converted to
use the wrappers upstream, just not these because the patch adding them
crossed with the wrapper patch. Then everything is consistent (unless more
unwrapped users got added in the merge window).
David
next prev parent reply other threads:[~2019-12-06 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 8:13 [PATCH] cifs: Don't use iov_iter::type directly David Howells
2019-11-21 8:19 ` Christoph Hellwig
2019-11-21 9:11 ` David Howells
2019-11-21 16:07 ` Christoph Hellwig
2019-11-22 16:26 ` Al Viro
2019-12-06 8:35 ` David Howells [this message]
2020-01-15 20:53 ` Steve French
2020-01-15 21:19 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26836.1575621327@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).