[PATCH] cifs: Invalidate fscache cookie

[PATCH] cifs: Invalidate fscache cookie

[Rohith Surabattula]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

Hi All,

Currently, FScache is getting invalidated during close of the file. It
should be invalidated only when there is change in inode attributes.

Please find the below patch which will address the fscache invalidation.

Regards,
Rohith

[-- Attachment #2: Invalidate-fscache-cookie-only-when-inode-attributes.patch --]
[-- Type: application/octet-stream, Size: 1769 bytes --]

From 9651307e90755ac82e6a1ff3e82c294cde2c7eb2 Mon Sep 17 00:00:00 2001
From: Rohith Surabattula <rohiths@microsoft.com>
Date: Tue, 1 Feb 2022 07:22:02 +0000
Subject: [PATCH] Invalidate fscache cookie only when inode attributes are
 changed.

Signed-off-by: Rohith Surabattula <rohiths@microsoft.com>
---
 fs/cifs/inode.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index 7d8b3ceb2af3..60d853c92f6a 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -83,6 +83,7 @@ static void cifs_set_ops(struct inode *inode)
 static void
 cifs_revalidate_cache(struct inode *inode, struct cifs_fattr *fattr)
 {
+	struct cifs_fscache_inode_coherency_data cd;
 	struct cifsInodeInfo *cifs_i = CIFS_I(inode);
 
 	cifs_dbg(FYI, "%s: revalidating inode %llu\n",
@@ -113,6 +114,9 @@ cifs_revalidate_cache(struct inode *inode, struct cifs_fattr *fattr)
 	cifs_dbg(FYI, "%s: invalidating inode %llu mapping\n",
 		 __func__, cifs_i->uniqueid);
 	set_bit(CIFS_INO_INVALID_MAPPING, &cifs_i->flags);
+	/* Invalidate fscache cookie */
+	cifs_fscache_fill_coherency(&cifs_i->vfs_inode, &cd);
+	fscache_invalidate(cifs_inode_cookie(inode), &cd, i_size_read(inode), 0);
 }
 
 /*
@@ -2261,8 +2265,6 @@ cifs_dentry_needs_reval(struct dentry *dentry)
 int
 cifs_invalidate_mapping(struct inode *inode)
 {
-	struct cifs_fscache_inode_coherency_data cd;
-	struct cifsInodeInfo *cifsi = CIFS_I(inode);
 	int rc = 0;
 
 	if (inode->i_mapping && inode->i_mapping->nrpages != 0) {
@@ -2272,8 +2274,6 @@ cifs_invalidate_mapping(struct inode *inode)
 				 __func__, inode);
 	}
 
-	cifs_fscache_fill_coherency(&cifsi->vfs_inode, &cd);
-	fscache_invalidate(cifs_inode_cookie(inode), &cd, i_size_read(inode), 0);
 	return rc;
 }
 
-- 
2.32.0

Re: [PATCH] cifs: Invalidate fscache cookie

[David Howells]

Rohith Surabattula <rohiths.msft@gmail.com> wrote:

> +	/* Invalidate fscache cookie */
> +	cifs_fscache_fill_coherency(&cifs_i->vfs_inode, &cd);
> +	fscache_invalidate(cifs_inode_cookie(inode), &cd, i_size_read(inode), 0);

There's a helper for that - cifs_invalidate_cache(inode, 0) - I should've made
it use it.

David