Linux-CIFS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] [CIFS] Add missing mount option 'signloosely' to what is displayed in /proc/mounts
@ 2020-02-20  6:02 Steve French
  2020-02-20 16:12 ` Aurélien Aptel
  0 siblings, 1 reply; 2+ messages in thread
From: Steve French @ 2020-02-20  6:02 UTC (permalink / raw)
  To: CIFS

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

    We were not displaying the mount option "signloosely" in /proc/mounts
    for cifs mounts which some users found confusing recently


-- 
Thanks,

Steve

[-- Attachment #2: 0001-cifs-add-missing-mount-option-to-proc-mounts.patch --]
[-- Type: text/x-patch, Size: 886 bytes --]

From 45bf68584ce937936fe07d22a72b21ba4786f174 Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Wed, 19 Feb 2020 23:59:32 -0600
Subject: [PATCH] cifs: add missing mount option to /proc/mounts

We were not displaying the mount option "signloosely" in /proc/mounts
for cifs mounts which some users found confusing recently

Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/cifsfs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index 46ebaf3f0824..fa77fe5258b0 100644
--- a/fs/cifs/cifsfs.c
+++ b/fs/cifs/cifsfs.c
@@ -530,6 +530,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
 
 	if (tcon->seal)
 		seq_puts(s, ",seal");
+	else if (tcon->ses->server->ignore_signature)
+		seq_puts(s, ",signloosely");
 	if (tcon->nocase)
 		seq_puts(s, ",nocase");
 	if (tcon->local_lease)
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [CIFS] Add missing mount option 'signloosely' to what is displayed in /proc/mounts
  2020-02-20  6:02 [PATCH] [CIFS] Add missing mount option 'signloosely' to what is displayed in /proc/mounts Steve French
@ 2020-02-20 16:12 ` Aurélien Aptel
  0 siblings, 0 replies; 2+ messages in thread
From: Aurélien Aptel @ 2020-02-20 16:12 UTC (permalink / raw)
  To: Steve French, CIFS

Reviewed-by: Aurelien Aptel <aaptel@suse.com>

-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-20  6:02 [PATCH] [CIFS] Add missing mount option 'signloosely' to what is displayed in /proc/mounts Steve French
2020-02-20 16:12 ` Aurélien Aptel

Linux-CIFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-cifs/0 linux-cifs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-cifs linux-cifs/ https://lore.kernel.org/linux-cifs \
		linux-cifs@vger.kernel.org
	public-inbox-index linux-cifs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-cifs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git