* [PATCH 0/2] fs/cifs: use true,false for bool variable
@ 2019-12-25 3:30 zhengbin
2019-12-25 3:30 ` [PATCH 1/2] fs/cifs/smb2ops.c: " zhengbin
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: zhengbin @ 2019-12-25 3:30 UTC (permalink / raw)
To: sfrench, linux-cifs, samba-technical; +Cc: zhengbin13
zhengbin (2):
fs/cifs/smb2ops.c: use true,false for bool variable
fs/cifs/cifssmb.c: use true,false for bool variable
fs/cifs/cifssmb.c | 4 ++--
fs/cifs/smb2ops.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] fs/cifs/smb2ops.c: use true,false for bool variable
2019-12-25 3:30 [PATCH 0/2] fs/cifs: use true,false for bool variable zhengbin
@ 2019-12-25 3:30 ` zhengbin
2019-12-25 3:30 ` [PATCH 2/2] fs/cifs/cifssmb.c: " zhengbin
2019-12-30 5:29 ` [PATCH 0/2] fs/cifs: " Steve French
2 siblings, 0 replies; 4+ messages in thread
From: zhengbin @ 2019-12-25 3:30 UTC (permalink / raw)
To: sfrench, linux-cifs, samba-technical; +Cc: zhengbin13
Fixes coccicheck warning:
fs/cifs/smb2ops.c:807:2-36: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
fs/cifs/smb2ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index 6250370..2c50022 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -804,7 +804,7 @@ int open_shroot(unsigned int xid, struct cifs_tcon *tcon, struct cifs_fid *pfid)
sizeof(struct smb2_file_all_info),
&rsp_iov[1], sizeof(struct smb2_file_all_info),
(char *)&tcon->crfid.file_all_info))
- tcon->crfid.file_all_info_is_valid = 1;
+ tcon->crfid.file_all_info_is_valid = true;
oshr_exit:
mutex_unlock(&tcon->crfid.fid_mutex);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] fs/cifs/cifssmb.c: use true,false for bool variable
2019-12-25 3:30 [PATCH 0/2] fs/cifs: use true,false for bool variable zhengbin
2019-12-25 3:30 ` [PATCH 1/2] fs/cifs/smb2ops.c: " zhengbin
@ 2019-12-25 3:30 ` zhengbin
2019-12-30 5:29 ` [PATCH 0/2] fs/cifs: " Steve French
2 siblings, 0 replies; 4+ messages in thread
From: zhengbin @ 2019-12-25 3:30 UTC (permalink / raw)
To: sfrench, linux-cifs, samba-technical; +Cc: zhengbin13
Fixes coccicheck warning:
fs/cifs/cifssmb.c:4622:3-22: WARNING: Assignment of 0/1 to bool variable
fs/cifs/cifssmb.c:4756:3-22: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
fs/cifs/cifssmb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
index cc86a67..a481296 100644
--- a/fs/cifs/cifssmb.c
+++ b/fs/cifs/cifssmb.c
@@ -4619,7 +4619,7 @@ CIFSFindFirst(const unsigned int xid, struct cifs_tcon *tcon,
psrch_inf->unicode = false;
psrch_inf->ntwrk_buf_start = (char *)pSMBr;
- psrch_inf->smallBuf = 0;
+ psrch_inf->smallBuf = false;
psrch_inf->srch_entries_start =
(char *) &pSMBr->hdr.Protocol +
le16_to_cpu(pSMBr->t2.DataOffset);
@@ -4753,7 +4753,7 @@ int CIFSFindNext(const unsigned int xid, struct cifs_tcon *tcon,
cifs_buf_release(psrch_inf->ntwrk_buf_start);
psrch_inf->srch_entries_start = response_data;
psrch_inf->ntwrk_buf_start = (char *)pSMB;
- psrch_inf->smallBuf = 0;
+ psrch_inf->smallBuf = false;
if (parms->EndofSearch)
psrch_inf->endOfSearch = true;
else
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] fs/cifs: use true,false for bool variable
2019-12-25 3:30 [PATCH 0/2] fs/cifs: use true,false for bool variable zhengbin
2019-12-25 3:30 ` [PATCH 1/2] fs/cifs/smb2ops.c: " zhengbin
2019-12-25 3:30 ` [PATCH 2/2] fs/cifs/cifssmb.c: " zhengbin
@ 2019-12-30 5:29 ` Steve French
2 siblings, 0 replies; 4+ messages in thread
From: Steve French @ 2019-12-30 5:29 UTC (permalink / raw)
To: zhengbin; +Cc: Steve French, CIFS, samba-technical
Merged into cifs-2.6.git for-next
On Tue, Dec 24, 2019 at 9:23 PM zhengbin <zhengbin13@huawei.com> wrote:
>
> zhengbin (2):
> fs/cifs/smb2ops.c: use true,false for bool variable
> fs/cifs/cifssmb.c: use true,false for bool variable
>
> fs/cifs/cifssmb.c | 4 ++--
> fs/cifs/smb2ops.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> --
> 2.7.4
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-30 5:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-25 3:30 [PATCH 0/2] fs/cifs: use true,false for bool variable zhengbin
2019-12-25 3:30 ` [PATCH 1/2] fs/cifs/smb2ops.c: " zhengbin
2019-12-25 3:30 ` [PATCH 2/2] fs/cifs/cifssmb.c: " zhengbin
2019-12-30 5:29 ` [PATCH 0/2] fs/cifs: " Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).