* [PATCH] cifs: fix that return -EINVAL when do dedupe operation
@ 2019-03-16 2:02 XiaoLi Feng
2019-03-16 2:14 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: XiaoLi Feng @ 2019-03-16 2:02 UTC (permalink / raw)
To: linux-cifs; +Cc: Xiaoli Feng
From: Xiaoli Feng <fengxiaoli0714@gmail.com>
dedupe_file_range operations is combiled into remap_file_range.
But it's always skipped for dedupe operations in function
cifs_remap_file_range.
Example to test:
Before this patch:
XFS_IOC_FILE_EXTENT_SAME: Invalid argument
After this patch:
XFS_IOC_FILE_EXTENT_SAME: Operation not supported
Signed-off-by: Xiaoli Feng <fengxiaoli0714@gmail.com>
---
fs/cifs/cifsfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index 217276b8b942..f9b71c12cc9f 100644
--- a/fs/cifs/cifsfs.c
+++ b/fs/cifs/cifsfs.c
@@ -1008,7 +1008,7 @@ static loff_t cifs_remap_file_range(struct file *src_file, loff_t off,
unsigned int xid;
int rc;
- if (remap_flags & ~REMAP_FILE_ADVISORY)
+ if (remap_flags & ~(REMAP_FILE_DEDUP | REMAP_FILE_ADVISORY))
return -EINVAL;
cifs_dbg(FYI, "clone range\n");
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cifs: fix that return -EINVAL when do dedupe operation
2019-03-16 2:02 [PATCH] cifs: fix that return -EINVAL when do dedupe operation XiaoLi Feng
@ 2019-03-16 2:14 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2019-03-16 2:14 UTC (permalink / raw)
To: XiaoLi Feng; +Cc: CIFS, Xiaoli Feng
Do you have a list of any xfstests that this also helps with?
On Fri, Mar 15, 2019 at 9:10 PM XiaoLi Feng <xifeng@redhat.com> wrote:
>
> From: Xiaoli Feng <fengxiaoli0714@gmail.com>
>
> dedupe_file_range operations is combiled into remap_file_range.
> But it's always skipped for dedupe operations in function
> cifs_remap_file_range.
>
> Example to test:
> Before this patch:
> XFS_IOC_FILE_EXTENT_SAME: Invalid argument
>
> After this patch:
> XFS_IOC_FILE_EXTENT_SAME: Operation not supported
>
> Signed-off-by: Xiaoli Feng <fengxiaoli0714@gmail.com>
> ---
> fs/cifs/cifsfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
> index 217276b8b942..f9b71c12cc9f 100644
> --- a/fs/cifs/cifsfs.c
> +++ b/fs/cifs/cifsfs.c
> @@ -1008,7 +1008,7 @@ static loff_t cifs_remap_file_range(struct file *src_file, loff_t off,
> unsigned int xid;
> int rc;
>
> - if (remap_flags & ~REMAP_FILE_ADVISORY)
> + if (remap_flags & ~(REMAP_FILE_DEDUP | REMAP_FILE_ADVISORY))
> return -EINVAL;
>
> cifs_dbg(FYI, "clone range\n");
> --
> 2.18.1
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-16 2:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-16 2:02 [PATCH] cifs: fix that return -EINVAL when do dedupe operation XiaoLi Feng
2019-03-16 2:14 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).