From: Steve French <smfrench@gmail.com>
To: CIFS <linux-cifs@vger.kernel.org>
Subject: setattr and writing out dirty pages
Date: Tue, 16 Jul 2019 16:16:35 -0500 [thread overview]
Message-ID: <CAH2r5msmRPK46t+U8K5c04xSeyvPsEOSGK_AGCnafUNc3mPhLg@mail.gmail.com> (raw)
We always flush data out of the local cache on any set attribute change
(see line 2434 of fs/cifs/inode.c)
rc = filemap_write_and_wait(inode->i_mapping);
which seems too aggressive since it only needs to be done on ATTR_SIZE
and ATTR_MTIME changes.
With Ronnie's recent patch we also do an smb3 flush request when last
write time changes (to work around the problem where the timestamps
(set e.g. by "cp -p") can be reset to current time on close otherwise.
--
Thanks,
Steve
reply other threads:[~2019-07-16 21:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5msmRPK46t+U8K5c04xSeyvPsEOSGK_AGCnafUNc3mPhLg@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=linux-cifs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).