From: Steve French <smfrench@gmail.com>
To: Hyunchul Lee <hyc.lee@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Namjae Jeon <namjae.jeon@samsung.com>,
Namjae Jeon <linkinjeon@kernel.org>,
CIFS <linux-cifs@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the cifs tree
Date: Tue, 8 Jun 2021 08:16:14 -0500 [thread overview]
Message-ID: <CAH2r5mstMzq78NydjbkX4goJD1j0pzsvi1fAnLfTZbuNvuFvog@mail.gmail.com> (raw)
In-Reply-To: <CANFS6baQi_PDM+4XHNn6MnFtmvbP3JUDJJgw7fvkGDYja4=ELg@mail.gmail.com>
I will back out your patch to cifs.ko
On Tue, Jun 8, 2021 at 5:53 AM Hyunchul Lee <hyc.lee@gmail.com> wrote:
>
> Hello,
>
> 2021년 6월 8일 (화) 오후 7:27, Stephen Rothwell <sfr@canb.auug.org.au>님이 작성:
> >
> > Hi all,
> >
> > After merging the cifs tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > ld: fs/cifsd/spnego_negtokeninit.asn1.o:(.rodata.spnego_negtokeninit_decoder+0x0): multiple definition of `spnego_negtokeninit_decoder'; fs/cifs/spnego_negtoken
> > init.asn1.o:(.rodata.spnego_negtokeninit_decoder+0x0): first defined here
> > ld: fs/cifsd/asn1.o:(.opd+0xa8): multiple definition of `gssapi_this_mech'; fs/cifs/asn1.o:(.opd+0x18): first defined here
> > ld: fs/cifsd/asn1.o: in function `.gssapi_this_mech':
> > asn1.c:(.text.gssapi_this_mech+0x0): multiple definition of `.gssapi_this_mech'; fs/cifs/asn1.o:asn1.c:(.text.gssapi_this_mech+0x0): first defined here
> > ld: fs/cifsd/asn1.o:(.opd+0xc0): multiple definition of `neg_token_init_mech_type'; fs/cifs/asn1.o:(.opd+0x30): first defined here
> > ld: fs/cifsd/asn1.o: in function `.neg_token_init_mech_type':
> > asn1.c:(.text.neg_token_init_mech_type+0x0): multiple definition of `.neg_token_init_mech_type'; fs/cifs/asn1.o:asn1.c:(.text.neg_token_init_mech_type+0x0): first defined here
> >
> > Caused by commit
> >
> > 4a957ba6daf6 ("cifs: decoding negTokenInit with generic ASN1 decoder")
>
> I missed functions and structures generated from the ASN1 compiler
> aren't static.
>
> Steve, and Namjae,
> We need to rename *.asn1 files and decoder's callback functions. Is it better
> to change cifs's code?
>
> Thanks,
> Hyunchul
>
> >
> > interacting with commit
> >
> > fad4161b5cd0 ("cifsd: decoding gss token using lib/asn1_decoder.c")
> >
> > from the cifsd tree.
> >
> > I have reverted that cifs tree commit for today.
> >
> > --
> > Cheers,
> > Stephen Rothwell
--
Thanks,
Steve
next prev parent reply other threads:[~2021-06-08 13:16 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 10:27 linux-next: build failure after merge of the cifs tree Stephen Rothwell
2021-06-08 10:53 ` Hyunchul Lee
2021-06-08 13:16 ` Steve French [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-03-19 22:59 Stephen Rothwell
2024-03-19 23:37 ` Steve French
2023-07-20 0:35 Stephen Rothwell
2023-07-20 0:47 ` Steve French
2023-07-20 1:00 ` Stephen Rothwell
2023-07-20 1:33 ` Winston Wen
2021-11-15 22:17 Stephen Rothwell
2021-11-15 22:35 ` Steve French
2021-11-10 21:57 Stephen Rothwell
2021-11-10 22:32 ` Steve French
2020-04-23 0:31 Stephen Rothwell
2020-04-23 1:31 ` Steve French
2018-06-24 23:15 Stephen Rothwell
2018-06-25 0:52 ` Steve French
2018-06-01 0:09 Stephen Rothwell
2018-06-01 0:19 ` Steve French
2017-09-26 0:51 Stephen Rothwell
2017-09-26 1:20 ` Steve French
2016-11-29 22:27 Stephen Rothwell
[not found] ` <20161130092742.0f1cc03b-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2016-12-01 6:27 ` Steve French
2012-08-06 0:48 Stephen Rothwell
[not found] ` <20120806104841.07ed3708b600529ff7eb6fa6-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2012-08-06 1:57 ` Steve French
2012-01-19 0:01 Stephen Rothwell
[not found] ` <20120119110153.7ffa3312b2943386750ac7ed-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2012-01-19 0:31 ` Steve French
2011-10-25 13:59 Stephen Rothwell
[not found] ` <20111026005939.ad20ab7a2dacce216c69e821-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2011-10-25 14:51 ` Steve French
2011-10-25 15:05 ` Steve French
2011-10-25 15:58 ` Jeff Layton
2011-10-25 15:55 ` Jeff Layton
2011-03-10 0:43 Stephen Rothwell
[not found] ` <20110310114315.eb9aec89.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2011-03-10 1:03 ` Steve French
2010-09-23 1:20 Stephen Rothwell
2010-09-23 1:32 ` Steve French
[not found] ` <AANLkTimXtigjQwpL6i46JTiuREdLnr7Yh+2ZCuPfy06G-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-23 1:47 ` Steve French
2010-08-12 3:17 Stephen Rothwell
[not found] ` <20100812131741.f3a800d7.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-08-12 4:04 ` Steve French
2010-08-12 7:46 ` Stephen Rothwell
[not found] ` <20100812174621.b1dbc20f.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-08-12 15:18 ` Bryan Schumaker
2010-08-12 18:21 ` Steve French
[not found] ` <AANLkTi=iHi=kpk+nsB396B9GWdefj=WJywA2K1PawHxi-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-12 15:24 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5mstMzq78NydjbkX4goJD1j0pzsvi1fAnLfTZbuNvuFvog@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=hyc.lee@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).