From: Steve French <smfrench@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: CIFS <linux-cifs@vger.kernel.org>,
Winston Wen <wentao@uniontech.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
linux-modules@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the cifs tree
Date: Wed, 19 Jul 2023 19:47:42 -0500 [thread overview]
Message-ID: <CAH2r5mugNKYBNXm7AuPFL=V=77Qkm3q6TtXCj-B0kugmpL0aYQ@mail.gmail.com> (raw)
In-Reply-To: <20230720103540.0436273d@canb.auug.org.au>
Winston had an updated version of the patch - just replaced it with
his updated one which does a cast to (char *)
ses->local_nls = load_nls((char *)ctx->local_nls->charset);
But as he noted in an earlier email thread:
> Perhaps I should make a change to load_nls() to take a const char *
> instead of char *? If this make sense, I'll do it soon.
which is probably cleaner
On Wed, Jul 19, 2023 at 7:35 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> fs/smb/client/connect.c: In function 'cifs_get_smb_ses':
> fs/smb/client/connect.c:2293:49: error: passing argument 1 of 'load_nls' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
> 2293 | ses->local_nls = load_nls(ctx->local_nls->charset);
> | ~~~~~~~~~~~~~~^~~~~~~~~
> In file included from fs/smb/client/cifsproto.h:10,
> from fs/smb/client/connect.c:37:
> include/linux/nls.h:50:35: note: expected 'char *' but argument is of type 'const char *'
> 50 | extern struct nls_table *load_nls(char *);
> | ^~~~~~
>
> Caused by commit
>
> 46055407cd4a ("cifs: fix charset issue in reconnection")
>
> I have used the cifs tree from next-20230719 for today.
>
> It looks as though the parameter to load_nls could be made const safely
> as it is just passed to try_then_request_module() passes it to
> __request_module() which just passes it to vsnprintf() to construct the
> module name. There does not appear to be any maintainer for fs/nls ...
> --
> Cheers,
> Stephen Rothwell
--
Thanks,
Steve
next prev parent reply other threads:[~2023-07-20 0:47 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 0:35 linux-next: build failure after merge of the cifs tree Stephen Rothwell
2023-07-20 0:47 ` Steve French [this message]
2023-07-20 1:00 ` Stephen Rothwell
2023-07-20 1:33 ` Winston Wen
-- strict thread matches above, loose matches on Subject: below --
2024-03-19 22:59 Stephen Rothwell
2024-03-19 23:37 ` Steve French
2021-11-15 22:17 Stephen Rothwell
2021-11-15 22:35 ` Steve French
2021-11-10 21:57 Stephen Rothwell
2021-11-10 22:32 ` Steve French
2021-06-08 10:27 Stephen Rothwell
2021-06-08 10:53 ` Hyunchul Lee
2021-06-08 13:16 ` Steve French
2020-04-23 0:31 Stephen Rothwell
2020-04-23 1:31 ` Steve French
2018-06-24 23:15 Stephen Rothwell
2018-06-25 0:52 ` Steve French
2018-06-01 0:09 Stephen Rothwell
2018-06-01 0:19 ` Steve French
2017-09-26 0:51 Stephen Rothwell
2017-09-26 1:20 ` Steve French
2016-11-29 22:27 Stephen Rothwell
[not found] ` <20161130092742.0f1cc03b-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2016-12-01 6:27 ` Steve French
2012-08-06 0:48 Stephen Rothwell
[not found] ` <20120806104841.07ed3708b600529ff7eb6fa6-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2012-08-06 1:57 ` Steve French
2012-01-19 0:01 Stephen Rothwell
[not found] ` <20120119110153.7ffa3312b2943386750ac7ed-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2012-01-19 0:31 ` Steve French
2011-10-25 13:59 Stephen Rothwell
[not found] ` <20111026005939.ad20ab7a2dacce216c69e821-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2011-10-25 14:51 ` Steve French
2011-10-25 15:05 ` Steve French
2011-10-25 15:58 ` Jeff Layton
2011-10-25 15:55 ` Jeff Layton
2011-03-10 0:43 Stephen Rothwell
[not found] ` <20110310114315.eb9aec89.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2011-03-10 1:03 ` Steve French
2010-09-23 1:20 Stephen Rothwell
2010-09-23 1:32 ` Steve French
[not found] ` <AANLkTimXtigjQwpL6i46JTiuREdLnr7Yh+2ZCuPfy06G-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-23 1:47 ` Steve French
2010-08-12 3:17 Stephen Rothwell
[not found] ` <20100812131741.f3a800d7.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-08-12 4:04 ` Steve French
2010-08-12 7:46 ` Stephen Rothwell
[not found] ` <20100812174621.b1dbc20f.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-08-12 15:18 ` Bryan Schumaker
2010-08-12 18:21 ` Steve French
[not found] ` <AANLkTi=iHi=kpk+nsB396B9GWdefj=WJywA2K1PawHxi-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-12 15:24 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5mugNKYBNXm7AuPFL=V=77Qkm3q6TtXCj-B0kugmpL0aYQ@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=wentao@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).