Linux-CIFS Archive on lore.kernel.org
 help / color / Atom feed
* SMB3: Fix crash in SMB2_open_init due to uninitialized field in compounding path
@ 2019-12-10  4:47 Steve French
  0 siblings, 0 replies; only message in thread
From: Steve French @ 2019-12-10  4:47 UTC (permalink / raw)
  To: CIFS

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

    Ran into an intermittent crash in
            SMB2_open_init+0x2f6/0x970
    due to oparms.cifs_sb not being initialized when called from:
            smb2_compound_op+0x45d/0x1690
    Zero the whole oparms struct in the compounding path before setting up the
    oparms so we don't risk any uninitialized fields.

    Fixes: fdef665ba44a ("smb3: fix mode passed in on create for
modetosid mount option")


-- 
Thanks,

Steve

[-- Attachment #2: 0001-SMB3-Fix-crash-in-SMB2_open_init-due-to-uninitialize.patch --]
[-- Type: text/x-patch, Size: 1216 bytes --]

From d94a88c365cb53aee560c0de71948a258beefd5c Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Mon, 9 Dec 2019 22:34:10 -0600
Subject: [PATCH 2/2] SMB3: Fix crash in SMB2_open_init due to uninitialized
 field in compounding path

Ran into an intermittent crash in
	SMB2_open_init+0x2f6/0x970
due to oparms.cifs_sb not being initialized when called from:
	smb2_compound_op+0x45d/0x1690
Zero the whole oparms struct in the compounding path before setting up the
oparms so we don't risk any uninitialized fields.

Fixes: fdef665ba44a ("smb3: fix mode passed in on create for modetosid mount option")

Signed-off-by: Steve French <stfrench@microsoft.com>
Acked-by: Ronnie Sahlberg <lsahlber@redhat.com>
---
 fs/cifs/smb2inode.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/cifs/smb2inode.c b/fs/cifs/smb2inode.c
index 18c7a33adceb..5ef5e97a6d13 100644
--- a/fs/cifs/smb2inode.c
+++ b/fs/cifs/smb2inode.c
@@ -95,6 +95,7 @@ smb2_compound_op(const unsigned int xid, struct cifs_tcon *tcon,
 		goto finished;
 	}
 
+	memset(&oparms, 0, sizeof(struct cifs_open_parms));
 	oparms.tcon = tcon;
 	oparms.desired_access = desired_access;
 	oparms.disposition = create_disposition;
-- 
2.23.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-10  4:47 SMB3: Fix crash in SMB2_open_init due to uninitialized field in compounding path Steve French

Linux-CIFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-cifs/0 linux-cifs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-cifs linux-cifs/ https://lore.kernel.org/linux-cifs \
		linux-cifs@vger.kernel.org
	public-inbox-index linux-cifs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-cifs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git