* [PATCH] cifs: uninitialized variable in cifs_get_next_mid()
@ 2022-01-11 7:17 Dan Carpenter
2022-01-11 21:40 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-01-11 7:17 UTC (permalink / raw)
To: Steve French; +Cc: Shyam Prasad N, linux-cifs, samba-technical, kernel-janitors
The "reconnect" was never initialized to false.
Fixes: 220c5bc25d87 ("cifs: take cifs_tcp_ses_lock for status checks")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
fs/cifs/smb1ops.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/cifs/smb1ops.c b/fs/cifs/smb1ops.c
index 54319a789c92..6b1b048b36ae 100644
--- a/fs/cifs/smb1ops.c
+++ b/fs/cifs/smb1ops.c
@@ -163,7 +163,8 @@ cifs_get_next_mid(struct TCP_Server_Info *server)
{
__u64 mid = 0;
__u16 last_mid, cur_mid;
- bool collision, reconnect;
+ bool reconnect = false;
+ bool collision;
spin_lock(&GlobalMid_Lock);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cifs: uninitialized variable in cifs_get_next_mid()
2022-01-11 7:17 [PATCH] cifs: uninitialized variable in cifs_get_next_mid() Dan Carpenter
@ 2022-01-11 21:40 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2022-01-11 21:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Steve French, kernel-janitors, CIFS, Shyam Prasad N,
samba-technical, Enzo Matsumiya
That was fixed similarly a couple of days ago by a patch from Enzo
commit 1913e1116a3174648cf2e6faedf29204f31cc438
Author: Enzo Matsumiya <ematsumiya@suse.de>
Date: Fri Jan 7 19:51:39 2022 -0300
cifs: fix hang on cifs_get_next_mid()
Mount will hang if using SMB1 and DFS.
This is because every call to get_next_mid() will, unconditionally,
mark tcpStatus to CifsNeedReconnect before even establishing the
initial connect, because "reconnect" variable was not initialized.
On Tue, Jan 11, 2022 at 5:03 AM Dan Carpenter via samba-technical
<samba-technical@lists.samba.org> wrote:
>
> The "reconnect" was never initialized to false.
>
> Fixes: 220c5bc25d87 ("cifs: take cifs_tcp_ses_lock for status checks")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> fs/cifs/smb1ops.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb1ops.c b/fs/cifs/smb1ops.c
> index 54319a789c92..6b1b048b36ae 100644
> --- a/fs/cifs/smb1ops.c
> +++ b/fs/cifs/smb1ops.c
> @@ -163,7 +163,8 @@ cifs_get_next_mid(struct TCP_Server_Info *server)
> {
> __u64 mid = 0;
> __u16 last_mid, cur_mid;
> - bool collision, reconnect;
> + bool reconnect = false;
> + bool collision;
>
> spin_lock(&GlobalMid_Lock);
>
> --
> 2.20.1
>
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-11 21:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-11 7:17 [PATCH] cifs: uninitialized variable in cifs_get_next_mid() Dan Carpenter
2022-01-11 21:40 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).