From: Steve French <email@example.com> To: ronnie sahlberg <firstname.lastname@example.org> Cc: Ronnie Sahlberg <email@example.com>, linux-cifs <firstname.lastname@example.org> Subject: Re: [PATCH 0/3] cifs: create a common smb2pdu.h for client and server Date: Fri, 3 Sep 2021 11:53:57 -0500 [thread overview] Message-ID: <CAH2r5muE2-r0gtTWW_VzpjxiZvmRLjUoVXT3POa+qGHUycTkkQ@mail.gmail.com> (raw) In-Reply-To: <CAN05THREpo31vmCJB0y2pmDv-Cac3F3igeDxVVFktEOhYfrJkA@mail.gmail.com> should be fine in cifs_common - there is precedent in two headers already, and nfs also has an example where they do the reverse "include ../nfs/nfs4_fs.h" in nfs_ssc.c On Thu, Sep 2, 2021 at 10:01 PM ronnie sahlberg <email@example.com> wrote: > > On Fri, Sep 3, 2021 at 12:16 PM Steve French <firstname.lastname@example.org> wrote: > > > > The smbfsctl.h should also be easy to move ... but the obvious > > question is whether "common" headers belong in "fs/cifs_common" or in > > include/linux ... > > (as e.g. nfs does with common headers between server and client) > > Maybe. I think things that should never be used by any other, > non-cifs, modules might be better in cifs-common than make > them world visible in include/linux. > Especially things like pdu structures that should never be used by any > other modules. > > But I do not feel strongly about it so feel free to git mv the file over there. > > > > > > > > On Thu, Sep 2, 2021 at 6:37 PM Ronnie Sahlberg <email@example.com> wrote: > > > > > > Steve, > > > > > > Here is an initial set of patches that starts moving SMB2 PDU definitions > > > from the client/server into a shared smb2pd.h file. > > > > > > It moves the command opcode values into cifs_common, > > > it renames cifs smb2_sync_hdr to smb2_hdr to harmonize with ksmbd naming > > > and it moves the tree connect and disconnect PDU definitions to the shared > > > file. > > > > > > > > > > > > > > > -- > > Thanks, > > > > Steve -- Thanks, Steve
prev parent reply other threads:[~2021-09-03 16:54 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-02 23:37 Ronnie Sahlberg 2021-09-02 23:37 ` [PATCH 1/3] cifs: create smb2pdu.h to be shared between cifs " Ronnie Sahlberg 2021-09-02 23:37 ` [PATCH 2/3] cifs: rename smb2_sync_hdr to smb2_hdr to harmonize naming with ksmbd Ronnie Sahlberg 2021-09-02 23:37 ` [PATCH 3/3] cifs: move smb2 tree_[dis]connect definitions to the shared cifs_common Ronnie Sahlberg 2021-09-03 0:00 ` [PATCH 0/3] cifs: create a common smb2pdu.h for client and server Steve French 2021-09-03 3:01 ` ronnie sahlberg 2021-09-03 16:53 ` Steve French [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAH2r5muE2-r0gtTWW_VzpjxiZvmRLjUoVXT3POa+qGHUycTkkQ@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 0/3] cifs: create a common smb2pdu.h for client and server' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).