* [PATCH] smb3: set COMPOUND_FID to FileID field of subsequent compound request
[not found] <CGME20201203033831epcas1p4c69684156cd4e393f048472a24238e6c@epcas1p4.samsung.com>
@ 2020-12-03 3:31 ` Namjae Jeon
2020-12-03 15:50 ` Aurélien Aptel
2020-12-03 21:23 ` ronnie sahlberg
0 siblings, 2 replies; 4+ messages in thread
From: Namjae Jeon @ 2020-12-03 3:31 UTC (permalink / raw)
To: linux-cifs; +Cc: aaptel, ronniesahlberg, smfrench, Namjae Jeon
For an operation compounded with an SMB2 CREATE request, client must set
COMPOUND_FID(0xFFFFFFFFFFFFFFFF) to FileID field of smb2 ioctl.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
---
fs/cifs/smb2ops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index 504766cb6c19..3ca632bb6be9 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -3098,8 +3098,8 @@ smb2_query_reparse_tag(const unsigned int xid, struct cifs_tcon *tcon,
rqst[1].rq_nvec = SMB2_IOCTL_IOV_SIZE;
rc = SMB2_ioctl_init(tcon, server,
- &rqst[1], fid.persistent_fid,
- fid.volatile_fid, FSCTL_GET_REPARSE_POINT,
+ &rqst[1], COMPOUND_FID,
+ COMPOUND_FID, FSCTL_GET_REPARSE_POINT,
true /* is_fctl */, NULL, 0,
CIFSMaxBufSize -
MAX_SMB2_CREATE_RESPONSE_SIZE -
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] smb3: set COMPOUND_FID to FileID field of subsequent compound request
2020-12-03 3:31 ` [PATCH] smb3: set COMPOUND_FID to FileID field of subsequent compound request Namjae Jeon
@ 2020-12-03 15:50 ` Aurélien Aptel
2020-12-03 21:23 ` ronnie sahlberg
1 sibling, 0 replies; 4+ messages in thread
From: Aurélien Aptel @ 2020-12-03 15:50 UTC (permalink / raw)
To: Namjae Jeon, linux-cifs; +Cc: ronniesahlberg, smfrench, Namjae Jeon
Hi,
Namjae Jeon <namjae.jeon@samsung.com> writes:
> For an operation compounded with an SMB2 CREATE request, client must set
> COMPOUND_FID(0xFFFFFFFFFFFFFFFF) to FileID field of smb2 ioctl.
Looks good to me.
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] smb3: set COMPOUND_FID to FileID field of subsequent compound request
2020-12-03 3:31 ` [PATCH] smb3: set COMPOUND_FID to FileID field of subsequent compound request Namjae Jeon
2020-12-03 15:50 ` Aurélien Aptel
@ 2020-12-03 21:23 ` ronnie sahlberg
2020-12-03 23:05 ` Steve French
1 sibling, 1 reply; 4+ messages in thread
From: ronnie sahlberg @ 2020-12-03 21:23 UTC (permalink / raw)
To: Namjae Jeon; +Cc: linux-cifs, Aurélien Aptel, Steve French
Looks good to me,
please add "Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>"
(How could this ever have worked?)
Can you add a line :
Fixes: 2e4564b31b645 ("smb3: add support ....
On Thu, Dec 3, 2020 at 1:38 PM Namjae Jeon <namjae.jeon@samsung.com> wrote:
>
> For an operation compounded with an SMB2 CREATE request, client must set
> COMPOUND_FID(0xFFFFFFFFFFFFFFFF) to FileID field of smb2 ioctl.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> ---
> fs/cifs/smb2ops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> index 504766cb6c19..3ca632bb6be9 100644
> --- a/fs/cifs/smb2ops.c
> +++ b/fs/cifs/smb2ops.c
> @@ -3098,8 +3098,8 @@ smb2_query_reparse_tag(const unsigned int xid, struct cifs_tcon *tcon,
> rqst[1].rq_nvec = SMB2_IOCTL_IOV_SIZE;
>
> rc = SMB2_ioctl_init(tcon, server,
> - &rqst[1], fid.persistent_fid,
> - fid.volatile_fid, FSCTL_GET_REPARSE_POINT,
> + &rqst[1], COMPOUND_FID,
> + COMPOUND_FID, FSCTL_GET_REPARSE_POINT,
> true /* is_fctl */, NULL, 0,
> CIFSMaxBufSize -
> MAX_SMB2_CREATE_RESPONSE_SIZE -
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] smb3: set COMPOUND_FID to FileID field of subsequent compound request
2020-12-03 21:23 ` ronnie sahlberg
@ 2020-12-03 23:05 ` Steve French
0 siblings, 0 replies; 4+ messages in thread
From: Steve French @ 2020-12-03 23:05 UTC (permalink / raw)
To: ronnie sahlberg; +Cc: Namjae Jeon, linux-cifs, Aurélien Aptel
updated ... also just noticed that no need for cc:stable since this
was added after 5.9
On Thu, Dec 3, 2020 at 3:23 PM ronnie sahlberg <ronniesahlberg@gmail.com> wrote:
>
> Looks good to me,
> please add "Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>"
>
> (How could this ever have worked?)
>
>
> Can you add a line :
> Fixes: 2e4564b31b645 ("smb3: add support ....
>
> On Thu, Dec 3, 2020 at 1:38 PM Namjae Jeon <namjae.jeon@samsung.com> wrote:
> >
> > For an operation compounded with an SMB2 CREATE request, client must set
> > COMPOUND_FID(0xFFFFFFFFFFFFFFFF) to FileID field of smb2 ioctl.
> >
> > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > ---
> > fs/cifs/smb2ops.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> > index 504766cb6c19..3ca632bb6be9 100644
> > --- a/fs/cifs/smb2ops.c
> > +++ b/fs/cifs/smb2ops.c
> > @@ -3098,8 +3098,8 @@ smb2_query_reparse_tag(const unsigned int xid, struct cifs_tcon *tcon,
> > rqst[1].rq_nvec = SMB2_IOCTL_IOV_SIZE;
> >
> > rc = SMB2_ioctl_init(tcon, server,
> > - &rqst[1], fid.persistent_fid,
> > - fid.volatile_fid, FSCTL_GET_REPARSE_POINT,
> > + &rqst[1], COMPOUND_FID,
> > + COMPOUND_FID, FSCTL_GET_REPARSE_POINT,
> > true /* is_fctl */, NULL, 0,
> > CIFSMaxBufSize -
> > MAX_SMB2_CREATE_RESPONSE_SIZE -
> > --
> > 2.17.1
> >
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-03 23:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20201203033831epcas1p4c69684156cd4e393f048472a24238e6c@epcas1p4.samsung.com>
2020-12-03 3:31 ` [PATCH] smb3: set COMPOUND_FID to FileID field of subsequent compound request Namjae Jeon
2020-12-03 15:50 ` Aurélien Aptel
2020-12-03 21:23 ` ronnie sahlberg
2020-12-03 23:05 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).