Linux-CIFS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] fs/cifs/smb2pdu.c: Make SMB2_notify_init static
@ 2019-09-23  7:06 zhengbin
  2019-09-23  7:17 ` Steve French
  0 siblings, 1 reply; 2+ messages in thread
From: zhengbin @ 2019-09-23  7:06 UTC (permalink / raw)
  To: smfrench, linux-cifs; +Cc: yi.zhang, zhengbin13

Fix sparse warnings:

fs/cifs/smb2pdu.c:3200:1: warning: symbol 'SMB2_notify_init' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 fs/cifs/smb2pdu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index 8bcb278..5e87872 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -3200,7 +3200,7 @@ SMB2_get_srv_num(const unsigned int xid, struct cifs_tcon *tcon,
  * See MS-SMB2 2.2.35 and 2.2.36
  */

-int
+static int
 SMB2_notify_init(const unsigned int xid, struct smb_rqst *rqst,
 		struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid,
 		u32 completion_filter, bool watch_tree)
--
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fs/cifs/smb2pdu.c: Make SMB2_notify_init static
  2019-09-23  7:06 [PATCH] fs/cifs/smb2pdu.c: Make SMB2_notify_init static zhengbin
@ 2019-09-23  7:17 ` Steve French
  0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2019-09-23  7:17 UTC (permalink / raw)
  To: zhengbin; +Cc: CIFS, zhangyi (F)

merged into cifs-2.6.git for-next

On Mon, Sep 23, 2019 at 1:59 AM zhengbin <zhengbin13@huawei.com> wrote:
>
> Fix sparse warnings:
>
> fs/cifs/smb2pdu.c:3200:1: warning: symbol 'SMB2_notify_init' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
>  fs/cifs/smb2pdu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
> index 8bcb278..5e87872 100644
> --- a/fs/cifs/smb2pdu.c
> +++ b/fs/cifs/smb2pdu.c
> @@ -3200,7 +3200,7 @@ SMB2_get_srv_num(const unsigned int xid, struct cifs_tcon *tcon,
>   * See MS-SMB2 2.2.35 and 2.2.36
>   */
>
> -int
> +static int
>  SMB2_notify_init(const unsigned int xid, struct smb_rqst *rqst,
>                 struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid,
>                 u32 completion_filter, bool watch_tree)
> --
> 2.7.4
>


-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-23  7:06 [PATCH] fs/cifs/smb2pdu.c: Make SMB2_notify_init static zhengbin
2019-09-23  7:17 ` Steve French

Linux-CIFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-cifs/0 linux-cifs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-cifs linux-cifs/ https://lore.kernel.org/linux-cifs \
		linux-cifs@vger.kernel.org
	public-inbox-index linux-cifs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-cifs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git