* [PATCH linux-next] ksmbd: use sysfs_emit() to instead of scnprintf()
@ 2022-12-05 9:03 ye.xingchen
2022-12-06 13:47 ` Namjae Jeon
0 siblings, 1 reply; 2+ messages in thread
From: ye.xingchen @ 2022-12-05 9:03 UTC (permalink / raw)
To: linkinjeon; +Cc: sfrench, senozhatsky, tom, linux-cifs, linux-kernel
From: ye xingchen <ye.xingchen@zte.com.cn>
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
fs/ksmbd/server.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ksmbd/server.c b/fs/ksmbd/server.c
index a0d635304754..b0da15377709 100644
--- a/fs/ksmbd/server.c
+++ b/fs/ksmbd/server.c
@@ -433,7 +433,7 @@ static ssize_t stats_show(struct class *class, struct class_attribute *attr,
"shutdown"
};
- ssize_t sz = scnprintf(buf, PAGE_SIZE, "%d %s %d %lu\n", stats_version,
+ ssize_t sz = sysfs_emit(buf, "%d %s %d %lu\n", stats_version,
state[server_conf.state], server_conf.tcp_port,
server_conf.ipc_last_active / HZ);
return sz;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] ksmbd: use sysfs_emit() to instead of scnprintf()
2022-12-05 9:03 [PATCH linux-next] ksmbd: use sysfs_emit() to instead of scnprintf() ye.xingchen
@ 2022-12-06 13:47 ` Namjae Jeon
0 siblings, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2022-12-06 13:47 UTC (permalink / raw)
To: ye.xingchen; +Cc: sfrench, senozhatsky, tom, linux-cifs, linux-kernel
2022-12-05 18:03 GMT+09:00, ye.xingchen@zte.com.cn <ye.xingchen@zte.com.cn>:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> fs/ksmbd/server.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ksmbd/server.c b/fs/ksmbd/server.c
> index a0d635304754..b0da15377709 100644
> --- a/fs/ksmbd/server.c
> +++ b/fs/ksmbd/server.c
> @@ -433,7 +433,7 @@ static ssize_t stats_show(struct class *class, struct
> class_attribute *attr,
> "shutdown"
> };
>
> - ssize_t sz = scnprintf(buf, PAGE_SIZE, "%d %s %d %lu\n", stats_version,
> + ssize_t sz = sysfs_emit(buf, "%d %s %d %lu\n", stats_version,
> state[server_conf.state], server_conf.tcp_port,
> server_conf.ipc_last_active / HZ);
It would be great if you remove sz variable and return it directly.
Thanks.
> return sz;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-06 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-05 9:03 [PATCH linux-next] ksmbd: use sysfs_emit() to instead of scnprintf() ye.xingchen
2022-12-06 13:47 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).