linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Shilovsky <piastryyy@gmail.com>
To: Murphy Zhou <jencce.kernel@gmail.com>
Cc: Jeff Layton <jlayton@kernel.org>,
	linux-cifs <linux-cifs@vger.kernel.org>,
	Steve French <smfrench@gmail.com>
Subject: Re: [PATCH] CIFS: unlock file across process
Date: Tue, 25 Feb 2020 11:21:37 -0800	[thread overview]
Message-ID: <CAKywueRBLp84nrSVBYoLs-uk2OjJpcME-OW4q0UDSTNjQoggJw@mail.gmail.com> (raw)
In-Reply-To: <20200225051551.erpp36onb2kxmxjn@xzhoux.usersys.redhat.com>

пн, 24 февр. 2020 г. в 21:16, Murphy Zhou <jencce.kernel@gmail.com>:
>
> On Mon, Feb 24, 2020 at 11:39:27AM -0800, Pavel Shilovsky wrote:
> > вт, 18 февр. 2020 г. в 18:10, Murphy Zhou <jencce.kernel@gmail.com>:
> > >
> > > On Fri, Feb 14, 2020 at 11:03:00AM -0800, Pavel Shilovsky wrote:
> > > > Also, please make sure that resulting patch works against Windows file
> > > > share since the locking semantics may be different there.
> > >
> > > OK.
> > >
> > > >
> > > > Depending on a kind of lease we have on a file, locks may be cached or
> > > > not. We probably don't want to have different behavior for cached and
> > > > non-cached locks. Especially given the fact that a lease may be broken
> > > > in the middle of app execution and the different behavior will be
> > > > applied immediately.
> > >
> > > Testing new patch with and without cache=none option, both samba
> > > and Win2019 server.
> > >
> > > Thanks very much for reviewing!
> > >
> >
> > cache=none only affects IO and doesn't change the client behavior
> > regarding locks. "nolease" mount option can be used to turn off leases
> > and make all locks go to the server.
>
> Great to know! I can't find it in any man page. Doing more tests.
>

Good catch, it is missing in the man pages.

Now added: https://github.com/piastry/cifs-utils/commit/4b8b2e2680e7e4aa9cc8bd4278d04e5fe07d885e

Thanks!

--
Best regards,
Pavel Shilovsky

      reply	other threads:[~2020-02-25 19:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  4:35 [PATCH] CIFS: unlock file across process Murphy Zhou
2020-02-14  5:32 ` Steve French
2020-02-14 12:26 ` Jeff Layton
2020-02-14 14:28   ` Murphy Zhou
2020-02-14 19:03     ` Pavel Shilovsky
2020-02-19  2:10       ` Murphy Zhou
2020-02-24 19:39         ` Pavel Shilovsky
2020-02-25  5:15           ` Murphy Zhou
2020-02-25 19:21             ` Pavel Shilovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKywueRBLp84nrSVBYoLs-uk2OjJpcME-OW4q0UDSTNjQoggJw@mail.gmail.com \
    --to=piastryyy@gmail.com \
    --cc=jencce.kernel@gmail.com \
    --cc=jlayton@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).