From: Pavel Shilovsky <piastryyy@gmail.com>
To: Steve French <smfrench@gmail.com>
Cc: "Aurélien Aptel" <aaptel@suse.com>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH][SMB3] Query timestamps on file close
Date: Tue, 3 Dec 2019 14:16:48 -0800 [thread overview]
Message-ID: <CAKywueRgmMqMvu3+ymS_rq9Xb4qnOmP_CgAiKhZKyUFNgp0JmA@mail.gmail.com> (raw)
In-Reply-To: <CAH2r5mtmzQHMb+EgSpE+vOHr4=oPyv0mGAP4QEMjtswwoOZyLA@mail.gmail.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
--
Best regards,
Pavel Shilovsky
вт, 3 дек. 2019 г. в 13:49, Steve French <smfrench@gmail.com>:
>
> Updated patch with Pavel's recommended change included
>
> On Tue, Dec 3, 2019 at 1:19 PM Pavel Shilovsky <piastryyy@gmail.com> wrote:
> >
> > The inode locking is missed in the patch. See cifs_fattr_to_inode()
> > that takes inode->i_lock to atomically update all the attributes. The
> > similar thing is needed in +smb2_close_getattr().
> >
> > --
> > Best regards,
> > Pavel Shilovsky
> >
> > вт, 3 дек. 2019 г. в 10:05, Steve French <smfrench@gmail.com>:
> > >
> > > Fixed typo, and added the update of AllocationSize (and added reviewed
> > > by). See attached.
> > >
>
>
>
> --
> Thanks,
>
> Steve
prev parent reply other threads:[~2019-12-03 22:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 9:37 [PATCH][SMB3] Query timestamps on file close Steve French
2019-12-03 16:45 ` Aurélien Aptel
2019-12-03 18:02 ` Steve French
2019-12-03 19:18 ` Pavel Shilovsky
2019-12-03 21:49 ` Steve French
2019-12-03 22:16 ` Pavel Shilovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKywueRgmMqMvu3+ymS_rq9Xb4qnOmP_CgAiKhZKyUFNgp0JmA@mail.gmail.com \
--to=piastryyy@gmail.com \
--cc=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).