Linux-CIFS Archive on
 help / color / Atom feed
From: Pavel Shilovsky <>
To: Steve French <>
Cc: "Aurélien Aptel" <>, CIFS <>
Subject: Re: [PATCH][SMB3] Query timestamps on file close
Date: Tue, 3 Dec 2019 11:18:54 -0800
Message-ID: <> (raw)
In-Reply-To: <>

The inode locking is missed in the patch. See cifs_fattr_to_inode()
that takes inode->i_lock to atomically update all the attributes. The
similar thing is needed in +smb2_close_getattr().

Best regards,
Pavel Shilovsky

вт, 3 дек. 2019 г. в 10:05, Steve French <>:
> Fixed typo, and added the update of AllocationSize (and added reviewed
> by). See attached.

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03  9:37 Steve French
2019-12-03 16:45 ` Aurélien Aptel
2019-12-03 18:02   ` Steve French
2019-12-03 19:18     ` Pavel Shilovsky [this message]
2019-12-03 21:49       ` Steve French
2019-12-03 22:16         ` Pavel Shilovsky

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-CIFS Archive on

Archives are clonable:
	git clone --mirror linux-cifs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-cifs linux-cifs/ \
	public-inbox-index linux-cifs

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone