* [PATCH] [CIFS] Remove unneeded statements pointed out by Coverity
@ 2019-03-13 21:53 Steve French
2019-03-13 22:14 ` ronnie sahlberg
0 siblings, 1 reply; 2+ messages in thread
From: Steve French @ 2019-03-13 21:53 UTC (permalink / raw)
To: CIFS, LKML
cifs: remove unused value pointed out by Coverity
Detected by CoverityScan CID#1438719 ("Unused Value")
buf is reset again before being used so these two lines of code
are useless.
Signed-off-by: Steve French <stfrench@microsoft.com>
---
fs/cifs/connect.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index b95db2b593cb..a8e9738db691 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1191,10 +1191,6 @@ cifs_demultiplex_thread(void *p)
continue;
}
- if (server->large_buf)
- buf = server->bigbuf;
-
-
server->lstrp = jiffies;
for (i = 0; i < num_mids; i++) {
--
Thanks,
Steve
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [CIFS] Remove unneeded statements pointed out by Coverity
2019-03-13 21:53 [PATCH] [CIFS] Remove unneeded statements pointed out by Coverity Steve French
@ 2019-03-13 22:14 ` ronnie sahlberg
0 siblings, 0 replies; 2+ messages in thread
From: ronnie sahlberg @ 2019-03-13 22:14 UTC (permalink / raw)
To: Steve French; +Cc: CIFS, LKML
reviewed by me
On Thu, Mar 14, 2019 at 7:53 AM Steve French <smfrench@gmail.com> wrote:
>
> cifs: remove unused value pointed out by Coverity
>
> Detected by CoverityScan CID#1438719 ("Unused Value")
>
> buf is reset again before being used so these two lines of code
> are useless.
>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> ---
> fs/cifs/connect.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index b95db2b593cb..a8e9738db691 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1191,10 +1191,6 @@ cifs_demultiplex_thread(void *p)
> continue;
> }
>
> - if (server->large_buf)
> - buf = server->bigbuf;
> -
> -
> server->lstrp = jiffies;
>
> for (i = 0; i < num_mids; i++) {
>
> --
> Thanks,
>
> Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-13 22:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-13 21:53 [PATCH] [CIFS] Remove unneeded statements pointed out by Coverity Steve French
2019-03-13 22:14 ` ronnie sahlberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).