* [PATCH] cifs: release cached dentries only if mount is complete
@ 2022-04-01 7:16 Shyam Prasad N
2022-04-01 7:24 ` ronnie sahlberg
0 siblings, 1 reply; 2+ messages in thread
From: Shyam Prasad N @ 2022-04-01 7:16 UTC (permalink / raw)
To: ronnie sahlberg, Steve French, CIFS
Hi Steve,
This is a fix for a bug seen during mount failure during my testing.
Ronnie has reviewed it. But will be good if you can review it too.
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/fcd5a7da1f616a7134bc4fb4e329e8f085f63801.patch
--
Regards,
Shyam
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cifs: release cached dentries only if mount is complete
2022-04-01 7:16 [PATCH] cifs: release cached dentries only if mount is complete Shyam Prasad N
@ 2022-04-01 7:24 ` ronnie sahlberg
0 siblings, 0 replies; 2+ messages in thread
From: ronnie sahlberg @ 2022-04-01 7:24 UTC (permalink / raw)
To: Shyam Prasad N; +Cc: Steve French, CIFS
I worked with Shyam on this.
It looks like when mount fails we might end up with garbage pointers
for the tlink/tcon that is stored in the cifs_sb->tlink_tree
so when we traverse the tree we oops when dereferencing the pointers we get.
This patch avoids the resulting oops but we should also try to find
out why there are bad pointers in the tree.
I will try to review the code for inserting tlink/tcon into the tree
and the lifetimes of tlink/tcon tomorrow.
On Fri, Apr 1, 2022 at 5:17 PM Shyam Prasad N <nspmangalore@gmail.com> wrote:
>
> Hi Steve,
>
> This is a fix for a bug seen during mount failure during my testing.
> Ronnie has reviewed it. But will be good if you can review it too.
>
> https://github.com/sprasad-microsoft/smb3-kernel-client/commit/fcd5a7da1f616a7134bc4fb4e329e8f085f63801.patch
>
> --
> Regards,
> Shyam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-01 7:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-01 7:16 [PATCH] cifs: release cached dentries only if mount is complete Shyam Prasad N
2022-04-01 7:24 ` ronnie sahlberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).