linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] cifsd: fix build error without CONFIG_OID_REGISTRY
@ 2021-05-20 13:42 ` Wei Yongjun
  2021-05-21  0:56   ` Namjae Jeon
  0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2021-05-20 13:42 UTC (permalink / raw)
  To: weiyongjun1, Namjae Jeon, Sergey Senozhatsky, Steve French, Hyunchul Lee
  Cc: linux-cifs, linux-cifsd-devel, kernel-janitors, Hulk Robot

Fix build error when CONFIG_OID_REGISTRY is not set:

mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `gssapi_this_mech':
asn1.c:(.text+0xaa0): undefined reference to `sprint_oid'
mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `neg_token_init_mech_type':
asn1.c:(.text+0xbec): undefined reference to `sprint_oid'

Fixes: fad4161b5cd0 ("cifsd: decoding gss token using lib/asn1_decoder.c")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 fs/cifsd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/cifsd/Kconfig b/fs/cifsd/Kconfig
index 5316b1035fbe..e6448b04f46e 100644
--- a/fs/cifsd/Kconfig
+++ b/fs/cifsd/Kconfig
@@ -18,6 +18,7 @@ config SMB_SERVER
 	select CRYPTO_CCM
 	select CRYPTO_GCM
 	select ASN1
+	select OID_REGISTRY
 	default n
 	help
 	  Choose Y here if you want to allow SMB3 compliant clients


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH -next] cifsd: fix build error without CONFIG_OID_REGISTRY
  2021-05-20 13:42 ` [PATCH -next] cifsd: fix build error without CONFIG_OID_REGISTRY Wei Yongjun
@ 2021-05-21  0:56   ` Namjae Jeon
  2021-05-21  1:28     ` Hyunchul Lee
  0 siblings, 1 reply; 3+ messages in thread
From: Namjae Jeon @ 2021-05-21  0:56 UTC (permalink / raw)
  To: 'Wei Yongjun', 'Sergey Senozhatsky',
	'Steve French', 'Hyunchul Lee'
  Cc: linux-cifs, linux-cifsd-devel, kernel-janitors, 'Hulk Robot'

> Fix build error when CONFIG_OID_REGISTRY is not set:
> 
> mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `gssapi_this_mech':
> asn1.c:(.text+0xaa0): undefined reference to `sprint_oid'
> mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `neg_token_init_mech_type':
> asn1.c:(.text+0xbec): undefined reference to `sprint_oid'
> 
> Fixes: fad4161b5cd0 ("cifsd: decoding gss token using lib/asn1_decoder.c")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I will apply it. Thanks for your patch!

Hyunchul, You also need to add this change to your cifs patch.

> ---
>  fs/cifsd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/cifsd/Kconfig b/fs/cifsd/Kconfig index 5316b1035fbe..e6448b04f46e 100644
> --- a/fs/cifsd/Kconfig
> +++ b/fs/cifsd/Kconfig
> @@ -18,6 +18,7 @@ config SMB_SERVER
>  	select CRYPTO_CCM
>  	select CRYPTO_GCM
>  	select ASN1
> +	select OID_REGISTRY
>  	default n
>  	help
>  	  Choose Y here if you want to allow SMB3 compliant clients



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] cifsd: fix build error without CONFIG_OID_REGISTRY
  2021-05-21  0:56   ` Namjae Jeon
@ 2021-05-21  1:28     ` Hyunchul Lee
  0 siblings, 0 replies; 3+ messages in thread
From: Hyunchul Lee @ 2021-05-21  1:28 UTC (permalink / raw)
  To: Namjae Jeon
  Cc: Wei Yongjun, Sergey Senozhatsky, Steve French, linux-cifs,
	linux-cifsd-devel, kernel-janitors, Hulk Robot

2021년 5월 21일 (금) 오전 9:56, Namjae Jeon <namjae.jeon@samsung.com>님이 작성:
>
> > Fix build error when CONFIG_OID_REGISTRY is not set:
> >
> > mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `gssapi_this_mech':
> > asn1.c:(.text+0xaa0): undefined reference to `sprint_oid'
> > mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `neg_token_init_mech_type':
> > asn1.c:(.text+0xbec): undefined reference to `sprint_oid'
> >
> > Fixes: fad4161b5cd0 ("cifsd: decoding gss token using lib/asn1_decoder.c")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> I will apply it. Thanks for your patch!
>
> Hyunchul, You also need to add this change to your cifs patch.
>

Okay, I will apply this.

Thanks,
Hyunchul

> > ---
> >  fs/cifsd/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/cifsd/Kconfig b/fs/cifsd/Kconfig index 5316b1035fbe..e6448b04f46e 100644
> > --- a/fs/cifsd/Kconfig
> > +++ b/fs/cifsd/Kconfig
> > @@ -18,6 +18,7 @@ config SMB_SERVER
> >       select CRYPTO_CCM
> >       select CRYPTO_GCM
> >       select ASN1
> > +     select OID_REGISTRY
> >       default n
> >       help
> >         Choose Y here if you want to allow SMB3 compliant clients
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-21  1:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20210520133301epcas1p325b7d973e4febb2e9832051462585213@epcas1p3.samsung.com>
2021-05-20 13:42 ` [PATCH -next] cifsd: fix build error without CONFIG_OID_REGISTRY Wei Yongjun
2021-05-21  0:56   ` Namjae Jeon
2021-05-21  1:28     ` Hyunchul Lee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).