From: Shyam Prasad N <nspmangalore@gmail.com>
To: Steve French <smfrench@gmail.com>,
CIFS <linux-cifs@vger.kernel.org>,
ronnie sahlberg <ronniesahlberg@gmail.com>,
rohiths msft <rohiths.msft@gmail.com>
Subject: [PATCH] cifs: create sd context must be a multiple of 8
Date: Thu, 5 Aug 2021 10:47:36 +0530 [thread overview]
Message-ID: <CANT5p=ouksRAiRLLexVhPZU1=iWwhiRUxw8dBRj-a_f2vjnEDw@mail.gmail.com> (raw)
Hi Steve,
Please review the fix for the bug reported at:
https://bugzilla.kernel.org/show_bug.cgi?id=213927
The issue was misalignment of create context caused by one of our
earlier commit:
commit ea64370bcae126a88cd26a16f1abcc23ab2b9a55 (tag: 5.10-rc6-smb3-fixes-part2)
Author: Ronnie Sahlberg <lsahlber@redhat.com>
Date: Mon Nov 30 11:29:20 2020 +1000
cifs: refactor create_sd_buf() and and avoid corrupting the buffer
When mounting with "idsfromsid" mount option, Azure
corrupted the owner SIDs due to excessive padding
caused by placing the owner fields at the end of the
security descriptor on create. Placing owners at the
front of the security descriptor (rather than the end)
is also safer, as the number of ACEs (that follow it)
are variable.
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Suggested-by: Rohith Surabattula <rohiths@microsoft.com>
CC: Stable <stable@vger.kernel.org> # v5.8
Signed-off-by: Steve French <stfrench@microsoft.com>
The fix can be found at:
https://github.com/sprasad-microsoft/smb3-kernel-client/pull/4
I think this should be marked for stable as well, with a "fixes" tag.
--
Regards,
Shyam
next reply other threads:[~2021-08-05 5:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 5:17 Shyam Prasad N [this message]
2021-08-05 5:56 ` [PATCH] cifs: create sd context must be a multiple of 8 ronnie sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANT5p=ouksRAiRLLexVhPZU1=iWwhiRUxw8dBRj-a_f2vjnEDw@mail.gmail.com' \
--to=nspmangalore@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=rohiths.msft@gmail.com \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).