[Bug 14476] Cannot set timestamp of Minshall-French symlinks from a CIFS mount

[Bug 14476] Cannot set timestamp of Minshall-French symlinks from a CIFS mount

[samba-bugs]

https://bugzilla.samba.org/show_bug.cgi?id=14476

Björn Jacke <bjacke@samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|samba-qa@samba.org          |cifs-qa@samba.org
           Assignee|samba-qa@samba.org          |sfrench@samba.org
          Component|Other                       |kernel fs
            Version|4.12.2                      |3.x
            Product|Samba 4.1 and newer         |CifsVFS

--- Comment #1 from Björn Jacke <bjacke@samba.org> ---
moving this to the cifsvfs product because the Minshall-French symlink are a
client-only thing.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

[Bug 14476] Cannot set timestamp of Minshall-French symlinks from a CIFS mount

[samba-bugs]

https://bugzilla.samba.org/show_bug.cgi?id=14476

Björn Jacke <bjacke@samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.x                         |5.x

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

[Bug 14476] Cannot set timestamp of Minshall-French symlinks from a CIFS mount

[samba-bugs]

https://bugzilla.samba.org/show_bug.cgi?id=14476

--- Comment #2 from Steve French <sfrench@samba.org> ---
David Howells spotted the problem - cifs.ko is missing setattr in the
cifs_symlink_inode_operations

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

[Bug 14476] Cannot set timestamp of Minshall-French symlinks from a CIFS mount

[samba-bugs]

https://bugzilla.samba.org/show_bug.cgi?id=14476

Steve French <sfrench@samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

[Bug 14476] Cannot set timestamp of Minshall-French symlinks from a CIFS mount

[samba-bugs]

https://bugzilla.samba.org/show_bug.cgi?id=14476

--- Comment #3 from Steve French <sfrench@samba.org> ---
This change fixes it:

diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c
index 22869cda1356..ea3a7a668b45 100644
--- a/fs/smb/client/cifsfs.c
+++ b/fs/smb/client/cifsfs.c
@@ -1191,6 +1191,7 @@ const char *cifs_get_link(struct dentry *dentry, struct
inode *inode,

 const struct inode_operations cifs_symlink_inode_ops = {
        .get_link = cifs_get_link,
+       .setattr = cifs_setattr,
        .permission = cifs_permission,
        .listxattr = cifs_listxattr,
 };

-- 
You are receiving this mail because:
You are the QA Contact for the bug.