[PATCH v2] clk: zynqmp: Check the return type zynqmp_pm_query_data

[PATCH v2] clk: zynqmp: Check the return type zynqmp_pm_query_data

[Shubhrajyoti Datta]

Check the return type of zynqmp_pm_query_data(qdata, ret_payload);

Addresses-Coverity: Event check_return
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
---
v2:
Update the documentation

 drivers/clk/zynqmp/clkc.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/zynqmp/clkc.c b/drivers/clk/zynqmp/clkc.c
index 75d895be2d89..013464af0344 100644
--- a/drivers/clk/zynqmp/clkc.c
+++ b/drivers/clk/zynqmp/clkc.c
@@ -220,18 +220,22 @@ static int zynqmp_pm_clock_get_num_clocks(u32 *nclocks)
  * This function is used to get name of clock specified by given
  * clock ID.
  *
- * Return: Returns 0
+ * Return: 0 on success else error+reason
  */
 static int zynqmp_pm_clock_get_name(u32 clock_id,
 				    struct name_resp *response)
 {
 	struct zynqmp_pm_query_data qdata = {0};
 	u32 ret_payload[PAYLOAD_ARG_CNT];
+	int ret;
 
 	qdata.qid = PM_QID_CLOCK_GET_NAME;
 	qdata.arg1 = clock_id;
 
-	zynqmp_pm_query_data(qdata, ret_payload);
+	ret = zynqmp_pm_query_data(qdata, ret_payload);
+	if (ret)
+		return ret;
+
 	memcpy(response, ret_payload, sizeof(*response));
 
 	return 0;
-- 
2.17.1

RE: [PATCH v2] clk: zynqmp: Check the return type zynqmp_pm_query_data

[Datta, Shubhrajyoti]

[AMD Official Use Only - General]

Gentle ping. 

> -----Original Message-----
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Sent: Wednesday, April 6, 2022 2:52 PM
> To: linux-clk@vger.kernel.org
> Cc: git <git@xilinx.com>; Shubhrajyoti Datta <shubhraj@xilinx.com>;
> sboyd@kernel.org; Michal Simek <michals@xilinx.com>
> Subject: [PATCH v2] clk: zynqmp: Check the return type
> zynqmp_pm_query_data
> 
> Check the return type of zynqmp_pm_query_data(qdata, ret_payload);
> 
> Addresses-Coverity: Event check_return
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---

Re: [PATCH v2] clk: zynqmp: Check the return type zynqmp_pm_query_data

[Michal Simek]

On 4/6/22 11:22, Shubhrajyoti Datta wrote:
> Check the return type of zynqmp_pm_query_data(qdata, ret_payload);
> 
> Addresses-Coverity: Event check_return
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
> v2:
> Update the documentation
> 
>   drivers/clk/zynqmp/clkc.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/zynqmp/clkc.c b/drivers/clk/zynqmp/clkc.c
> index 75d895be2d89..013464af0344 100644
> --- a/drivers/clk/zynqmp/clkc.c
> +++ b/drivers/clk/zynqmp/clkc.c
> @@ -220,18 +220,22 @@ static int zynqmp_pm_clock_get_num_clocks(u32 *nclocks)
>    * This function is used to get name of clock specified by given
>    * clock ID.
>    *
> - * Return: Returns 0
> + * Return: 0 on success else error+reason
>    */
>   static int zynqmp_pm_clock_get_name(u32 clock_id,
>   				    struct name_resp *response)
>   {
>   	struct zynqmp_pm_query_data qdata = {0};
>   	u32 ret_payload[PAYLOAD_ARG_CNT];
> +	int ret;
>   
>   	qdata.qid = PM_QID_CLOCK_GET_NAME;
>   	qdata.arg1 = clock_id;
>   
> -	zynqmp_pm_query_data(qdata, ret_payload);
> +	ret = zynqmp_pm_query_data(qdata, ret_payload);
> +	if (ret)
> +		return ret;
> +
>   	memcpy(response, ret_payload, sizeof(*response));
>   
>   	return 0;

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal

Re: [PATCH v2] clk: zynqmp: Check the return type zynqmp_pm_query_data

[Stephen Boyd]

Quoting Shubhrajyoti Datta (2022-04-06 02:22:11)
> Check the return type of zynqmp_pm_query_data(qdata, ret_payload);
> 
> Addresses-Coverity: Event check_return
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---

Applied to clk-next