From: Craig <ctatlor97@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Taniya Das
<tdas@codeaurora.org>,linux-arm-msm@vger.kernel.org,Michael
Turquette <mturquette@baylibre.com>,Stephen Boyd
<sboyd@kernel.org>,Rob Herring <robh+dt@kernel.org>,Mark Rutland
<mark.rutland@arm.com>,Andy Gross <andy.gross@linaro.org>,David
Brown
<david.brown@linaro.org>,linux-clk@vger.kernel.org,devicetree@vger.kernel.org,linux-kernel@vger.kernel.org,linux-soc@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: Add Global Clock controller (GCC) driver for SDM660
Date: Mon, 24 Sep 2018 15:33:56 +0100 [thread overview]
Message-ID: <0E2DD374-B1DA-47D9-B327-D5BBC39F7FBB@gmail.com> (raw)
In-Reply-To: <9156720.4hgryJ20kK@phil>
On 24 September 2018 13:44:33 BST, Heiko Stuebner <heiko@sntech=2Ede> wrot=
e:
>Hi Craig,
>
>Am Montag, 13=2E August 2018, 09:45:09 CEST schrieb Craig Tatlor:
>> On 13 August 2018 07:55:34 BST, Taniya Das <tdas@codeaurora=2Eorg>
>wrote:
>> >Hello Craig,
>> >
>> >Could you please correct the authorship and also provide the
>reference=20
>> >to code where this is picked from?
>> Okay,=20
>> Got code from here
>https://github=2Ecom/sonyxperiadev/kernel/blob/aosp/LA=2EUM=2E6=2E4=2Er1/=
drivers/clk/qcom/gcc-sdm660=2Ec
>> but changed it quite a bit for upstream,
>> Should I change the commit author and add your signed off by and say
>I did cleanups on my signed off by=2E
>
>yep, for something this huge it is really the correct way to keep the
>original authorship intact as Taniya did the initial big work, and just
>add you change-description, so something like
>
>---- 8< ------
>Add support for the global clock controller found on SDM660
>based devices=2E This should allow most non-multimedia device
>drivers to probe and control their clocks=2E
>Based on CAF implementation=2E
>
>Signed-off-by: Taniya Das <tdas@codeaurora=2Eorg>
>[ description of changes =2E=2E=2E often seen in these brackets ]
>Signed-off-by: Craig Tatlor <ctatlor97@gmail=2Ecom>
>---- 8< ------
>
Sure, will do, though I'm sure qcom have a program to generate the drivers=
:)
>Also, do you plan to continue working on this, as I would be
>interessted
>in the clock driver for a sdm660-based phone as well
Yup, was really just waiting for reply to this question,
>
>
>Thanks
>Heiko
--=20
WARNING: multiple messages have this Message-ID (diff)
From: Craig <ctatlor97@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Taniya Das <tdas@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: Add Global Clock controller (GCC) driver for SDM660
Date: Mon, 24 Sep 2018 15:33:56 +0100 [thread overview]
Message-ID: <0E2DD374-B1DA-47D9-B327-D5BBC39F7FBB@gmail.com> (raw)
Message-ID: <20180924143356.zxcZI3AmsXSLEfyGOEZsFsr2sdlxaQjxIA5Um8qhRV8@z> (raw)
In-Reply-To: <9156720.4hgryJ20kK@phil>
On 24 September 2018 13:44:33 BST, Heiko Stuebner <heiko@sntech.de> wrote:
>Hi Craig,
>
>Am Montag, 13. August 2018, 09:45:09 CEST schrieb Craig Tatlor:
>> On 13 August 2018 07:55:34 BST, Taniya Das <tdas@codeaurora.org>
>wrote:
>> >Hello Craig,
>> >
>> >Could you please correct the authorship and also provide the
>reference
>> >to code where this is picked from?
>> Okay,
>> Got code from here
>https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.6.4.r1/drivers/clk/qcom/gcc-sdm660.c
>> but changed it quite a bit for upstream,
>> Should I change the commit author and add your signed off by and say
>I did cleanups on my signed off by.
>
>yep, for something this huge it is really the correct way to keep the
>original authorship intact as Taniya did the initial big work, and just
>add you change-description, so something like
>
>---- 8< ------
>Add support for the global clock controller found on SDM660
>based devices. This should allow most non-multimedia device
>drivers to probe and control their clocks.
>Based on CAF implementation.
>
>Signed-off-by: Taniya Das <tdas@codeaurora.org>
>[ description of changes ... often seen in these brackets ]
>Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
>---- 8< ------
>
Sure, will do, though I'm sure qcom have a program to generate the drivers :)
>Also, do you plan to continue working on this, as I would be
>interessted
>in the clock driver for a sdm660-based phone as well
Yup, was really just waiting for reply to this question,
>
>
>Thanks
>Heiko
--
next prev parent reply other threads:[~2018-09-24 14:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180407135934.26122-1-ctatlor97@gmail.com>
2018-08-10 20:21 ` [PATCH] clk: qcom: Add Global Clock controller (GCC) driver for SDM660 Craig Tatlor
2018-08-11 21:30 ` kbuild test robot
2018-08-11 21:30 ` [RFC PATCH] clk: qcom: gcc_sdm660_hws[] can be static kbuild test robot
2018-08-13 6:55 ` [PATCH] clk: qcom: Add Global Clock controller (GCC) driver for SDM660 Taniya Das
2018-08-13 7:45 ` Craig Tatlor
2018-09-24 12:44 ` Heiko Stuebner
2018-09-24 12:44 ` Heiko Stuebner
2018-09-24 14:33 ` Craig [this message]
2018-09-24 14:33 ` Craig
2018-08-13 9:44 ` Craig Tatlor
2018-09-25 16:35 ` [PATCH v2] " Craig Tatlor
2018-09-25 16:35 ` Craig Tatlor
2018-09-25 17:35 ` [PATCH v3] " Craig Tatlor
2018-09-25 17:35 ` Craig Tatlor
2018-09-27 19:51 ` Rob Herring
2018-09-27 19:51 ` Rob Herring
2018-10-08 6:51 ` Craig
2018-10-16 22:05 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E2DD374-B1DA-47D9-B327-D5BBC39F7FBB@gmail.com \
--to=ctatlor97@gmail.com \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).