* Re: [chanwoo:devfreq-testing 15/16] drivers//devfreq/tegra30-devfreq.c:478:8: error: implicit declaration of function 'clk_set_min_rate'; did you mean 'clk_set_rate'?
[not found] <201904242234.3ZpDzMBq%lkp@intel.com>
@ 2019-04-24 14:41 ` Dmitry Osipenko
2019-04-24 23:23 ` Stephen Boyd
2019-04-25 0:03 ` Chanwoo Choi
0 siblings, 2 replies; 5+ messages in thread
From: Dmitry Osipenko @ 2019-04-24 14:41 UTC (permalink / raw)
To: Chanwoo Choi; +Cc: linux-clk
24.04.2019 17:22, kbuild test robot пишет:
> Hi Dmitry,
>
> First bad commit (maybe != root cause):
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git devfreq-testing
> head: 6b3a07e6458befbb8b90010e92d578b08678e5ce
> commit: d2a110d18c755979bffa07f45d3b4ff89e420954 [15/16] PM / devfreq: tegra: Rename tegra-devfreq.c to tegra30-devfreq.c
> config: sparc64-allmodconfig (attached as .config)
> compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout d2a110d18c755979bffa07f45d3b4ff89e420954
> # save the attached .config to linux build tree
> GCC_VERSION=7.2.0 make.cross ARCH=sparc64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> All errors (new ones prefixed by >>):
>
> drivers//devfreq/tegra30-devfreq.c: In function 'tegra_devfreq_target':
>>> drivers//devfreq/tegra30-devfreq.c:478:8: error: implicit declaration of function 'clk_set_min_rate'; did you mean 'clk_set_rate'? [-Werror=implicit-function-declaration]
> err = clk_set_min_rate(tegra->emc_clock, rate);
> ^~~~~~~~~~~~~~~~
> clk_set_rate
> cc1: some warnings being treated as errors
>
> vim +478 drivers//devfreq/tegra30-devfreq.c
>
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 460
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 461 static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 462 u32 flags)
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 463 {
> 11573e913 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2015-03-17 464 struct tegra_devfreq *tegra = dev_get_drvdata(dev);
> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 465 struct devfreq *devfreq = tegra->devfreq;
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 466 struct dev_pm_opp *opp;
> e76bb6df1 drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 467 unsigned long rate;
> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 468 int err;
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 469
> e76bb6df1 drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 470 opp = devfreq_recommended_opp(dev, freq, flags);
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 471 if (IS_ERR(opp)) {
> e76bb6df1 drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 472 dev_err(dev, "Failed to find opp for %lu Hz\n", *freq);
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 473 return PTR_ERR(opp);
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 474 }
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 475 rate = dev_pm_opp_get_freq(opp);
> 8a31d9d94 drivers/devfreq/tegra-devfreq.c Viresh Kumar 2017-01-23 476 dev_pm_opp_put(opp);
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 477
> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 @478 err = clk_set_min_rate(tegra->emc_clock, rate);
> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 479 if (err)
> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 480 return err;
> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 481
> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 482 err = clk_set_rate(tegra->emc_clock, 0);
> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 483 if (err)
> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 484 goto restore_min_rate;
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 485
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 486 return 0;
> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 487
> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 488 restore_min_rate:
> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 489 clk_set_min_rate(tegra->emc_clock, devfreq->previous_freq);
> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 490
> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 491 return err;
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 492 }
> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 493
>
> :::::: The code at line 478 was first introduced by commit
> :::::: 7f2e3eb6fa764bb003164c331c93306a8e1223c3 PM / devfreq: tegra: Don't ignore clk errors
>
> :::::: TO: Dmitry Osipenko <digetx@gmail.com>
> :::::: CC: Chanwoo Choi <cw00.choi@samsung.com>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
Oh, there is no declaration for clk_set_min_rate() when CONFIG_COMMON_CLK=n. Either driver should be made dependent on CONFIG_COMMON_CLK or the declaration should be added to include/linux/clk.h (the same applies to tegra20-devfreq).
Chanwoo, what will we do?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [chanwoo:devfreq-testing 15/16] drivers//devfreq/tegra30-devfreq.c:478:8: error: implicit declaration of function 'clk_set_min_rate'; did you mean 'clk_set_rate'?
2019-04-24 14:41 ` [chanwoo:devfreq-testing 15/16] drivers//devfreq/tegra30-devfreq.c:478:8: error: implicit declaration of function 'clk_set_min_rate'; did you mean 'clk_set_rate'? Dmitry Osipenko
@ 2019-04-24 23:23 ` Stephen Boyd
2019-04-24 23:37 ` Dmitry Osipenko
2019-04-25 0:03 ` Chanwoo Choi
1 sibling, 1 reply; 5+ messages in thread
From: Stephen Boyd @ 2019-04-24 23:23 UTC (permalink / raw)
To: Chanwoo Choi, Dmitry Osipenko; +Cc: linux-clk
Quoting Dmitry Osipenko (2019-04-24 07:41:56)
>
> Oh, there is no declaration for clk_set_min_rate() when CONFIG_COMMON_CLK=n. Either driver should be made dependent on CONFIG_COMMON_CLK or the declaration should be added to include/linux/clk.h (the same applies to tegra20-devfreq).
>
> Chanwoo, what will we do?
Send a patch to add the empty wrappers to clk.h please.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [chanwoo:devfreq-testing 15/16] drivers//devfreq/tegra30-devfreq.c:478:8: error: implicit declaration of function 'clk_set_min_rate'; did you mean 'clk_set_rate'?
2019-04-24 23:23 ` Stephen Boyd
@ 2019-04-24 23:37 ` Dmitry Osipenko
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Osipenko @ 2019-04-24 23:37 UTC (permalink / raw)
To: Stephen Boyd, Chanwoo Choi; +Cc: linux-clk
25.04.2019 2:23, Stephen Boyd пишет:
> Quoting Dmitry Osipenko (2019-04-24 07:41:56)
>>
>> Oh, there is no declaration for clk_set_min_rate() when CONFIG_COMMON_CLK=n. Either driver should be made dependent on CONFIG_COMMON_CLK or the declaration should be added to include/linux/clk.h (the same applies to tegra20-devfreq).
>>
>> Chanwoo, what will we do?
>
> Send a patch to add the empty wrappers to clk.h please.
>
All right!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [chanwoo:devfreq-testing 15/16] drivers//devfreq/tegra30-devfreq.c:478:8: error: implicit declaration of function 'clk_set_min_rate'; did you mean 'clk_set_rate'?
2019-04-24 14:41 ` [chanwoo:devfreq-testing 15/16] drivers//devfreq/tegra30-devfreq.c:478:8: error: implicit declaration of function 'clk_set_min_rate'; did you mean 'clk_set_rate'? Dmitry Osipenko
2019-04-24 23:23 ` Stephen Boyd
@ 2019-04-25 0:03 ` Chanwoo Choi
2019-04-25 13:35 ` Dmitry Osipenko
1 sibling, 1 reply; 5+ messages in thread
From: Chanwoo Choi @ 2019-04-25 0:03 UTC (permalink / raw)
To: Dmitry Osipenko; +Cc: linux-clk
Hi Dmitry,
On 19. 4. 24. 오후 11:41, Dmitry Osipenko wrote:
> 24.04.2019 17:22, kbuild test robot пишет:
>> Hi Dmitry,
>>
>> First bad commit (maybe != root cause):
>>
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git devfreq-testing
>> head: 6b3a07e6458befbb8b90010e92d578b08678e5ce
>> commit: d2a110d18c755979bffa07f45d3b4ff89e420954 [15/16] PM / devfreq: tegra: Rename tegra-devfreq.c to tegra30-devfreq.c
>> config: sparc64-allmodconfig (attached as .config)
>> compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
>> reproduce:
>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> git checkout d2a110d18c755979bffa07f45d3b4ff89e420954
>> # save the attached .config to linux build tree
>> GCC_VERSION=7.2.0 make.cross ARCH=sparc64
>>
>> If you fix the issue, kindly add following tag
>> Reported-by: kbuild test robot <lkp@intel.com>
>> All errors (new ones prefixed by >>):
>>
>> drivers//devfreq/tegra30-devfreq.c: In function 'tegra_devfreq_target':
>>>> drivers//devfreq/tegra30-devfreq.c:478:8: error: implicit declaration of function 'clk_set_min_rate'; did you mean 'clk_set_rate'? [-Werror=implicit-function-declaration]
>> err = clk_set_min_rate(tegra->emc_clock, rate);
>> ^~~~~~~~~~~~~~~~
>> clk_set_rate
>> cc1: some warnings being treated as errors
>>
>> vim +478 drivers//devfreq/tegra30-devfreq.c
>>
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 460
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 461 static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 462 u32 flags)
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 463 {
>> 11573e913 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2015-03-17 464 struct tegra_devfreq *tegra = dev_get_drvdata(dev);
>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 465 struct devfreq *devfreq = tegra->devfreq;
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 466 struct dev_pm_opp *opp;
>> e76bb6df1 drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 467 unsigned long rate;
>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 468 int err;
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 469
>> e76bb6df1 drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 470 opp = devfreq_recommended_opp(dev, freq, flags);
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 471 if (IS_ERR(opp)) {
>> e76bb6df1 drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 472 dev_err(dev, "Failed to find opp for %lu Hz\n", *freq);
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 473 return PTR_ERR(opp);
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 474 }
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 475 rate = dev_pm_opp_get_freq(opp);
>> 8a31d9d94 drivers/devfreq/tegra-devfreq.c Viresh Kumar 2017-01-23 476 dev_pm_opp_put(opp);
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 477
>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 @478 err = clk_set_min_rate(tegra->emc_clock, rate);
>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 479 if (err)
>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 480 return err;
>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 481
>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 482 err = clk_set_rate(tegra->emc_clock, 0);
>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 483 if (err)
>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 484 goto restore_min_rate;
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 485
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 486 return 0;
>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 487
>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 488 restore_min_rate:
>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 489 clk_set_min_rate(tegra->emc_clock, devfreq->previous_freq);
>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 490
>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 491 return err;
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 492 }
>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 493
>>
>> :::::: The code at line 478 was first introduced by commit
>> :::::: 7f2e3eb6fa764bb003164c331c93306a8e1223c3 PM / devfreq: tegra: Don't ignore clk errors
>>
>> :::::: TO: Dmitry Osipenko <digetx@gmail.com>
>> :::::: CC: Chanwoo Choi <cw00.choi@samsung.com>
>>
>> ---
>> 0-DAY kernel test infrastructure Open Source Technology Center
>> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>>
>
> Oh, there is no declaration for clk_set_min_rate() when CONFIG_COMMON_CLK=n. Either driver should be made dependent on CONFIG_COMMON_CLK or the declaration should be added to include/linux/clk.h (the same applies to tegra20-devfreq).
>
> Chanwoo, what will we do?
>
>
I applied your patches to my testing branch for build test.
It is not applied to official branch.
As the Stephen comments, please resend it after fixing this issue.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [chanwoo:devfreq-testing 15/16] drivers//devfreq/tegra30-devfreq.c:478:8: error: implicit declaration of function 'clk_set_min_rate'; did you mean 'clk_set_rate'?
2019-04-25 0:03 ` Chanwoo Choi
@ 2019-04-25 13:35 ` Dmitry Osipenko
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Osipenko @ 2019-04-25 13:35 UTC (permalink / raw)
To: Chanwoo Choi; +Cc: linux-clk
25.04.2019 3:03, Chanwoo Choi пишет:
> Hi Dmitry,
>
> On 19. 4. 24. 오후 11:41, Dmitry Osipenko wrote:
>> 24.04.2019 17:22, kbuild test robot пишет:
>>> Hi Dmitry,
>>>
>>> First bad commit (maybe != root cause):
>>>
>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git devfreq-testing
>>> head: 6b3a07e6458befbb8b90010e92d578b08678e5ce
>>> commit: d2a110d18c755979bffa07f45d3b4ff89e420954 [15/16] PM / devfreq: tegra: Rename tegra-devfreq.c to tegra30-devfreq.c
>>> config: sparc64-allmodconfig (attached as .config)
>>> compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
>>> reproduce:
>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>> chmod +x ~/bin/make.cross
>>> git checkout d2a110d18c755979bffa07f45d3b4ff89e420954
>>> # save the attached .config to linux build tree
>>> GCC_VERSION=7.2.0 make.cross ARCH=sparc64
>>>
>>> If you fix the issue, kindly add following tag
>>> Reported-by: kbuild test robot <lkp@intel.com>
>>> All errors (new ones prefixed by >>):
>>>
>>> drivers//devfreq/tegra30-devfreq.c: In function 'tegra_devfreq_target':
>>>>> drivers//devfreq/tegra30-devfreq.c:478:8: error: implicit declaration of function 'clk_set_min_rate'; did you mean 'clk_set_rate'? [-Werror=implicit-function-declaration]
>>> err = clk_set_min_rate(tegra->emc_clock, rate);
>>> ^~~~~~~~~~~~~~~~
>>> clk_set_rate
>>> cc1: some warnings being treated as errors
>>>
>>> vim +478 drivers//devfreq/tegra30-devfreq.c
>>>
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 460
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 461 static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 462 u32 flags)
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 463 {
>>> 11573e913 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2015-03-17 464 struct tegra_devfreq *tegra = dev_get_drvdata(dev);
>>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 465 struct devfreq *devfreq = tegra->devfreq;
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 466 struct dev_pm_opp *opp;
>>> e76bb6df1 drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 467 unsigned long rate;
>>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 468 int err;
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 469
>>> e76bb6df1 drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 470 opp = devfreq_recommended_opp(dev, freq, flags);
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 471 if (IS_ERR(opp)) {
>>> e76bb6df1 drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 472 dev_err(dev, "Failed to find opp for %lu Hz\n", *freq);
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 473 return PTR_ERR(opp);
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 474 }
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 475 rate = dev_pm_opp_get_freq(opp);
>>> 8a31d9d94 drivers/devfreq/tegra-devfreq.c Viresh Kumar 2017-01-23 476 dev_pm_opp_put(opp);
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 477
>>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 @478 err = clk_set_min_rate(tegra->emc_clock, rate);
>>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 479 if (err)
>>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 480 return err;
>>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 481
>>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 482 err = clk_set_rate(tegra->emc_clock, 0);
>>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 483 if (err)
>>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 484 goto restore_min_rate;
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 485
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 486 return 0;
>>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 487
>>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 488 restore_min_rate:
>>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 489 clk_set_min_rate(tegra->emc_clock, devfreq->previous_freq);
>>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 490
>>> 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 491 return err;
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 492 }
>>> 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 493
>>>
>>> :::::: The code at line 478 was first introduced by commit
>>> :::::: 7f2e3eb6fa764bb003164c331c93306a8e1223c3 PM / devfreq: tegra: Don't ignore clk errors
>>>
>>> :::::: TO: Dmitry Osipenko <digetx@gmail.com>
>>> :::::: CC: Chanwoo Choi <cw00.choi@samsung.com>
>>>
>>> ---
>>> 0-DAY kernel test infrastructure Open Source Technology Center
>>> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>>>
>>
>> Oh, there is no declaration for clk_set_min_rate() when CONFIG_COMMON_CLK=n. Either driver should be made dependent on CONFIG_COMMON_CLK or the declaration should be added to include/linux/clk.h (the same applies to tegra20-devfreq).
>>
>> Chanwoo, what will we do?
>>
>>
>
> I applied your patches to my testing branch for build test.
> It is not applied to official branch.
>
> As the Stephen comments, please resend it after fixing this issue.
>
>
I sent out the the patch to fix the issue and will resend the devfreq series after the clk patch will get applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-25 13:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201904242234.3ZpDzMBq%lkp@intel.com>
2019-04-24 14:41 ` [chanwoo:devfreq-testing 15/16] drivers//devfreq/tegra30-devfreq.c:478:8: error: implicit declaration of function 'clk_set_min_rate'; did you mean 'clk_set_rate'? Dmitry Osipenko
2019-04-24 23:23 ` Stephen Boyd
2019-04-24 23:37 ` Dmitry Osipenko
2019-04-25 0:03 ` Chanwoo Choi
2019-04-25 13:35 ` Dmitry Osipenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).