From: Michael Turquette <mturquette@baylibre.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org
Cc: b.zolnierkie@samsung.com, "Sylwester Nawrocki" <s.nawrocki@samsung.com>
Subject: Re: [PATCH] clk: samsung: Allow modular build of the Audio Subsystem CLKCON driver
Date: Fri, 08 Jul 2016 09:56:46 -0700 [thread overview]
Message-ID: <146799700614.73491.6564650478987470074@resonance> (raw)
In-Reply-To: <1467987300-31450-1-git-send-email-s.nawrocki@samsung.com>
Quoting Sylwester Nawrocki (2016-07-08 07:15:00)
> Any clock dependencies can be properly handled with deferred probing
> so we can remove core_initcall and switch to a proper loadable platform
> driver module.
> This change has been tested on Exynos4412 Odroid U3 based board.
> =
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Looks good to me.
Regards,
Mike
> ---
> drivers/clk/samsung/Kconfig | 9 +++++++++
> drivers/clk/samsung/Makefile | 2 +-
> drivers/clk/samsung/clk-exynos-audss.c | 12 +-----------
> 3 files changed, 11 insertions(+), 12 deletions(-)
> =
> diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
> index 20c5fe9..addc652 100644
> --- a/drivers/clk/samsung/Kconfig
> +++ b/drivers/clk/samsung/Kconfig
> @@ -9,6 +9,15 @@ config EXYNOS_ARM64_COMMON_CLK
> bool "Samsung Exynos ARMv8-family clock controller support" if CO=
MPILE_TEST
> depends on COMMON_CLK_SAMSUNG
> =
> +config EXYNOS_AUDSS_CLK_CON
> + tristate "Samsung Exynos AUDSS clock controller support"
> + depends on COMMON_CLK_SAMSUNG
> + default y if ARCH_EXYNOS
> + help
> + Support for the Audio Subsystem CLKCON clock controller present
> + on some Exynos SoC variants. Choose M or Y here if you want to
> + use audio devices such as I2S, PCM, etc.
> +
> # For S3C24XX platforms, select following symbols:
> config S3C2410_COMMON_CLK
> bool "Samsung S3C2410 clock controller support" if COMPILE_TEST
> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
> index fc367d4..57f4dc6 100644
> --- a/drivers/clk/samsung/Makefile
> +++ b/drivers/clk/samsung/Makefile
> @@ -12,7 +12,7 @@ obj-$(CONFIG_SOC_EXYNOS5410) +=3D clk-exynos5410.o
> obj-$(CONFIG_SOC_EXYNOS5420) +=3D clk-exynos5420.o
> obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) +=3D clk-exynos5433.o
> obj-$(CONFIG_SOC_EXYNOS5440) +=3D clk-exynos5440.o
> -obj-$(CONFIG_ARCH_EXYNOS) +=3D clk-exynos-audss.o
> +obj-$(CONFIG_EXYNOS_AUDSS_CLK_CON) +=3D clk-exynos-audss.o
> obj-$(CONFIG_ARCH_EXYNOS) +=3D clk-exynos-clkout.o
> obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) +=3D clk-exynos7.o
> obj-$(CONFIG_S3C2410_COMMON_CLK)+=3D clk-s3c2410.o
> diff --git a/drivers/clk/samsung/clk-exynos-audss.c b/drivers/clk/samsung=
/clk-exynos-audss.c
> index 4e9584d..bdf8b97 100644
> --- a/drivers/clk/samsung/clk-exynos-audss.c
> +++ b/drivers/clk/samsung/clk-exynos-audss.c
> @@ -273,17 +273,7 @@ static struct platform_driver exynos_audss_clk_drive=
r =3D {
> .remove =3D exynos_audss_clk_remove,
> };
> =
> -static int __init exynos_audss_clk_init(void)
> -{
> - return platform_driver_register(&exynos_audss_clk_driver);
> -}
> -core_initcall(exynos_audss_clk_init);
> -
> -static void __exit exynos_audss_clk_exit(void)
> -{
> - platform_driver_unregister(&exynos_audss_clk_driver);
> -}
> -module_exit(exynos_audss_clk_exit);
> +module_platform_driver(exynos_audss_clk_driver);
> =
> MODULE_AUTHOR("Padmavathi Venna <padma.v@samsung.com>");
> MODULE_DESCRIPTION("Exynos Audio Subsystem Clock Controller");
> -- =
> 1.9.1
> =
> --
> To unsubscribe from this list: send the line "unsubscribe linux-clk" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-07-08 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 14:15 [PATCH] clk: samsung: Allow modular build of the Audio Subsystem CLKCON driver Sylwester Nawrocki
2016-07-08 16:56 ` Michael Turquette [this message]
2016-07-13 10:23 ` Sylwester Nawrocki
2016-07-13 22:00 ` Michael Turquette
2016-07-19 9:26 ` Krzysztof Kozłowski
2016-07-19 9:55 ` Sylwester Nawrocki
2016-07-21 18:22 ` Sylwester Nawrocki
2016-07-11 8:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=146799700614.73491.6564650478987470074@resonance \
--to=mturquette@baylibre.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).