From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: "Krzysztof Kozłowski" <k.kozlowski.k+lkml@gmail.com>
Cc: "Michael Turquette" <mturquette@baylibre.com>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
"Bartłomiej Żołnierkiewicz" <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] clk: samsung: Allow modular build of the Audio Subsystem CLKCON driver
Date: Thu, 21 Jul 2016 20:22:49 +0200 [thread overview]
Message-ID: <579112F9.3030608@samsung.com> (raw)
In-Reply-To: <578DF91D.8050800@samsung.com>
On 07/19/2016 11:55 AM, Sylwester Nawrocki wrote:
>> Unfortunately this breaks the audio on Odroid XU3 (simple-card). There
>> > is no sound from:
>> > $ aplay /usr/share/sounds/alsa/Front_Right.wav
>> > and the command does not exit.
>> >
>> > Sylwester,
>> > Are you going to look at this?
>
> Thanks for the bug report, I will check what's the problem here.
> Odroid U3 also uses simple card and same codec and it all works there.
It turned out that the difference was using ADMA on XU3 vs. PDMA on U3.
AUDSS clock controller provides a clock for ADMA and converting the AUDSS
clk driver to a loadable module causes deferring ADMA's controller
initialization, which was not handled properly by the sound component
drivers.
I've sent a patch to fix the issue, added you at Cc.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2016-07-21 18:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 14:15 [PATCH] clk: samsung: Allow modular build of the Audio Subsystem CLKCON driver Sylwester Nawrocki
2016-07-08 16:56 ` Michael Turquette
2016-07-13 10:23 ` Sylwester Nawrocki
2016-07-13 22:00 ` Michael Turquette
2016-07-19 9:26 ` Krzysztof Kozłowski
2016-07-19 9:55 ` Sylwester Nawrocki
2016-07-21 18:22 ` Sylwester Nawrocki [this message]
2016-07-11 8:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579112F9.3030608@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=k.kozlowski.k+lkml@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).