* [PATCH V3] clk: vc5: Add suspend/resume support
@ 2018-12-13 16:15 Marek Vasut
2018-12-13 20:39 ` Laurent Pinchart
2018-12-14 21:44 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2018-12-13 16:15 UTC (permalink / raw)
To: linux-clk
Cc: linux-renesas-soc, Marek Vasut, Alexey Firago, Laurent Pinchart,
Michael Turquette, Stephen Boyd
Add simple suspend/resume handlers to the driver to restore the chip
configuration after resume. It is possible that the chip was configured
with non-default values before suspend-resume cycle and that the chip
is powered down during this cycle, so the configuration could get lost.
Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Alexey Firago <alexey_firago@mentor.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-renesas-soc@vger.kernel.org
---
V2: Replace ifdef with __maybe_unused
Simplify return value handling in resume
V3: Drop useless regcache_sync() call from suspend callback
(thanks Laurent for testing with working DU)
---
drivers/clk/clk-versaclock5.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c
index decffb3826ec..5b393e711e94 100644
--- a/drivers/clk/clk-versaclock5.c
+++ b/drivers/clk/clk-versaclock5.c
@@ -906,6 +906,28 @@ static int vc5_remove(struct i2c_client *client)
return 0;
}
+static int __maybe_unused vc5_suspend(struct device *dev)
+{
+ struct vc5_driver_data *vc5 = dev_get_drvdata(dev);
+
+ regcache_cache_only(vc5->regmap, true);
+ regcache_mark_dirty(vc5->regmap);
+
+ return 0;
+}
+
+static int __maybe_unused vc5_resume(struct device *dev)
+{
+ struct vc5_driver_data *vc5 = dev_get_drvdata(dev);
+ int ret;
+
+ regcache_cache_only(vc5->regmap, false);
+ ret = regcache_sync(vc5->regmap);
+ if (ret)
+ dev_err(dev, "Failed to restore register map: %d\n", ret);
+ return ret;
+}
+
static const struct vc5_chip_info idt_5p49v5923_info = {
.model = IDT_VC5_5P49V5923,
.clk_fod_cnt = 2,
@@ -961,9 +983,12 @@ static const struct of_device_id clk_vc5_of_match[] = {
};
MODULE_DEVICE_TABLE(of, clk_vc5_of_match);
+static SIMPLE_DEV_PM_OPS(vc5_pm_ops, vc5_suspend, vc5_resume);
+
static struct i2c_driver vc5_driver = {
.driver = {
.name = "vc5",
+ .pm = &vc5_pm_ops,
.of_match_table = clk_vc5_of_match,
},
.probe = vc5_probe,
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V3] clk: vc5: Add suspend/resume support
2018-12-13 16:15 [PATCH V3] clk: vc5: Add suspend/resume support Marek Vasut
@ 2018-12-13 20:39 ` Laurent Pinchart
2018-12-14 21:44 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2018-12-13 20:39 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-clk, linux-renesas-soc, Marek Vasut, Alexey Firago,
Michael Turquette, Stephen Boyd
Hi Marek,
Thank you for the patch.
On Thursday, 13 December 2018 18:15:28 EET Marek Vasut wrote:
> Add simple suspend/resume handlers to the driver to restore the chip
> configuration after resume. It is possible that the chip was configured
> with non-default values before suspend-resume cycle and that the chip
> is powered down during this cycle, so the configuration could get lost.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Alexey Firago <alexey_firago@mentor.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: linux-renesas-soc@vger.kernel.org
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> V2: Replace ifdef with __maybe_unused
> Simplify return value handling in resume
> V3: Drop useless regcache_sync() call from suspend callback
> (thanks Laurent for testing with working DU)
> ---
> drivers/clk/clk-versaclock5.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c
> index decffb3826ec..5b393e711e94 100644
> --- a/drivers/clk/clk-versaclock5.c
> +++ b/drivers/clk/clk-versaclock5.c
> @@ -906,6 +906,28 @@ static int vc5_remove(struct i2c_client *client)
> return 0;
> }
>
> +static int __maybe_unused vc5_suspend(struct device *dev)
> +{
> + struct vc5_driver_data *vc5 = dev_get_drvdata(dev);
> +
> + regcache_cache_only(vc5->regmap, true);
> + regcache_mark_dirty(vc5->regmap);
> +
> + return 0;
> +}
> +
> +static int __maybe_unused vc5_resume(struct device *dev)
> +{
> + struct vc5_driver_data *vc5 = dev_get_drvdata(dev);
> + int ret;
> +
> + regcache_cache_only(vc5->regmap, false);
> + ret = regcache_sync(vc5->regmap);
> + if (ret)
> + dev_err(dev, "Failed to restore register map: %d\n", ret);
> + return ret;
> +}
> +
> static const struct vc5_chip_info idt_5p49v5923_info = {
> .model = IDT_VC5_5P49V5923,
> .clk_fod_cnt = 2,
> @@ -961,9 +983,12 @@ static const struct of_device_id clk_vc5_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, clk_vc5_of_match);
>
> +static SIMPLE_DEV_PM_OPS(vc5_pm_ops, vc5_suspend, vc5_resume);
> +
> static struct i2c_driver vc5_driver = {
> .driver = {
> .name = "vc5",
> + .pm = &vc5_pm_ops,
> .of_match_table = clk_vc5_of_match,
> },
> .probe = vc5_probe,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V3] clk: vc5: Add suspend/resume support
2018-12-13 16:15 [PATCH V3] clk: vc5: Add suspend/resume support Marek Vasut
2018-12-13 20:39 ` Laurent Pinchart
@ 2018-12-14 21:44 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2018-12-14 21:44 UTC (permalink / raw)
To: Marek Vasut, linux-clk
Cc: linux-renesas-soc, Marek Vasut, Alexey Firago, Laurent Pinchart,
Michael Turquette, Stephen Boyd
Quoting Marek Vasut (2018-12-13 08:15:28)
> Add simple suspend/resume handlers to the driver to restore the chip
> configuration after resume. It is possible that the chip was configured
> with non-default values before suspend-resume cycle and that the chip
> is powered down during this cycle, so the configuration could get lost.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Alexey Firago <alexey_firago@mentor.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: linux-renesas-soc@vger.kernel.org
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-14 21:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-13 16:15 [PATCH V3] clk: vc5: Add suspend/resume support Marek Vasut
2018-12-13 20:39 ` Laurent Pinchart
2018-12-14 21:44 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).