* [PATCH] clk: vf610: fix refcount leak in vf610_clocks_init()
@ 2018-12-26 13:59 Yangtao Li
2018-12-28 19:41 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2018-12-26 13:59 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, fabio.estevam, linux-imx, mturquette, sboyd
Cc: linux-arm-kernel, linux-clk, linux-kernel, Yangtao Li
The of_find_compatible_node() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/clk/imx/clk-vf610.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/imx/clk-vf610.c b/drivers/clk/imx/clk-vf610.c
index 6dae54325a91..a334667c450a 100644
--- a/drivers/clk/imx/clk-vf610.c
+++ b/drivers/clk/imx/clk-vf610.c
@@ -203,6 +203,7 @@ static void __init vf610_clocks_init(struct device_node *ccm_node)
np = of_find_compatible_node(NULL, NULL, "fsl,vf610-anatop");
anatop_base = of_iomap(np, 0);
BUG_ON(!anatop_base);
+ of_node_put(np);
np = ccm_node;
ccm_base = of_iomap(np, 0);
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: vf610: fix refcount leak in vf610_clocks_init()
2018-12-26 13:59 [PATCH] clk: vf610: fix refcount leak in vf610_clocks_init() Yangtao Li
@ 2018-12-28 19:41 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2018-12-28 19:41 UTC (permalink / raw)
To: Yangtao Li, fabio.estevam, kernel, linux-imx, mturquette,
s.hauer, shawnguo
Cc: linux-arm-kernel, linux-clk, linux-kernel, Yangtao Li
Quoting Yangtao Li (2018-12-26 05:59:36)
> The of_find_compatible_node() returns a node pointer with refcount
> incremented, but there is the lack of use of the of_node_put() when
> done. Add the missing of_node_put() to release the refcount.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-28 19:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-26 13:59 [PATCH] clk: vf610: fix refcount leak in vf610_clocks_init() Yangtao Li
2018-12-28 19:41 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).