Linux-Clk Archive on lore.kernel.org
 help / Atom feed
* [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support
@ 2019-01-11 11:55 Aisheng Dong
  2019-01-11 11:55 ` [PATCH RESEND v1 1/4] dt-bindings: fsl: scu: add fallback compatible string for clock Aisheng Dong
                   ` (4 more replies)
  0 siblings, 5 replies; 16+ messages in thread
From: Aisheng Dong @ 2019-01-11 11:55 UTC (permalink / raw)
  To: linux-clk
  Cc: linux-arm-kernel, sboyd, mturquette, shawnguo, Fabio Estevam,
	dl-linux-imx, kernel, robh+dt, devicetree, Aisheng Dong

After a bit more investigation on IMX8QM, it seemed SCU clock can be used
in a similar way as IMX8QXP. So update the binding and driver to be a bit
generic for easily extension of IMX8QM support later.

Dong Aisheng (4):
  dt-bindings: fsl: scu: add fallback compatible string for clock
  dt-bindings: fsl: scu: add imx8qm scu clock support
  clk: imx: scu: add fallback compatible string support
  dt-bindings: imx8-clock: add a53 and a72 clock id

 Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 7 +++++--
 drivers/clk/imx/clk-imx8qxp.c                               | 1 +
 include/dt-bindings/clock/imx8-clock.h                      | 6 ++++--
 3 files changed, 10 insertions(+), 4 deletions(-)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH RESEND v1 1/4] dt-bindings: fsl: scu: add fallback compatible string for clock
  2019-01-11 11:55 [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
@ 2019-01-11 11:55 ` Aisheng Dong
  2019-01-21 23:25   ` Rob Herring
  2019-01-22 19:05   ` Stephen Boyd
  2019-01-11 11:56 ` [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support Aisheng Dong
                   ` (3 subsequent siblings)
  4 siblings, 2 replies; 16+ messages in thread
From: Aisheng Dong @ 2019-01-11 11:55 UTC (permalink / raw)
  To: linux-clk
  Cc: linux-arm-kernel, sboyd, mturquette, shawnguo, Fabio Estevam,
	dl-linux-imx, kernel, robh+dt, devicetree, Aisheng Dong

SCU clock can be used in a similar way by IMX8QXP and IMX8QM SoCs.
Let's add a "fsl,scu-clk" fallback compatible string to allow other
SoCs to reuse the common part.

Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
index 27784b6..5ec6dca 100644
--- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
+++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
@@ -70,7 +70,9 @@ Clock bindings based on SCU Message Protocol
 This binding uses the common clock binding[1].
 
 Required properties:
-- compatible:		Should be "fsl,imx8qxp-clock".
+- compatible:		Should be one of:
+			  "fsl,imx8qxp-clock"
+			followed by "fsl,scu-clk"
 - #clock-cells:		Should be 1. Contains the Clock ID value.
 - clocks:		List of clock specifiers, must contain an entry for
 			each required entry in clock-names
@@ -137,7 +139,7 @@ firmware {
 			  &lsio_mu1 1 3>;
 
 		clk: clk {
-			compatible = "fsl,imx8qxp-clk";
+			compatible = "fsl,imx8qxp-clk", "fsl,scu-clk";
 			#clock-cells = <1>;
 		};
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support
  2019-01-11 11:55 [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
  2019-01-11 11:55 ` [PATCH RESEND v1 1/4] dt-bindings: fsl: scu: add fallback compatible string for clock Aisheng Dong
@ 2019-01-11 11:56 ` Aisheng Dong
  2019-01-21 23:27   ` Rob Herring
  2019-01-22 19:06   ` Stephen Boyd
  2019-01-11 11:56 ` [PATCH RESEND v1 3/4] clk: imx: scu: add fallback compatible string support Aisheng Dong
                   ` (2 subsequent siblings)
  4 siblings, 2 replies; 16+ messages in thread
From: Aisheng Dong @ 2019-01-11 11:56 UTC (permalink / raw)
  To: linux-clk
  Cc: linux-arm-kernel, sboyd, mturquette, shawnguo, Fabio Estevam,
	dl-linux-imx, kernel, robh+dt, devicetree, Aisheng Dong

Add imx8qm scu clock support

Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
index 5ec6dca..b6a883e 100644
--- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
+++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
@@ -71,7 +71,8 @@ This binding uses the common clock binding[1].
 
 Required properties:
 - compatible:		Should be one of:
-			  "fsl,imx8qxp-clock"
+			  "fsl,imx8qm-clock",
+			  "fsl,imx8qxp-clock".
 			followed by "fsl,scu-clk"
 - #clock-cells:		Should be 1. Contains the Clock ID value.
 - clocks:		List of clock specifiers, must contain an entry for
-- 
2.7.4


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH RESEND v1 3/4] clk: imx: scu: add fallback compatible string support
  2019-01-11 11:55 [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
  2019-01-11 11:55 ` [PATCH RESEND v1 1/4] dt-bindings: fsl: scu: add fallback compatible string for clock Aisheng Dong
  2019-01-11 11:56 ` [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support Aisheng Dong
@ 2019-01-11 11:56 ` Aisheng Dong
  2019-01-11 11:56 ` [PATCH RESEND v1 4/4] dt-bindings: imx8-clock: add a53 and a72 clock id Aisheng Dong
  2019-01-16  5:40 ` [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
  4 siblings, 0 replies; 16+ messages in thread
From: Aisheng Dong @ 2019-01-11 11:56 UTC (permalink / raw)
  To: linux-clk
  Cc: linux-arm-kernel, sboyd, mturquette, shawnguo, Fabio Estevam,
	dl-linux-imx, kernel, robh+dt, devicetree, Aisheng Dong

SCU clock can be used in a similar way by IMX8QXP and IMX8QM SoCs.
Make the driver support "fsl,scu-clk" fallback compatible string
to allow other SoCs to reuse the common part.

Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 drivers/clk/imx/clk-imx8qxp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c
index 83e2ef9..5e2903e 100644
--- a/drivers/clk/imx/clk-imx8qxp.c
+++ b/drivers/clk/imx/clk-imx8qxp.c
@@ -138,6 +138,7 @@ static int imx8qxp_clk_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id imx8qxp_match[] = {
+	{ .compatible = "fsl,scu-clk", },
 	{ .compatible = "fsl,imx8qxp-clk", },
 	{ /* sentinel */ }
 };
-- 
2.7.4


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH RESEND v1 4/4] dt-bindings: imx8-clock: add a53 and a72 clock id
  2019-01-11 11:55 [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
                   ` (2 preceding siblings ...)
  2019-01-11 11:56 ` [PATCH RESEND v1 3/4] clk: imx: scu: add fallback compatible string support Aisheng Dong
@ 2019-01-11 11:56 ` Aisheng Dong
  2019-01-22  0:10   ` Rob Herring
  2019-01-16  5:40 ` [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
  4 siblings, 1 reply; 16+ messages in thread
From: Aisheng Dong @ 2019-01-11 11:56 UTC (permalink / raw)
  To: linux-clk
  Cc: linux-arm-kernel, sboyd, mturquette, shawnguo, Fabio Estevam,
	dl-linux-imx, kernel, robh+dt, devicetree, Aisheng Dong

Add a53 and a72 clock id, as there's still no users, we update
IMX_LSIO_MEM_CLK base to start from 6 to allow a53 and a72 clock
id to be continued with a35 clk.

Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 include/dt-bindings/clock/imx8-clock.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/include/dt-bindings/clock/imx8-clock.h b/include/dt-bindings/clock/imx8-clock.h
index 4236818..2f1aa2f 100644
--- a/include/dt-bindings/clock/imx8-clock.h
+++ b/include/dt-bindings/clock/imx8-clock.h
@@ -13,10 +13,12 @@
 
 /* CPU */
 #define IMX_A35_CLK					1
+#define IMX_A53_CLK					2
+#define IMX_A72_CLK					3
 
 /* LSIO SS */
-#define IMX_LSIO_MEM_CLK				2
-#define IMX_LSIO_BUS_CLK				3
+#define IMX_LSIO_MEM_CLK				6
+#define IMX_LSIO_BUS_CLK				7
 #define IMX_LSIO_PWM0_CLK				10
 #define IMX_LSIO_PWM1_CLK				11
 #define IMX_LSIO_PWM2_CLK				12
-- 
2.7.4


^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support
  2019-01-11 11:55 [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
                   ` (3 preceding siblings ...)
  2019-01-11 11:56 ` [PATCH RESEND v1 4/4] dt-bindings: imx8-clock: add a53 and a72 clock id Aisheng Dong
@ 2019-01-16  5:40 ` Aisheng Dong
  2019-01-16 11:02   ` Shawn Guo
  4 siblings, 1 reply; 16+ messages in thread
From: Aisheng Dong @ 2019-01-16  5:40 UTC (permalink / raw)
  To: Aisheng Dong, Shawn Guo, linux-clk, sboyd
  Cc: linux-arm-kernel, mturquette, shawnguo, Fabio Estevam,
	dl-linux-imx, kernel, robh+dt, devicetree

Ping...

BTW, as the first two patches change the same firmware binding doc fs.scu.txt.
I'm not sure whether it should go to Shawn's tree for the binding part, or Stephen's clock tree.

Shawn & Stephen,
What's your suggestion?

Regards
Dong Aisheng

> From: Aisheng Dong [mailto:aisheng.dong@nxp.com]
> Sent: Friday, January 11, 2019 7:56 PM
> 
> After a bit more investigation on IMX8QM, it seemed SCU clock can be used in
> a similar way as IMX8QXP. So update the binding and driver to be a bit generic
> for easily extension of IMX8QM support later.
> 
> Dong Aisheng (4):
>   dt-bindings: fsl: scu: add fallback compatible string for clock
>   dt-bindings: fsl: scu: add imx8qm scu clock support
>   clk: imx: scu: add fallback compatible string support
>   dt-bindings: imx8-clock: add a53 and a72 clock id
> 
>  Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 7 +++++--
>  drivers/clk/imx/clk-imx8qxp.c                               | 1 +
>  include/dt-bindings/clock/imx8-clock.h                      | 6 ++++--
>  3 files changed, 10 insertions(+), 4 deletions(-)
> 
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support
  2019-01-16  5:40 ` [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
@ 2019-01-16 11:02   ` Shawn Guo
  2019-01-22 19:06     ` Stephen Boyd
  0 siblings, 1 reply; 16+ messages in thread
From: Shawn Guo @ 2019-01-16 11:02 UTC (permalink / raw)
  To: Aisheng Dong
  Cc: linux-clk, sboyd, linux-arm-kernel, mturquette, Fabio Estevam,
	dl-linux-imx, kernel, robh+dt, devicetree

On Wed, Jan 16, 2019 at 05:40:01AM +0000, Aisheng Dong wrote:
> Ping...
> 
> BTW, as the first two patches change the same firmware binding doc fs.scu.txt.
> I'm not sure whether it should go to Shawn's tree for the binding part, or Stephen's clock tree.
> 
> Shawn & Stephen,
> What's your suggestion?

I can apply the first two to my tree as long as Rob and Stephen ack on
them.

Shawn

> 
> Regards
> Dong Aisheng
> 
> > From: Aisheng Dong [mailto:aisheng.dong@nxp.com]
> > Sent: Friday, January 11, 2019 7:56 PM
> > 
> > After a bit more investigation on IMX8QM, it seemed SCU clock can be used in
> > a similar way as IMX8QXP. So update the binding and driver to be a bit generic
> > for easily extension of IMX8QM support later.
> > 
> > Dong Aisheng (4):
> >   dt-bindings: fsl: scu: add fallback compatible string for clock
> >   dt-bindings: fsl: scu: add imx8qm scu clock support
> >   clk: imx: scu: add fallback compatible string support
> >   dt-bindings: imx8-clock: add a53 and a72 clock id
> > 
> >  Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 7 +++++--
> >  drivers/clk/imx/clk-imx8qxp.c                               | 1 +
> >  include/dt-bindings/clock/imx8-clock.h                      | 6 ++++--
> >  3 files changed, 10 insertions(+), 4 deletions(-)
> > 
> > --
> > 2.7.4
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH RESEND v1 1/4] dt-bindings: fsl: scu: add fallback compatible  string for clock
  2019-01-11 11:55 ` [PATCH RESEND v1 1/4] dt-bindings: fsl: scu: add fallback compatible string for clock Aisheng Dong
@ 2019-01-21 23:25   ` Rob Herring
  2019-01-22 19:05   ` Stephen Boyd
  1 sibling, 0 replies; 16+ messages in thread
From: Rob Herring @ 2019-01-21 23:25 UTC (permalink / raw)
  To: Aisheng Dong
  Cc: linux-clk, linux-arm-kernel, sboyd, mturquette, shawnguo,
	Fabio Estevam, dl-linux-imx, kernel, robh+dt, devicetree,
	Aisheng Dong

On Fri, 11 Jan 2019 11:55:56 +0000, Aisheng Dong wrote:
> SCU clock can be used in a similar way by IMX8QXP and IMX8QM SoCs.
> Let's add a "fsl,scu-clk" fallback compatible string to allow other
> SoCs to reuse the common part.
> 
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support
  2019-01-11 11:56 ` [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support Aisheng Dong
@ 2019-01-21 23:27   ` Rob Herring
  2019-01-22 12:58     ` Aisheng Dong
  2019-01-22 19:06   ` Stephen Boyd
  1 sibling, 1 reply; 16+ messages in thread
From: Rob Herring @ 2019-01-21 23:27 UTC (permalink / raw)
  To: Aisheng Dong
  Cc: linux-clk, linux-arm-kernel, sboyd, mturquette, shawnguo,
	Fabio Estevam, dl-linux-imx, kernel, devicetree

On Fri, Jan 11, 2019 at 11:56:00AM +0000, Aisheng Dong wrote:
> Add imx8qm scu clock support
> 
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index 5ec6dca..b6a883e 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -71,7 +71,8 @@ This binding uses the common clock binding[1].
>  
>  Required properties:
>  - compatible:		Should be one of:
> -			  "fsl,imx8qxp-clock"
> +			  "fsl,imx8qm-clock",
> +			  "fsl,imx8qxp-clock".

No need for the punctuation here. The whole point of one per line is to 
have 1 line changes. Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

>  			followed by "fsl,scu-clk"
>  - #clock-cells:		Should be 1. Contains the Clock ID value.
>  - clocks:		List of clock specifiers, must contain an entry for
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH RESEND v1 4/4] dt-bindings: imx8-clock: add a53 and a72 clock id
  2019-01-11 11:56 ` [PATCH RESEND v1 4/4] dt-bindings: imx8-clock: add a53 and a72 clock id Aisheng Dong
@ 2019-01-22  0:10   ` Rob Herring
  2019-01-22 12:59     ` Aisheng Dong
  0 siblings, 1 reply; 16+ messages in thread
From: Rob Herring @ 2019-01-22  0:10 UTC (permalink / raw)
  To: Aisheng Dong
  Cc: linux-clk, linux-arm-kernel, sboyd, mturquette, shawnguo,
	Fabio Estevam, dl-linux-imx, kernel, devicetree

On Fri, Jan 11, 2019 at 11:56:09AM +0000, Aisheng Dong wrote:
> Add a53 and a72 clock id, as there's still no users, we update
> IMX_LSIO_MEM_CLK base to start from 6 to allow a53 and a72 clock
> id to be continued with a35 clk.
> 
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  include/dt-bindings/clock/imx8-clock.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/include/dt-bindings/clock/imx8-clock.h b/include/dt-bindings/clock/imx8-clock.h
> index 4236818..2f1aa2f 100644
> --- a/include/dt-bindings/clock/imx8-clock.h
> +++ b/include/dt-bindings/clock/imx8-clock.h
> @@ -13,10 +13,12 @@
>  
>  /* CPU */
>  #define IMX_A35_CLK					1
> +#define IMX_A53_CLK					2
> +#define IMX_A72_CLK					3

All 3 cores in one chip? If not maybe these should be split or define 
them as cpu cluster x clocks.

>  
>  /* LSIO SS */
> -#define IMX_LSIO_MEM_CLK				2
> -#define IMX_LSIO_BUS_CLK				3
> +#define IMX_LSIO_MEM_CLK				6
> +#define IMX_LSIO_BUS_CLK				7
>  #define IMX_LSIO_PWM0_CLK				10
>  #define IMX_LSIO_PWM1_CLK				11
>  #define IMX_LSIO_PWM2_CLK				12
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support
  2019-01-21 23:27   ` Rob Herring
@ 2019-01-22 12:58     ` Aisheng Dong
  0 siblings, 0 replies; 16+ messages in thread
From: Aisheng Dong @ 2019-01-22 12:58 UTC (permalink / raw)
  To: Rob Herring
  Cc: linux-clk, linux-arm-kernel, sboyd, mturquette, shawnguo,
	Fabio Estevam, dl-linux-imx, kernel, devicetree

> >  Required properties:
> >  - compatible:		Should be one of:
> > -			  "fsl,imx8qxp-clock"
> > +			  "fsl,imx8qm-clock",
> > +			  "fsl,imx8qxp-clock".
> 
> No need for the punctuation here. The whole point of one per line is to have 1
> line changes. Otherwise,
> 

Got it, thanks.
I will update it later.

> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> >  			followed by "fsl,scu-clk"
> >  - #clock-cells:		Should be 1. Contains the Clock ID value.
> >  - clocks:		List of clock specifiers, must contain an entry for
> > --
> > 2.7.4
> >

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH RESEND v1 4/4] dt-bindings: imx8-clock: add a53 and a72 clock id
  2019-01-22  0:10   ` Rob Herring
@ 2019-01-22 12:59     ` Aisheng Dong
  2019-01-30 16:45       ` Rob Herring
  0 siblings, 1 reply; 16+ messages in thread
From: Aisheng Dong @ 2019-01-22 12:59 UTC (permalink / raw)
  To: Rob Herring
  Cc: linux-clk, linux-arm-kernel, sboyd, mturquette, shawnguo,
	Fabio Estevam, dl-linux-imx, kernel, devicetree

> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Tuesday, January 22, 2019 8:10 AM
> 
> On Fri, Jan 11, 2019 at 11:56:09AM +0000, Aisheng Dong wrote:
> > Add a53 and a72 clock id, as there's still no users, we update
> > IMX_LSIO_MEM_CLK base to start from 6 to allow a53 and a72 clock id to
> > be continued with a35 clk.
> >
> > Cc: Stephen Boyd <sboyd@kernel.org>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Sascha Hauer <kernel@pengutronix.de>
> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > Cc: Michael Turquette <mturquette@baylibre.com>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> >  include/dt-bindings/clock/imx8-clock.h | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/dt-bindings/clock/imx8-clock.h
> > b/include/dt-bindings/clock/imx8-clock.h
> > index 4236818..2f1aa2f 100644
> > --- a/include/dt-bindings/clock/imx8-clock.h
> > +++ b/include/dt-bindings/clock/imx8-clock.h
> > @@ -13,10 +13,12 @@
> >
> >  /* CPU */
> >  #define IMX_A35_CLK					1
> > +#define IMX_A53_CLK					2
> > +#define IMX_A72_CLK					3
> 
> All 3 cores in one chip? If not maybe these should be split or define them as
> cpu cluster x clocks.
> 

Not in one chip.
Here are common clock IDs used for both MX8QXP and MX8QM.
You mean change to something like below?

#define IMX_CPU_CLUSTER_A53_CLK			2
#define IMX_CPU_CLUSTER_A72_CLK			3

Regards
Dong Aisheng

> >
> >  /* LSIO SS */
> > -#define IMX_LSIO_MEM_CLK				2
> > -#define IMX_LSIO_BUS_CLK				3
> > +#define IMX_LSIO_MEM_CLK				6
> > +#define IMX_LSIO_BUS_CLK				7
> >  #define IMX_LSIO_PWM0_CLK				10
> >  #define IMX_LSIO_PWM1_CLK				11
> >  #define IMX_LSIO_PWM2_CLK				12
> > --
> > 2.7.4
> >

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH RESEND v1 1/4] dt-bindings: fsl: scu: add fallback compatible string for clock
  2019-01-11 11:55 ` [PATCH RESEND v1 1/4] dt-bindings: fsl: scu: add fallback compatible string for clock Aisheng Dong
  2019-01-21 23:25   ` Rob Herring
@ 2019-01-22 19:05   ` Stephen Boyd
  1 sibling, 0 replies; 16+ messages in thread
From: Stephen Boyd @ 2019-01-22 19:05 UTC (permalink / raw)
  To: linux-clk, Aisheng Dong
  Cc: linux-arm-kernel, mturquette, shawnguo, Fabio Estevam,
	dl-linux-imx, kernel, robh+dt, devicetree, Aisheng Dong

Quoting Aisheng Dong (2019-01-11 03:55:56)
> SCU clock can be used in a similar way by IMX8QXP and IMX8QM SoCs.
> Let's add a "fsl,scu-clk" fallback compatible string to allow other
> SoCs to reuse the common part.
> 
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---

Acked-by: Stephen Boyd <sboyd@kernel.org>


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support
  2019-01-11 11:56 ` [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support Aisheng Dong
  2019-01-21 23:27   ` Rob Herring
@ 2019-01-22 19:06   ` Stephen Boyd
  1 sibling, 0 replies; 16+ messages in thread
From: Stephen Boyd @ 2019-01-22 19:06 UTC (permalink / raw)
  To: linux-clk, Aisheng Dong
  Cc: linux-arm-kernel, mturquette, shawnguo, Fabio Estevam,
	dl-linux-imx, kernel, robh+dt, devicetree, Aisheng Dong

Quoting Aisheng Dong (2019-01-11 03:56:00)
> Add imx8qm scu clock support
> 
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---

Acked-by: Stephen Boyd <sboyd@kernel.org>


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support
  2019-01-16 11:02   ` Shawn Guo
@ 2019-01-22 19:06     ` Stephen Boyd
  0 siblings, 0 replies; 16+ messages in thread
From: Stephen Boyd @ 2019-01-22 19:06 UTC (permalink / raw)
  To: Aisheng Dong, Shawn Guo
  Cc: linux-clk, linux-arm-kernel, mturquette, Fabio Estevam,
	dl-linux-imx, kernel, robh+dt, devicetree

Quoting Shawn Guo (2019-01-16 03:02:17)
> On Wed, Jan 16, 2019 at 05:40:01AM +0000, Aisheng Dong wrote:
> > Ping...
> > 
> > BTW, as the first two patches change the same firmware binding doc fs.scu.txt.
> > I'm not sure whether it should go to Shawn's tree for the binding part, or Stephen's clock tree.
> > 
> > Shawn & Stephen,
> > What's your suggestion?
> 
> I can apply the first two to my tree as long as Rob and Stephen ack on
> them.
> 

The first two are documentation updates? I don't care really either way,
so I gave my ack in case you want to pick them up before I get around to
the rest of the series.


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH RESEND v1 4/4] dt-bindings: imx8-clock: add a53 and a72 clock id
  2019-01-22 12:59     ` Aisheng Dong
@ 2019-01-30 16:45       ` Rob Herring
  0 siblings, 0 replies; 16+ messages in thread
From: Rob Herring @ 2019-01-30 16:45 UTC (permalink / raw)
  To: Aisheng Dong
  Cc: linux-clk, linux-arm-kernel, sboyd, mturquette, shawnguo,
	Fabio Estevam, dl-linux-imx, kernel, devicetree

On Tue, Jan 22, 2019 at 6:59 AM Aisheng Dong <aisheng.dong@nxp.com> wrote:
>
> > From: Rob Herring [mailto:robh@kernel.org]
> > Sent: Tuesday, January 22, 2019 8:10 AM
> >
> > On Fri, Jan 11, 2019 at 11:56:09AM +0000, Aisheng Dong wrote:
> > > Add a53 and a72 clock id, as there's still no users, we update
> > > IMX_LSIO_MEM_CLK base to start from 6 to allow a53 and a72 clock id to
> > > be continued with a35 clk.
> > >
> > > Cc: Stephen Boyd <sboyd@kernel.org>
> > > Cc: Rob Herring <robh+dt@kernel.org>
> > > Cc: devicetree@vger.kernel.org
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Cc: Sascha Hauer <kernel@pengutronix.de>
> > > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > > Cc: Michael Turquette <mturquette@baylibre.com>
> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > > ---
> > >  include/dt-bindings/clock/imx8-clock.h | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/include/dt-bindings/clock/imx8-clock.h
> > > b/include/dt-bindings/clock/imx8-clock.h
> > > index 4236818..2f1aa2f 100644
> > > --- a/include/dt-bindings/clock/imx8-clock.h
> > > +++ b/include/dt-bindings/clock/imx8-clock.h
> > > @@ -13,10 +13,12 @@
> > >
> > >  /* CPU */
> > >  #define IMX_A35_CLK                                        1
> > > +#define IMX_A53_CLK                                        2
> > > +#define IMX_A72_CLK                                        3
> >
> > All 3 cores in one chip? If not maybe these should be split or define them as
> > cpu cluster x clocks.
> >
>
> Not in one chip.
> Here are common clock IDs used for both MX8QXP and MX8QM.
> You mean change to something like below?
>
> #define IMX_CPU_CLUSTER_A53_CLK                 2
> #define IMX_CPU_CLUSTER_A72_CLK                 3

What happened to A35? What I'm saying is if the same clock controller
registers are used across chips even if the cores are different, use
the same clock ID. Ideally, clock IDs have some relationship to the
h/w such as their control register address and offset.

To put it another way, don't create a common number space of clock IDs
across SoCs unless they are strictly subsets and supersets of each
other.

Rob

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, back to index

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11 11:55 [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
2019-01-11 11:55 ` [PATCH RESEND v1 1/4] dt-bindings: fsl: scu: add fallback compatible string for clock Aisheng Dong
2019-01-21 23:25   ` Rob Herring
2019-01-22 19:05   ` Stephen Boyd
2019-01-11 11:56 ` [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support Aisheng Dong
2019-01-21 23:27   ` Rob Herring
2019-01-22 12:58     ` Aisheng Dong
2019-01-22 19:06   ` Stephen Boyd
2019-01-11 11:56 ` [PATCH RESEND v1 3/4] clk: imx: scu: add fallback compatible string support Aisheng Dong
2019-01-11 11:56 ` [PATCH RESEND v1 4/4] dt-bindings: imx8-clock: add a53 and a72 clock id Aisheng Dong
2019-01-22  0:10   ` Rob Herring
2019-01-22 12:59     ` Aisheng Dong
2019-01-30 16:45       ` Rob Herring
2019-01-16  5:40 ` [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
2019-01-16 11:02   ` Shawn Guo
2019-01-22 19:06     ` Stephen Boyd

Linux-Clk Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-clk/0 linux-clk/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-clk linux-clk/ https://lore.kernel.org/linux-clk \
		linux-clk@vger.kernel.org linux-clk@archiver.kernel.org
	public-inbox-index linux-clk


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-clk


AGPL code for this site: git clone https://public-inbox.org/ public-inbox