Linux-Clk Archive on lore.kernel.org
 help / color / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Zhou Yanjie <zhouyanjie@zoho.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	mturquette@baylibre.com, paul.burton@mips.com, sboyd@kernel.org,
	robh+dt@kernel.org, syq@debian.org, mark.rutland@arm.com
Subject: Re: [PATCH 1/2 v3] dt-bindings: clock: Add X1000 bindings.
Date: Mon, 11 Nov 2019 02:13:52 +0100
Message-ID: <1573434832.3.1@crapouillou.net> (raw)
In-Reply-To: <1573378102-72380-2-git-send-email-zhouyanjie@zoho.com>

Hi Zhou,


Le dim., nov. 10, 2019 at 17:28, Zhou Yanjie <zhouyanjie@zoho.com> a 
écrit :
> Add the clock bindings for the X1000 Soc from Ingenic.
> 
> Signed-off-by: Zhou Yanjie <zhouyanjie@zoho.com>

Reviewed-by: Paul Cercueil <paul@crapouillou.net>

> ---
>  .../devicetree/bindings/clock/ingenic,cgu.txt      |  1 +
>  include/dt-bindings/clock/x1000-cgu.h              | 44 
> ++++++++++++++++++++++
>  2 files changed, 45 insertions(+)
>  create mode 100644 include/dt-bindings/clock/x1000-cgu.h

When you send a revised version of a patchset, it's common practice to 
have a per-patch changelog right here. Then a cover letter is only 
really needed for big patchsets that need extra information.

> 
> diff --git a/Documentation/devicetree/bindings/clock/ingenic,cgu.txt 
> b/Documentation/devicetree/bindings/clock/ingenic,cgu.txt
> index ba5a442..75598e6 100644
> --- a/Documentation/devicetree/bindings/clock/ingenic,cgu.txt
> +++ b/Documentation/devicetree/bindings/clock/ingenic,cgu.txt
> @@ -11,6 +11,7 @@ Required properties:
>    * ingenic,jz4725b-cgu
>    * ingenic,jz4770-cgu
>    * ingenic,jz4780-cgu
> +  * ingenic,x1000-cgu
>  - reg : The address & length of the CGU registers.
>  - clocks : List of phandle & clock specifiers for clocks external to 
> the CGU.
>    Two such external clocks should be specified - first the external 
> crystal
> diff --git a/include/dt-bindings/clock/x1000-cgu.h 
> b/include/dt-bindings/clock/x1000-cgu.h
> new file mode 100644
> index 00000000..bbaebaf
> --- /dev/null
> +++ b/include/dt-bindings/clock/x1000-cgu.h
> @@ -0,0 +1,44 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * This header provides clock numbers for the ingenic,x1000-cgu DT 
> binding.
> + *
> + * They are roughly ordered as:
> + *   - external clocks
> + *   - PLLs
> + *   - muxes/dividers in the order they appear in the x1000 
> programmers manual
> + *   - gates in order of their bit in the CLKGR* registers
> + */
> +
> +#ifndef __DT_BINDINGS_CLOCK_X1000_CGU_H__
> +#define __DT_BINDINGS_CLOCK_X1000_CGU_H__
> +
> +#define X1000_CLK_EXCLK		0
> +#define X1000_CLK_RTCLK		1
> +#define X1000_CLK_APLL		2
> +#define X1000_CLK_MPLL		3
> +#define X1000_CLK_SCLKA		4
> +#define X1000_CLK_CPUMUX	5
> +#define X1000_CLK_CPU		6
> +#define X1000_CLK_L2CACHE	7
> +#define X1000_CLK_AHB0		8
> +#define X1000_CLK_AHB2PMUX	9
> +#define X1000_CLK_AHB2		10
> +#define X1000_CLK_PCLK		11
> +#define X1000_CLK_DDR		12
> +#define X1000_CLK_MAC		13
> +#define X1000_CLK_MSCMUX	14
> +#define X1000_CLK_MSC0		15
> +#define X1000_CLK_MSC1		16
> +#define X1000_CLK_SSIPLL	17
> +#define X1000_CLK_SSIMUX	18
> +#define X1000_CLK_SFC		19
> +#define X1000_CLK_I2C0		20
> +#define X1000_CLK_I2C1		21
> +#define X1000_CLK_I2C2		22
> +#define X1000_CLK_UART0		23
> +#define X1000_CLK_UART1		24
> +#define X1000_CLK_UART2		25
> +#define X1000_CLK_SSI		26
> +#define X1000_CLK_PDMA		27
> +
> +#endif /* __DT_BINDINGS_CLOCK_X1000_CGU_H__ */
> --
> 2.7.4
> 
> 



  reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 17:50 clk: X1000: Add support for the X1000 Zhou Yanjie
2019-10-18 17:50 ` [PATCH 1/2] dt-bindings: clock: Add X1000 bindings Zhou Yanjie
2019-10-18 17:50 ` [PATCH 2/2] clk: Ingenic: Add CGU driver for X1000 Zhou Yanjie
2019-10-21 12:31   ` Paul Cercueil
2019-10-22 15:34     ` Zhou Yanjie
2019-10-22 16:56 ` clk: X1000: Add support for the X1000 v2 Zhou Yanjie
2019-10-22 16:56   ` [PATCH 1/2 v2] dt-bindings: clock: Add X1000 bindings Zhou Yanjie
2019-10-25 21:49     ` Rob Herring
2019-10-22 16:56   ` [PATCH 2/2 v2] clk: Ingenic: Add CGU driver for X1000 Zhou Yanjie
2019-11-02 21:27     ` Paul Cercueil
2019-11-10  9:28 ` clk: X1000: Add support for the X1000 v3 Zhou Yanjie
2019-11-10  9:28   ` [PATCH 1/2 v3] dt-bindings: clock: Add X1000 bindings Zhou Yanjie
2019-11-11  1:13     ` Paul Cercueil [this message]
2019-11-12  0:55     ` Rob Herring
2019-11-10  9:28   ` [PATCH 2/2 v3] clk: Ingenic: Add CGU driver for X1000 Zhou Yanjie
2019-11-11  1:16     ` Paul Cercueil

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1573434832.3.1@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=paul.burton@mips.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=syq@debian.org \
    --cc=zhouyanjie@zoho.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Clk Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-clk/0 linux-clk/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-clk linux-clk/ https://lore.kernel.org/linux-clk \
		linux-clk@vger.kernel.org
	public-inbox-index linux-clk

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-clk


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git