linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] ipq806x: gcc: Added the enable regs and mask for PRNG
@ 2020-03-18 13:16 Ansuel Smith
  2020-03-20 23:28 ` Stephen Boyd
  2020-03-20 23:29 ` Stephen Boyd
  0 siblings, 2 replies; 3+ messages in thread
From: Ansuel Smith @ 2020-03-18 13:16 UTC (permalink / raw)
  To: Andy Gross
  Cc: Abhishek Sahu, Ansuel Smith, Bjorn Andersson, Michael Turquette,
	Stephen Boyd, Kumar Gala, linux-arm-msm, linux-clk, linux-kernel

From: Abhishek Sahu <absahu@codeaurora.org>

Kernel got hanged while reading from /dev/hwrng at the
time of PRNG clock enable

Fixes: 24d8fba44af3 "clk: qcom: Add support for IPQ8064's global
clock controller (GCC)"

Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
v2:
 * Fix wrong authorship

 drivers/clk/qcom/gcc-ipq806x.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c
index b0eee0903807..a8456e09c44d 100644
--- a/drivers/clk/qcom/gcc-ipq806x.c
+++ b/drivers/clk/qcom/gcc-ipq806x.c
@@ -1224,6 +1224,8 @@ static struct clk_rcg prng_src = {
 		.parent_map = gcc_pxo_pll8_map,
 	},
 	.clkr = {
+		.enable_reg = 0x2e80,
+		.enable_mask = BIT(11),
 		.hw.init = &(struct clk_init_data){
 			.name = "prng_src",
 			.parent_names = gcc_pxo_pll8,
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ipq806x: gcc: Added the enable regs and mask for PRNG
  2020-03-18 13:16 [PATCH v2] ipq806x: gcc: Added the enable regs and mask for PRNG Ansuel Smith
@ 2020-03-20 23:28 ` Stephen Boyd
  2020-03-20 23:29 ` Stephen Boyd
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-03-20 23:28 UTC (permalink / raw)
  To: Andy Gross, Ansuel Smith
  Cc: Abhishek Sahu, Ansuel Smith, Bjorn Andersson, Michael Turquette,
	Kumar Gala, linux-arm-msm, linux-clk, linux-kernel

Quoting Ansuel Smith (2020-03-18 06:16:56)
> From: Abhishek Sahu <absahu@codeaurora.org>
> 
> Kernel got hanged while reading from /dev/hwrng at the
> time of PRNG clock enable
> 
> Fixes: 24d8fba44af3 "clk: qcom: Add support for IPQ8064's global
> clock controller (GCC)"
> 
> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---

Applied to clk-next

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ipq806x: gcc: Added the enable regs and mask for PRNG
  2020-03-18 13:16 [PATCH v2] ipq806x: gcc: Added the enable regs and mask for PRNG Ansuel Smith
  2020-03-20 23:28 ` Stephen Boyd
@ 2020-03-20 23:29 ` Stephen Boyd
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-03-20 23:29 UTC (permalink / raw)
  To: Andy Gross, Ansuel Smith
  Cc: Abhishek Sahu, Ansuel Smith, Bjorn Andersson, Michael Turquette,
	Kumar Gala, linux-arm-msm, linux-clk, linux-kernel

Quoting Ansuel Smith (2020-03-18 06:16:56)
> From: Abhishek Sahu <absahu@codeaurora.org>
> 
> Kernel got hanged while reading from /dev/hwrng at the
> time of PRNG clock enable
> 
> Fixes: 24d8fba44af3 "clk: qcom: Add support for IPQ8064's global
> clock controller (GCC)"

BTW, this should be on one line. Please fix it next time.

> 
> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-20 23:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-18 13:16 [PATCH v2] ipq806x: gcc: Added the enable regs and mask for PRNG Ansuel Smith
2020-03-20 23:28 ` Stephen Boyd
2020-03-20 23:29 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).