Re: clk: clk_register is deprecated

[Stephen Boyd <sboyd@kernel.org>]

Quoting Jerome Brunet (2020-05-05 09:03:21)
> 
> On Mon 04 May 2020 at 19:16, Stephen Boyd <sboyd@kernel.org> wrote:
> 
> > Quoting Jerome Brunet (2020-04-30 05:24:41)
> >> 
> >> If not, what would be the recommended way to get the "struct clk*" from
> >> a newly registered "struct clk_hw *" ? Should we add something new to
> >> clk-provider.h API ?
> >> 
> >
> > Yes we should add a clk_hw_get_clk() API that takes a device pointer and
> > a string name, mirroring the clk_get() API but cutting out the part
> > where we have to go through the provider to find it.
> 
> We will try to propose something for clk_hw_get_clk() soon.
> If we do so, could we "UN-deprecate" clk_register() and make it a
> wrapper around clk_hw_register() and clk_hw_get_clk() ?
> 
> It would make it easier on drivers which both register and use clocks.
> 
> To get a short term solution for Martin and his MMC driver:
> -  If the above wrapper is OK and we commit on doing it soon, would you
>    also be OK for martin to use clk_register() in his MMC driver (now) ?
> 
> -  If not, could we use clk_hw->clk until  we have clk_hw_get_clk() in
>    CCF ?

Using clk_hw->clk until we have clk_hw_get_clk() is fine for now.
Various drivers do that already and I hope that a simple coccinelle
script can figure out how to convert that to the new function.l Is it
much work to introduce this API now? I thought it would be fairly simple
to do it but I haven't looked deeply.

> 
> >
> > This is so that one day in "the future" we can remove hw->clk and make
> > that an internal detail that struct clk_hw can't see because we go
> > through the clk_hw::clk_core pointer instead.
> 
> Yes, I know it is your secret plan ... ;)
> 
> 

Hehe