From: Jerome Brunet <jbrunet@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
ulf.hansson@linaro.org
Cc: linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: clk: clk_register is deprecated
Date: Tue, 05 May 2020 18:03:21 +0200 [thread overview]
Message-ID: <1j368egyie.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <158861256065.11125.3262677295691476922@swboyd.mtv.corp.google.com>
On Mon 04 May 2020 at 19:16, Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Jerome Brunet (2020-04-30 05:24:41)
>> Hi Stephen,
>>
>> We have a question regarding drivers which register clocks in CCF and
>> later need to use these clocks.
>>
>> So far, these drivers had been using clk_register() to get a 'struct
>> clk*' they could later use with the linux/clk.h API.
>>
>> Now that this clk_register() is deprecated in favor of
>> clk_hw_register(), how are these driver supposed to get the per-user
>> "struct clk*" they need ?
>>
>> In this mmc thread [0] Martin proposed to go through a provider. I think
>> it is overkill, especially for a device which will not provide its clocks
>> to any other device.
>>
>> They other way available is "hw->clk". I suspect it is not recommended
>> to do so, is it ?
>>
>> If not, what would be the recommended way to get the "struct clk*" from
>> a newly registered "struct clk_hw *" ? Should we add something new to
>> clk-provider.h API ?
>>
>
> Yes we should add a clk_hw_get_clk() API that takes a device pointer and
> a string name, mirroring the clk_get() API but cutting out the part
> where we have to go through the provider to find it.
We will try to propose something for clk_hw_get_clk() soon.
If we do so, could we "UN-deprecate" clk_register() and make it a
wrapper around clk_hw_register() and clk_hw_get_clk() ?
It would make it easier on drivers which both register and use clocks.
To get a short term solution for Martin and his MMC driver:
- If the above wrapper is OK and we commit on doing it soon, would you
also be OK for martin to use clk_register() in his MMC driver (now) ?
- If not, could we use clk_hw->clk until we have clk_hw_get_clk() in
CCF ?
>
> This is so that one day in "the future" we can remove hw->clk and make
> that an internal detail that struct clk_hw can't see because we go
> through the clk_hw::clk_core pointer instead.
Yes, I know it is your secret plan ... ;)
next prev parent reply other threads:[~2020-05-05 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 12:24 clk: clk_register is deprecated Jerome Brunet
2020-05-04 17:16 ` Stephen Boyd
2020-05-05 16:03 ` Jerome Brunet [this message]
2020-05-05 19:10 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1j368egyie.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).