* [v2 PATCH 0/4] Add SMD RPM support for MSM8936
@ 2020-05-01 22:32 Konrad Dybcio
2020-05-01 22:32 ` [PATCH 1/4] clk: qcom: smd: Add support for MSM8936 rpm clocks Konrad Dybcio
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Konrad Dybcio @ 2020-05-01 22:32 UTC (permalink / raw)
Cc: Konrad Dybcio, Andy Gross, Bjorn Andersson, Michael Turquette,
Stephen Boyd, Rob Herring, linux-arm-msm, linux-clk, devicetree,
linux-kernel
changes since v1:
- added a forgotten patch that adds the compat string to the driver
Konrad Dybcio (1):
drivers: soc: Add MSM8936 SMD RPM compatible
Vincent Knecht (3):
clk: qcom: smd: Add support for MSM8936 rpm clocks
dt-bindings: clock: rpmcc: Document MSM8936 compatible
dt-bindings: soc: qcom: Document MSM8936 SMD RPM compatible
.../devicetree/bindings/clock/qcom,rpmcc.txt | 1 +
.../bindings/soc/qcom/qcom,smd-rpm.txt | 1 +
drivers/clk/qcom/clk-smd-rpm.c | 50 +++++++++++++++++++
drivers/soc/qcom/smd-rpm.c | 1 +
4 files changed, 53 insertions(+)
--
2.26.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/4] clk: qcom: smd: Add support for MSM8936 rpm clocks
2020-05-01 22:32 [v2 PATCH 0/4] Add SMD RPM support for MSM8936 Konrad Dybcio
@ 2020-05-01 22:32 ` Konrad Dybcio
2020-05-01 22:32 ` [PATCH 2/4] dt-bindings: clock: rpmcc: Document MSM8936 compatible Konrad Dybcio
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2020-05-01 22:32 UTC (permalink / raw)
Cc: Konrad Dybcio, Andy Gross, Bjorn Andersson, Michael Turquette,
Stephen Boyd, Rob Herring, linux-arm-msm, linux-clk, devicetree,
linux-kernel, Vincent Knecht
From: Vincent Knecht <vincent.knecht@mailoo.org>
Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
---
drivers/clk/qcom/clk-smd-rpm.c | 50 ++++++++++++++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
index 52f63ad787ba9..4ac80d8ac6c25 100644
--- a/drivers/clk/qcom/clk-smd-rpm.c
+++ b/drivers/clk/qcom/clk-smd-rpm.c
@@ -452,6 +452,55 @@ static const struct rpm_smd_clk_desc rpm_clk_msm8916 = {
.num_clks = ARRAY_SIZE(msm8916_clks),
};
+/* msm8936 */
+DEFINE_CLK_SMD_RPM(msm8936, pcnoc_clk, pcnoc_a_clk, QCOM_SMD_RPM_BUS_CLK, 0);
+DEFINE_CLK_SMD_RPM(msm8936, snoc_clk, snoc_a_clk, QCOM_SMD_RPM_BUS_CLK, 1);
+DEFINE_CLK_SMD_RPM(msm8936, bimc_clk, bimc_a_clk, QCOM_SMD_RPM_MEM_CLK, 0);
+DEFINE_CLK_SMD_RPM(msm8936, sysmmnoc_clk, sysmmnoc_a_clk, QCOM_SMD_RPM_BUS_CLK, 2);
+DEFINE_CLK_SMD_RPM_QDSS(msm8936, qdss_clk, qdss_a_clk, QCOM_SMD_RPM_MISC_CLK, 1);
+DEFINE_CLK_SMD_RPM_XO_BUFFER(msm8936, bb_clk1, bb_clk1_a, 1);
+DEFINE_CLK_SMD_RPM_XO_BUFFER(msm8936, bb_clk2, bb_clk2_a, 2);
+DEFINE_CLK_SMD_RPM_XO_BUFFER(msm8936, rf_clk1, rf_clk1_a, 4);
+DEFINE_CLK_SMD_RPM_XO_BUFFER(msm8936, rf_clk2, rf_clk2_a, 5);
+DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(msm8936, bb_clk1_pin, bb_clk1_a_pin, 1);
+DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(msm8936, bb_clk2_pin, bb_clk2_a_pin, 2);
+DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(msm8936, rf_clk1_pin, rf_clk1_a_pin, 4);
+DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(msm8936, rf_clk2_pin, rf_clk2_a_pin, 5);
+
+static struct clk_smd_rpm *msm8936_clks[] = {
+ [RPM_SMD_PCNOC_CLK] = &msm8936_pcnoc_clk,
+ [RPM_SMD_PCNOC_A_CLK] = &msm8936_pcnoc_a_clk,
+ [RPM_SMD_SNOC_CLK] = &msm8936_snoc_clk,
+ [RPM_SMD_SNOC_A_CLK] = &msm8936_snoc_a_clk,
+ [RPM_SMD_BIMC_CLK] = &msm8936_bimc_clk,
+ [RPM_SMD_BIMC_A_CLK] = &msm8936_bimc_a_clk,
+ [RPM_SMD_SYSMMNOC_CLK] = &msm8936_sysmmnoc_clk,
+ [RPM_SMD_SYSMMNOC_A_CLK] = &msm8936_sysmmnoc_a_clk,
+ [RPM_SMD_QDSS_CLK] = &msm8936_qdss_clk,
+ [RPM_SMD_QDSS_A_CLK] = &msm8936_qdss_a_clk,
+ [RPM_SMD_BB_CLK1] = &msm8936_bb_clk1,
+ [RPM_SMD_BB_CLK1_A] = &msm8936_bb_clk1_a,
+ [RPM_SMD_BB_CLK2] = &msm8936_bb_clk2,
+ [RPM_SMD_BB_CLK2_A] = &msm8936_bb_clk2_a,
+ [RPM_SMD_RF_CLK1] = &msm8936_rf_clk1,
+ [RPM_SMD_RF_CLK1_A] = &msm8936_rf_clk1_a,
+ [RPM_SMD_RF_CLK2] = &msm8936_rf_clk2,
+ [RPM_SMD_RF_CLK2_A] = &msm8936_rf_clk2_a,
+ [RPM_SMD_BB_CLK1_PIN] = &msm8936_bb_clk1_pin,
+ [RPM_SMD_BB_CLK1_A_PIN] = &msm8936_bb_clk1_a_pin,
+ [RPM_SMD_BB_CLK2_PIN] = &msm8936_bb_clk2_pin,
+ [RPM_SMD_BB_CLK2_A_PIN] = &msm8936_bb_clk2_a_pin,
+ [RPM_SMD_RF_CLK1_PIN] = &msm8936_rf_clk1_pin,
+ [RPM_SMD_RF_CLK1_A_PIN] = &msm8936_rf_clk1_a_pin,
+ [RPM_SMD_RF_CLK2_PIN] = &msm8936_rf_clk2_pin,
+ [RPM_SMD_RF_CLK2_A_PIN] = &msm8936_rf_clk2_a_pin,
+};
+
+static const struct rpm_smd_clk_desc rpm_clk_msm8936 = {
+ .clks = msm8936_clks,
+ .num_clks = ARRAY_SIZE(msm8936_clks),
+};
+
/* msm8974 */
DEFINE_CLK_SMD_RPM(msm8974, pnoc_clk, pnoc_a_clk, QCOM_SMD_RPM_BUS_CLK, 0);
DEFINE_CLK_SMD_RPM(msm8974, snoc_clk, snoc_a_clk, QCOM_SMD_RPM_BUS_CLK, 1);
@@ -768,6 +817,7 @@ static const struct rpm_smd_clk_desc rpm_clk_msm8998 = {
static const struct of_device_id rpm_smd_clk_match_table[] = {
{ .compatible = "qcom,rpmcc-msm8916", .data = &rpm_clk_msm8916 },
+ { .compatible = "qcom,rpmcc-msm8936", .data = &rpm_clk_msm8936 },
{ .compatible = "qcom,rpmcc-msm8974", .data = &rpm_clk_msm8974 },
{ .compatible = "qcom,rpmcc-msm8976", .data = &rpm_clk_msm8976 },
{ .compatible = "qcom,rpmcc-msm8996", .data = &rpm_clk_msm8996 },
--
2.26.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/4] dt-bindings: clock: rpmcc: Document MSM8936 compatible
2020-05-01 22:32 [v2 PATCH 0/4] Add SMD RPM support for MSM8936 Konrad Dybcio
2020-05-01 22:32 ` [PATCH 1/4] clk: qcom: smd: Add support for MSM8936 rpm clocks Konrad Dybcio
@ 2020-05-01 22:32 ` Konrad Dybcio
2020-05-12 21:04 ` Rob Herring
2020-05-01 22:32 ` [PATCH 3/4] drivers: soc: Add MSM8936 SMD RPM compatible Konrad Dybcio
2020-05-01 22:32 ` [PATCH 4/4] dt-bindings: soc: qcom: Document " Konrad Dybcio
3 siblings, 1 reply; 9+ messages in thread
From: Konrad Dybcio @ 2020-05-01 22:32 UTC (permalink / raw)
Cc: Konrad Dybcio, Andy Gross, Bjorn Andersson, Michael Turquette,
Stephen Boyd, Rob Herring, linux-arm-msm, linux-clk, devicetree,
linux-kernel, Vincent Knecht
From: Vincent Knecht <vincent.knecht@mailoo.org>
Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
---
Documentation/devicetree/bindings/clock/qcom,rpmcc.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
index 90a1349bc7135..51d1ef62c7450 100644
--- a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
+++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
@@ -13,6 +13,7 @@ Required properties :
"qcom,rpmcc-msm8660", "qcom,rpmcc"
"qcom,rpmcc-apq8060", "qcom,rpmcc"
"qcom,rpmcc-msm8916", "qcom,rpmcc"
+ "qcom,rpmcc-msm8936", "qcom,rpmcc"
"qcom,rpmcc-msm8974", "qcom,rpmcc"
"qcom,rpmcc-msm8976", "qcom,rpmcc"
"qcom,rpmcc-apq8064", "qcom,rpmcc"
--
2.26.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/4] drivers: soc: Add MSM8936 SMD RPM compatible
2020-05-01 22:32 [v2 PATCH 0/4] Add SMD RPM support for MSM8936 Konrad Dybcio
2020-05-01 22:32 ` [PATCH 1/4] clk: qcom: smd: Add support for MSM8936 rpm clocks Konrad Dybcio
2020-05-01 22:32 ` [PATCH 2/4] dt-bindings: clock: rpmcc: Document MSM8936 compatible Konrad Dybcio
@ 2020-05-01 22:32 ` Konrad Dybcio
2020-05-01 22:32 ` [PATCH 4/4] dt-bindings: soc: qcom: Document " Konrad Dybcio
3 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2020-05-01 22:32 UTC (permalink / raw)
Cc: Konrad Dybcio, Andy Gross, Bjorn Andersson, Michael Turquette,
Stephen Boyd, Rob Herring, linux-arm-msm, linux-clk, devicetree,
linux-kernel
Signed-off-by: Konrad Dybcio <konradybcio@gmail.com>
---
drivers/soc/qcom/smd-rpm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c
index 005dd30c58faf..8f290c67cb473 100644
--- a/drivers/soc/qcom/smd-rpm.c
+++ b/drivers/soc/qcom/smd-rpm.c
@@ -231,6 +231,7 @@ static void qcom_smd_rpm_remove(struct rpmsg_device *rpdev)
static const struct of_device_id qcom_smd_rpm_of_match[] = {
{ .compatible = "qcom,rpm-apq8084" },
{ .compatible = "qcom,rpm-msm8916" },
+ { .compatible = "qcom,rpm-msm8936" },
{ .compatible = "qcom,rpm-msm8974" },
{ .compatible = "qcom,rpm-msm8976" },
{ .compatible = "qcom,rpm-msm8996" },
--
2.26.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 4/4] dt-bindings: soc: qcom: Document MSM8936 SMD RPM compatible
2020-05-01 22:32 [v2 PATCH 0/4] Add SMD RPM support for MSM8936 Konrad Dybcio
` (2 preceding siblings ...)
2020-05-01 22:32 ` [PATCH 3/4] drivers: soc: Add MSM8936 SMD RPM compatible Konrad Dybcio
@ 2020-05-01 22:32 ` Konrad Dybcio
2020-05-12 22:45 ` Rob Herring
3 siblings, 1 reply; 9+ messages in thread
From: Konrad Dybcio @ 2020-05-01 22:32 UTC (permalink / raw)
Cc: Konrad Dybcio, Andy Gross, Bjorn Andersson, Michael Turquette,
Stephen Boyd, Rob Herring, linux-arm-msm, linux-clk, devicetree,
linux-kernel, Vincent Knecht
From: Vincent Knecht <vincent.knecht@mailoo.org>
Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
---
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt
index 616fddcd09fd8..55f8abd845a7e 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt
@@ -21,6 +21,7 @@ resources.
Definition: must be one of:
"qcom,rpm-apq8084"
"qcom,rpm-msm8916"
+ "qcom,rpm-msm8936"
"qcom,rpm-msm8974"
"qcom,rpm-msm8976"
"qcom,rpm-msm8998"
--
2.26.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/4] dt-bindings: clock: rpmcc: Document MSM8936 compatible
2020-05-01 22:32 ` [PATCH 2/4] dt-bindings: clock: rpmcc: Document MSM8936 compatible Konrad Dybcio
@ 2020-05-12 21:04 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2020-05-12 21:04 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Vincent Knecht, Michael Turquette, devicetree, Andy Gross,
linux-kernel, Bjorn Andersson, linux-arm-msm, Rob Herring,
linux-clk, Stephen Boyd
On Sat, 2 May 2020 00:32:30 +0200, Konrad Dybcio wrote:
> From: Vincent Knecht <vincent.knecht@mailoo.org>
>
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> ---
> Documentation/devicetree/bindings/clock/qcom,rpmcc.txt | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4] dt-bindings: soc: qcom: Document MSM8936 SMD RPM compatible
2020-05-01 22:32 ` [PATCH 4/4] dt-bindings: soc: qcom: Document " Konrad Dybcio
@ 2020-05-12 22:45 ` Rob Herring
2020-05-27 3:03 ` Stephen Boyd
0 siblings, 1 reply; 9+ messages in thread
From: Rob Herring @ 2020-05-12 22:45 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Michael Turquette, linux-kernel, Vincent Knecht, Andy Gross,
linux-clk, linux-arm-msm, Bjorn Andersson, devicetree,
Stephen Boyd, Rob Herring
On Sat, 2 May 2020 00:32:32 +0200, Konrad Dybcio wrote:
> From: Vincent Knecht <vincent.knecht@mailoo.org>
>
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> ---
> Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4] dt-bindings: soc: qcom: Document MSM8936 SMD RPM compatible
2020-05-12 22:45 ` Rob Herring
@ 2020-05-27 3:03 ` Stephen Boyd
2020-05-27 3:06 ` Stephen Boyd
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Boyd @ 2020-05-27 3:03 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring
Cc: Michael Turquette, linux-kernel, Vincent Knecht, Andy Gross,
linux-clk, linux-arm-msm, Bjorn Andersson, devicetree,
Rob Herring
Quoting Rob Herring (2020-05-12 15:45:22)
> On Sat, 2 May 2020 00:32:32 +0200, Konrad Dybcio wrote:
> > From: Vincent Knecht <vincent.knecht@mailoo.org>
> >
> > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> > ---
> > Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> Acked-by: Rob Herring <robh@kernel.org>
I picked these ones up actually, not the other ones, but my MUA totally
failed to open anything because the patches weren't sent To: anyone. O
well!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4] dt-bindings: soc: qcom: Document MSM8936 SMD RPM compatible
2020-05-27 3:03 ` Stephen Boyd
@ 2020-05-27 3:06 ` Stephen Boyd
0 siblings, 0 replies; 9+ messages in thread
From: Stephen Boyd @ 2020-05-27 3:06 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring
Cc: Michael Turquette, linux-kernel, Vincent Knecht, Andy Gross,
linux-clk, linux-arm-msm, Bjorn Andersson, devicetree,
Rob Herring
Quoting Stephen Boyd (2020-05-26 20:03:42)
> Quoting Rob Herring (2020-05-12 15:45:22)
> > On Sat, 2 May 2020 00:32:32 +0200, Konrad Dybcio wrote:
> > > From: Vincent Knecht <vincent.knecht@mailoo.org>
> > >
> > > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> > > ---
> > > Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> >
> > Acked-by: Rob Herring <robh@kernel.org>
>
> I picked these ones up actually, not the other ones, but my MUA totally
> failed to open anything because the patches weren't sent To: anyone. O
> well!
Oh and now I've dropped them because:
drivers/clk/qcom/clk-smd-rpm.c:478:4: error: ‘RPM_SMD_SYSMMNOC_A_CLK’ undeclared here (not in a function); did you mean ‘RPM_SMD_SNOC_A_CLK’?
478 | [RPM_SMD_SYSMMNOC_A_CLK] = &msm8936_sysmmnoc_a_clk,
| ^~~~~~~~~~~~~~~~~~~~~~
| RPM_SMD_SNOC_A_CLK
So please fix that and resend with proper To.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-05-27 3:06 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-01 22:32 [v2 PATCH 0/4] Add SMD RPM support for MSM8936 Konrad Dybcio
2020-05-01 22:32 ` [PATCH 1/4] clk: qcom: smd: Add support for MSM8936 rpm clocks Konrad Dybcio
2020-05-01 22:32 ` [PATCH 2/4] dt-bindings: clock: rpmcc: Document MSM8936 compatible Konrad Dybcio
2020-05-12 21:04 ` Rob Herring
2020-05-01 22:32 ` [PATCH 3/4] drivers: soc: Add MSM8936 SMD RPM compatible Konrad Dybcio
2020-05-01 22:32 ` [PATCH 4/4] dt-bindings: soc: qcom: Document " Konrad Dybcio
2020-05-12 22:45 ` Rob Herring
2020-05-27 3:03 ` Stephen Boyd
2020-05-27 3:06 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).