linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>,
	Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: linux- stable <stable@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	freedreno <freedreno@lists.freedesktop.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>,
	lkft-triage@lists.linaro.org,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Clark <robdclark@chromium.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Jordan Crouse <jcrouse@codeaurora.org>,
	Eric Anholt <eric@anholt.net>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	samuel@sholland.org
Subject: Re: stable-rc 4.14: arm64: Internal error: Oops: clk_reparent __clk_set_parent_before on db410c
Date: Thu, 23 Jul 2020 01:06:37 -0700	[thread overview]
Message-ID: <159549159798.3847286.18202724980881020289@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <CAK8P3a1ReCDR8REM7AWMisiEJ_D45pC8dXaoYFFVG3aZj91e7Q@mail.gmail.com>

Quoting Arnd Bergmann (2020-07-21 02:51:32)
>                         __clk_set_parent_before(orphan, parent);
> 
> None of the above have changed in stable kernels.
> 
> > [    5.633668]  pll_28nm_register+0xa4/0x340 [msm]
> > [    5.637492]  msm_dsi_pll_28nm_init+0xc8/0x1d8 [msm]
> > [    5.642007]  msm_dsi_pll_init+0x34/0xe0 [msm]
> > [    5.646870]  dsi_phy_driver_probe+0x1cc/0x310 [msm]
> 
> The only changes to the dsi driver in v4.14-stable were:
> 
> 89e30bb46074 drm/msm/dsi: save pll state before dsi host is powered off
> 892afde0f4a1 drm: msm: Fix return type of dsi_mgr_connector_mode_valid for kCFI
> 35ff594b0da2 drm/msm/dsi: Implement reset correctly
> 5151a0c8d730 drm/msm/dsi: use correct enum in dsi_get_cmd_fmt
> e6bc3a4b0c23 clk: divider: fix incorrect usage of container_of
> 
> None of these look suspicious to me.
> 

It sounds like maybe you need this patch?

bdcf1dc25324 ("clk: Evict unregistered clks from parent caches")

or 

4368a1539c6b ("drm/msm: Depopulate platform on probe failure")

I vaguelly recall that the display driver wasn't removing clks becaues
it wasn't removing devices when probe defer happened and then we had
dangling clks in the parent cache confusing things.

  reply	other threads:[~2020-07-23  8:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21  8:32 stable-rc 4.14: arm64: Internal error: Oops: clk_reparent __clk_set_parent_before on db410c Naresh Kamboju
2020-07-21  9:51 ` Arnd Bergmann
2020-07-23  8:06   ` Stephen Boyd [this message]
2020-07-23 10:10     ` Naresh Kamboju
2020-07-23 10:26       ` Stephen Boyd
2020-08-12 17:44         ` Stephen Boyd
2020-08-13 14:00           ` Naresh Kamboju
2020-08-24  8:18             ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159549159798.3847286.18202724980881020289@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=agross@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@linaro.org \
    --cc=eric@anholt.net \
    --cc=freedreno@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jcrouse@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkft-triage@lists.linaro.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=naresh.kamboju@linaro.org \
    --cc=robdclark@chromium.org \
    --cc=robin.murphy@arm.com \
    --cc=samuel@sholland.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).