* [PATCH] clk: Export clk_register_composite() for mediatek's clock kernel module @ 2020-07-01 7:26 Wendell Lin 2020-07-01 7:26 ` [PATCH 1/2] clk: Export clk_register_composite Wendell Lin 2020-07-01 7:26 ` [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support Wendell Lin 0 siblings, 2 replies; 7+ messages in thread From: Wendell Lin @ 2020-07-01 7:26 UTC (permalink / raw) To: Matthias Brugger, Michael Turquette, Stephen Boyd, Weiyi Lu, mtk01761 Cc: linux-clk, linux-kernel, linux-arm-kernel, linux-mediatek, wsd_upstream This series based on 5.8-rc1 This patch exports clk_register_composite() and common APIs from Mediatek clock driver. clk_register_composite() will be used in mediatek's clock kernel module, so export it to GPL modules. Wendell Lin (2): clk: Export clk_register_composite clk: mediatek: Add EXPORT_SYMBOL for kernel module support drivers/clk/clk-composite.c | 1 + drivers/clk/mediatek/clk-mtk.c | 13 +++++++++++++ 2 files changed, 14 insertions(+) ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] clk: Export clk_register_composite 2020-07-01 7:26 [PATCH] clk: Export clk_register_composite() for mediatek's clock kernel module Wendell Lin @ 2020-07-01 7:26 ` Wendell Lin 2020-07-11 0:26 ` Stephen Boyd 2020-07-01 7:26 ` [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support Wendell Lin 1 sibling, 1 reply; 7+ messages in thread From: Wendell Lin @ 2020-07-01 7:26 UTC (permalink / raw) To: Matthias Brugger, Michael Turquette, Stephen Boyd, Weiyi Lu, mtk01761 Cc: linux-clk, linux-kernel, linux-arm-kernel, linux-mediatek, wsd_upstream clk_register_composite() will be used in mediatek's clock kernel module, so export it to GPL modules. Signed-off-by: Wendell Lin <wendell.lin@mediatek.com> --- drivers/clk/clk-composite.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c index 7376f57..fb5cb4a 100644 --- a/drivers/clk/clk-composite.c +++ b/drivers/clk/clk-composite.c @@ -360,6 +360,7 @@ struct clk *clk_register_composite(struct device *dev, const char *name, return ERR_CAST(hw); return hw->clk; } +EXPORT_SYMBOL(clk_register_composite); struct clk *clk_register_composite_pdata(struct device *dev, const char *name, const struct clk_parent_data *parent_data, -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] clk: Export clk_register_composite 2020-07-01 7:26 ` [PATCH 1/2] clk: Export clk_register_composite Wendell Lin @ 2020-07-11 0:26 ` Stephen Boyd 2020-07-23 8:08 ` Wendell Lin 0 siblings, 1 reply; 7+ messages in thread From: Stephen Boyd @ 2020-07-11 0:26 UTC (permalink / raw) To: Matthias Brugger, Michael Turquette, Weiyi Lu, mtk01761 Cc: linux-clk, linux-kernel, linux-arm-kernel, linux-mediatek, wsd_upstream Quoting Wendell Lin (2020-07-01 00:26:21) > clk_register_composite() will be used in mediatek's > clock kernel module, so export it to GPL modules. > > Signed-off-by: Wendell Lin <wendell.lin@mediatek.com> > --- > drivers/clk/clk-composite.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c > index 7376f57..fb5cb4a 100644 > --- a/drivers/clk/clk-composite.c > +++ b/drivers/clk/clk-composite.c > @@ -360,6 +360,7 @@ struct clk *clk_register_composite(struct device *dev, const char *name, > return ERR_CAST(hw); > return hw->clk; > } > +EXPORT_SYMBOL(clk_register_composite); Should be EXPORT_SYMBOL_GPL() ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] clk: Export clk_register_composite 2020-07-11 0:26 ` Stephen Boyd @ 2020-07-23 8:08 ` Wendell Lin 0 siblings, 0 replies; 7+ messages in thread From: Wendell Lin @ 2020-07-23 8:08 UTC (permalink / raw) To: Stephen Boyd Cc: Matthias Brugger, Michael Turquette, Weiyi Lu, linux-clk, linux-kernel, linux-arm-kernel, linux-mediatek, wsd_upstream On Fri, 2020-07-10 at 17:26 -0700, Stephen Boyd wrote: > Quoting Wendell Lin (2020-07-01 00:26:21) > > clk_register_composite() will be used in mediatek's > > clock kernel module, so export it to GPL modules. > > > > Signed-off-by: Wendell Lin <wendell.lin@mediatek.com> > > --- > > drivers/clk/clk-composite.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c > > index 7376f57..fb5cb4a 100644 > > --- a/drivers/clk/clk-composite.c > > +++ b/drivers/clk/clk-composite.c > > @@ -360,6 +360,7 @@ struct clk *clk_register_composite(struct device *dev, const char *name, > > return ERR_CAST(hw); > > return hw->clk; > > } > > +EXPORT_SYMBOL(clk_register_composite); > > Should be EXPORT_SYMBOL_GPL() Got it, I'll fix it. Regards, Wendell ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support 2020-07-01 7:26 [PATCH] clk: Export clk_register_composite() for mediatek's clock kernel module Wendell Lin 2020-07-01 7:26 ` [PATCH 1/2] clk: Export clk_register_composite Wendell Lin @ 2020-07-01 7:26 ` Wendell Lin 2020-07-11 16:26 ` Stephen Boyd 1 sibling, 1 reply; 7+ messages in thread From: Wendell Lin @ 2020-07-01 7:26 UTC (permalink / raw) To: Matthias Brugger, Michael Turquette, Stephen Boyd, Weiyi Lu, mtk01761 Cc: linux-clk, linux-kernel, linux-arm-kernel, linux-mediatek, wsd_upstream Export common APIs from Mediatek clock driver. Signed-off-by: Wendell Lin <wendell.lin@mediatek.com> --- drivers/clk/mediatek/clk-mtk.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c index cec1c8a..6b4dca1 100644 --- a/drivers/clk/mediatek/clk-mtk.c +++ b/drivers/clk/mediatek/clk-mtk.c @@ -13,6 +13,7 @@ #include <linux/clkdev.h> #include <linux/mfd/syscon.h> #include <linux/device.h> +#include <linux/module.h> #include "clk-mtk.h" #include "clk-gate.h" @@ -41,6 +42,7 @@ struct clk_onecell_data *mtk_alloc_clk_data(unsigned int clk_num) return NULL; } +EXPORT_SYMBOL(mtk_alloc_clk_data); void mtk_clk_register_fixed_clks(const struct mtk_fixed_clk *clks, int num, struct clk_onecell_data *clk_data) @@ -67,6 +69,7 @@ void mtk_clk_register_fixed_clks(const struct mtk_fixed_clk *clks, clk_data->clks[rc->id] = clk; } } +EXPORT_SYMBOL(mtk_clk_register_fixed_clks); void mtk_clk_register_factors(const struct mtk_fixed_factor *clks, int num, struct clk_onecell_data *clk_data) @@ -93,6 +96,7 @@ void mtk_clk_register_factors(const struct mtk_fixed_factor *clks, clk_data->clks[ff->id] = clk; } } +EXPORT_SYMBOL(mtk_clk_register_factors); int mtk_clk_register_gates_with_dev(struct device_node *node, const struct mtk_gate *clks, @@ -137,6 +141,7 @@ int mtk_clk_register_gates_with_dev(struct device_node *node, return 0; } +EXPORT_SYMBOL(mtk_clk_register_gates_with_dev); int mtk_clk_register_gates(struct device_node *node, const struct mtk_gate *clks, @@ -145,6 +150,7 @@ int mtk_clk_register_gates(struct device_node *node, return mtk_clk_register_gates_with_dev(node, clks, num, clk_data, NULL); } +EXPORT_SYMBOL(mtk_clk_register_gates); struct clk *mtk_clk_register_composite(const struct mtk_composite *mc, void __iomem *base, spinlock_t *lock) @@ -232,6 +238,7 @@ struct clk *mtk_clk_register_composite(const struct mtk_composite *mc, return ERR_PTR(ret); } +EXPORT_SYMBOL(mtk_clk_register_composite); void mtk_clk_register_composites(const struct mtk_composite *mcs, int num, void __iomem *base, spinlock_t *lock, @@ -258,6 +265,7 @@ void mtk_clk_register_composites(const struct mtk_composite *mcs, clk_data->clks[mc->id] = clk; } } +EXPORT_SYMBOL(mtk_clk_register_composites); void mtk_clk_register_dividers(const struct mtk_clk_divider *mcds, int num, void __iomem *base, spinlock_t *lock, @@ -286,3 +294,8 @@ void mtk_clk_register_dividers(const struct mtk_clk_divider *mcds, clk_data->clks[mcd->id] = clk; } } +EXPORT_SYMBOL(mtk_clk_register_dividers); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("Mediatek Clocks"); +MODULE_AUTHOR("MediaTek Inc."); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support 2020-07-01 7:26 ` [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support Wendell Lin @ 2020-07-11 16:26 ` Stephen Boyd 2020-07-23 8:09 ` Wendell Lin 0 siblings, 1 reply; 7+ messages in thread From: Stephen Boyd @ 2020-07-11 16:26 UTC (permalink / raw) To: Matthias Brugger, Michael Turquette, Weiyi Lu, mtk01761 Cc: linux-clk, linux-kernel, linux-arm-kernel, linux-mediatek, wsd_upstream Quoting Wendell Lin (2020-07-01 00:26:22) > Export common APIs from Mediatek clock driver. > > Signed-off-by: Wendell Lin <wendell.lin@mediatek.com> Is this needed for something? I'd prefer to see some sort of mediatek modular patches that included this patch in it before this is applied. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support 2020-07-11 16:26 ` Stephen Boyd @ 2020-07-23 8:09 ` Wendell Lin 0 siblings, 0 replies; 7+ messages in thread From: Wendell Lin @ 2020-07-23 8:09 UTC (permalink / raw) To: Stephen Boyd Cc: Matthias Brugger, Michael Turquette, Weiyi Lu, linux-clk, linux-kernel, linux-arm-kernel, linux-mediatek, wsd_upstream On Sat, 2020-07-11 at 09:26 -0700, Stephen Boyd wrote: > Quoting Wendell Lin (2020-07-01 00:26:22) > > Export common APIs from Mediatek clock driver. > > > > Signed-off-by: Wendell Lin <wendell.lin@mediatek.com> > > Is this needed for something? I'd prefer to see some sort of mediatek > modular patches that included this patch in it before this is applied. Got it. I'll prepare a new series of mediatek modular patches that included this patch in it later. Regards, Wendell ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-07-23 8:09 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-01 7:26 [PATCH] clk: Export clk_register_composite() for mediatek's clock kernel module Wendell Lin 2020-07-01 7:26 ` [PATCH 1/2] clk: Export clk_register_composite Wendell Lin 2020-07-11 0:26 ` Stephen Boyd 2020-07-23 8:08 ` Wendell Lin 2020-07-01 7:26 ` [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support Wendell Lin 2020-07-11 16:26 ` Stephen Boyd 2020-07-23 8:09 ` Wendell Lin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).