From: Stephen Boyd <sboyd@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>,
Mike Turquette <mturquette@baylibre.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: linux-rpi-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com, linux-clk@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Maxime Ripard <maxime@cerno.tech>
Subject: Re: [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding
Date: Thu, 23 Jul 2020 15:45:48 -0700 [thread overview]
Message-ID: <159554434893.3847286.8491922177659230646@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200626115433.125735-1-maxime@cerno.tech>
Quoting Maxime Ripard (2020-06-26 04:54:33)
> The RaspberryPi firmware binding uses two compatible, include simple-bus.
> The select statement generated by default will thus select any node that
> has simple-bus, not all of them being the raspberrypi firmware node.
>
> This results in warnings being wrongfully reported. Let's add a custom
> select statement to fix that.
>
> Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> ---
>
> The original binding has been merged through the clock tree, so it should
> be merged there.
>
> Even though the original binding (and the DT) are using the simple-bus
> compatible, this creates some DTC warnings since the firmware really isn't
> a bus, so the node name doesn't match what a bus should have, none of the
> children have a reg property, #address-cells and #size-cells are missing,
> etc.
>
> I can only guess that simple-bus was used to make the sub-devices probe,
> but maybe simple-mfd would be more appropriate here?
> ---
> .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
Hmm. I'm still seeing warnings.
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dts:23.37-26.15: Warning (simple_bus_reg): /example-0/firmware/clocks: missing or emp
ty reg/ranges property
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: $nodename:0: 'firmware' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#address-cells' is a required property
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#size-cells' is a required property
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: 'ranges' is a required property
next prev parent reply other threads:[~2020-07-23 22:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 11:54 [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding Maxime Ripard
2020-06-26 16:03 ` Florian Fainelli
2020-07-15 20:06 ` Rob Herring
2020-07-23 15:44 ` Maxime Ripard
2020-07-23 20:04 ` Rob Herring
2020-07-23 22:02 ` Stephen Boyd
2020-07-23 22:33 ` Stephen Boyd
2020-07-23 22:45 ` Stephen Boyd [this message]
2020-07-27 15:52 ` Maxime Ripard
2020-07-27 19:39 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159554434893.3847286.8491922177659230646@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=mturquette@baylibre.com \
--cc=nsaenzjulienne@suse.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).