* [PATCH] clk: qcom: mmcc-msm8974: Fix mmss_s0_axi clock
@ 2020-12-26 14:09 Konrad Dybcio
2021-01-12 19:57 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Konrad Dybcio @ 2020-12-26 14:09 UTC (permalink / raw)
To: phone-devel
Cc: ~postmarketos/upstreaming, Konrad Dybcio, Andy Gross,
Bjorn Andersson, Michael Turquette, Stephen Boyd, Mike Turquette,
linux-arm-msm, linux-clk, linux-kernel
On boards without cont_splash the clock wouldn't get enabled.
Reparent it and strongly depend on the parent to make sure
it's accessible. Access to MMSS depends on mmss_s0_axi being
up and alive.
Fixes: d8b212014e69 ("clk: qcom: Add support for MSM8974's multimedia clock controller (MMCC)")
Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
drivers/clk/qcom/mmcc-msm8974.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c
index 015426262d08..6220b62ece1e 100644
--- a/drivers/clk/qcom/mmcc-msm8974.c
+++ b/drivers/clk/qcom/mmcc-msm8974.c
@@ -2101,11 +2101,11 @@ static struct clk_branch mmss_s0_axi_clk = {
.hw.init = &(struct clk_init_data){
.name = "mmss_s0_axi_clk",
.parent_names = (const char *[]){
- "mmss_axi_clk_src",
+ "mmss_mmssnoc_axi_clk",
},
.num_parents = 1,
.ops = &clk_branch2_ops,
- .flags = CLK_IGNORE_UNUSED,
+ .flags = CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE,
},
},
};
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: qcom: mmcc-msm8974: Fix mmss_s0_axi clock
2020-12-26 14:09 [PATCH] clk: qcom: mmcc-msm8974: Fix mmss_s0_axi clock Konrad Dybcio
@ 2021-01-12 19:57 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2021-01-12 19:57 UTC (permalink / raw)
To: Konrad Dybcio, phone-devel
Cc: ~postmarketos/upstreaming, Konrad Dybcio, Andy Gross,
Bjorn Andersson, Michael Turquette, Mike Turquette,
linux-arm-msm, linux-clk, linux-kernel
Quoting Konrad Dybcio (2020-12-26 06:09:34)
> On boards without cont_splash the clock wouldn't get enabled.
> Reparent it and strongly depend on the parent to make sure
> it's accessible. Access to MMSS depends on mmss_s0_axi being
It's not a dependency. The parent is supposed to be the actual parent
clk that is directly upstream of the clk. I understand that some
dependency isn't enabled but maybe that just means we need to write some
enable bit when this driver probes instead?
> up and alive.
>
> Fixes: d8b212014e69 ("clk: qcom: Add support for MSM8974's multimedia clock controller (MMCC)")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> drivers/clk/qcom/mmcc-msm8974.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c
> index 015426262d08..6220b62ece1e 100644
> --- a/drivers/clk/qcom/mmcc-msm8974.c
> +++ b/drivers/clk/qcom/mmcc-msm8974.c
> @@ -2101,11 +2101,11 @@ static struct clk_branch mmss_s0_axi_clk = {
> .hw.init = &(struct clk_init_data){
> .name = "mmss_s0_axi_clk",
> .parent_names = (const char *[]){
> - "mmss_axi_clk_src",
> + "mmss_mmssnoc_axi_clk",
> },
> .num_parents = 1,
> .ops = &clk_branch2_ops,
> - .flags = CLK_IGNORE_UNUSED,
> + .flags = CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE,
> },
> },
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-12 21:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-26 14:09 [PATCH] clk: qcom: mmcc-msm8974: Fix mmss_s0_axi clock Konrad Dybcio
2021-01-12 19:57 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).