From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, corbet@lwn.net, mturquette@baylibre.com,
sboyd@kernel.org, linux@armlinux.org.uk,
andrew.smirnov@gmail.com, robh@kernel.org, sre@kernel.org,
linux@roeck-us.net, sjhuang@iluvatar.ai,
mazziesaccount@gmail.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
heikki.haikola@fi.rohmeurope.com,
mikko.mutanen@fi.rohmeurope.com
Subject: Re: [PATCH 2/2] clk: bd718x7: Initial support for ROHM bd71837/bd71847 PMIC clock
Date: Fri, 31 Aug 2018 13:21:23 +0300 [thread overview]
Message-ID: <20180831102123.GA2472@localhost.localdomain> (raw)
In-Reply-To: <201808310820.GfPfChXp%fengguang.wu@intel.com>
Hello All,
Just wanted to point out for the reviewers that this patch depends on
not yet accepted MFD/regulator patch. (struct/defines in
include/linux/mfd/rohm-bd718x7.h were changed)
https://lore.kernel.org/lkml/cover.1535545377.git.matti.vaittinen@fi.rohmeurope.com/
On Fri, Aug 31, 2018 at 09:18:19AM +0800, kbuild test robot wrote:
> Hi Matti,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on clk/clk-next]
> [also build test ERROR on v4.19-rc1 next-20180830]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
Thus this error was expected. What is the generally best way to work
when there is changes to more than one subsystem? With this approach
the patch set here won't compile until MFD part gets applied. But if
I use old definitions/structs here, then clk tree gets broken when
MFD/regulator part changes defines. I see only bad and worse options =)
Anyways, I guess sending this patch with new defines (and applying it
only after MFD) is still better than applying this with old defines and
breaking it when MFD changes. (Assuming all of the patches get applied
at some point).
Br,
Matti Vaittinen
>
next prev parent reply other threads:[~2018-08-31 10:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 12:13 [PATCH 0/2] clk: Support ROHM BD71837 (BD71847) Matti Vaittinen
2018-08-30 12:14 ` [PATCH 1/2] clk: clkdev/of_clk - add managed lookup and provider registrations Matti Vaittinen
2018-08-30 12:15 ` [PATCH 2/2] clk: bd718x7: Initial support for ROHM bd71837/bd71847 PMIC clock Matti Vaittinen
2018-08-31 1:18 ` kbuild test robot
2018-08-31 10:21 ` Matti Vaittinen [this message]
2018-09-01 19:13 ` Stephen Boyd
2018-09-03 6:38 ` Matti Vaittinen
2018-11-12 7:45 ` Matti Vaittinen
2018-11-13 5:58 ` Stephen Boyd
2018-09-01 3:57 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831102123.GA2472@localhost.localdomain \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=andrew.smirnov@gmail.com \
--cc=corbet@lwn.net \
--cc=heikki.haikola@fi.rohmeurope.com \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=mazziesaccount@gmail.com \
--cc=mikko.mutanen@fi.rohmeurope.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sjhuang@iluvatar.ai \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).