linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [clk:clk-parent-rewrite 7/9] drivers//clk/clk.c:358:8: error: implicit declaration of function 'of_parse_clkspec'; did you mean 'of_parse_phandle'?
@ 2018-12-20  2:34 kbuild test robot
  0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2018-12-20  2:34 UTC (permalink / raw)
  To: Stephen Boyd; +Cc: kbuild-all, linux-clk, linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 3611 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-parent-rewrite
head:   f9fb356ae65be83af23b464809c70df15e8bd583
commit: f027c270b83d212dce1a1001ea9b9669902db5a5 [7/9] Start of clk local patches
config: i386-randconfig-x004-201850 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        git checkout f027c270b83d212dce1a1001ea9b9669902db5a5
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: the clk/clk-parent-rewrite HEAD f9fb356ae65be83af23b464809c70df15e8bd583 builds fine.
      It only hurts bisectibility.

All error/warnings (new ones prefixed by >>):

   drivers//clk/clk.c: In function 'clk_core_get':
>> drivers//clk/clk.c:358:8: error: implicit declaration of function 'of_parse_clkspec'; did you mean 'of_parse_phandle'? [-Werror=implicit-function-declaration]
     ret = of_parse_clkspec(dev->of_node, -1, name, &clkspec);
           ^~~~~~~~~~~~~~~~
           of_parse_phandle
>> drivers//clk/clk.c:362:7: error: implicit declaration of function 'of_clk_get_hw_from_clkspec'; did you mean 'of_clk_get_from_provider'? [-Werror=implicit-function-declaration]
     hw = of_clk_get_hw_from_clkspec(&clkspec);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~
          of_clk_get_from_provider
>> drivers//clk/clk.c:362:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     hw = of_clk_get_hw_from_clkspec(&clkspec);
        ^
   cc1: some warnings being treated as errors

vim +358 drivers//clk/clk.c

   321	
   322	/**
   323	 * clk_core_get - Find the parent of a clk using a clock specifier in DT
   324	 * @np: device node of device providing clk
   325	 * @name: name to search for in 'clock-names' of device providing clk
   326	 *
   327	 * This is the preferred method for clk providers to find the parent of a
   328	 * clk when the clk is registered with the CLK_PARENTS_LOCAL flag set and a
   329	 * struct device is passed to clk*_register(). The parent_names array is
   330	 * indexed and treated as a local name matching a string in the device node's
   331	 * 'clock-names' property. This allows clk providers to use their own namespace
   332	 * instead of looking for a globally unique parent string.
   333	 *
   334	 * For example the following DT snippet would allow a clock registered by the
   335	 * clock-controller@c001 that has CLK_PARENTS_LOCAL and a parent_names array
   336	 * with 'xtal' to find the clock provided by the clock-controller@f00abcd
   337	 * without needing to get the globally unique name of the xtal clk.
   338	 *
   339	 * 	parent: clock-controller@f00abcd {
   340	 * 		reg = <0xf00abcd 0xabcd>;
   341	 * 		#clock-cells = <0>;
   342	 * 	};
   343	 *
   344	 * 	clock-controller@c001 {
   345	 * 		reg = <0xc001 0xf00d>;
   346	 * 		clocks = <&parent>;
   347	 * 		clock-names = "xtal";
   348	 * 		#clock-cells = <1>;
   349	 * 	};
   350	 */
   351	static struct clk_core *clk_core_get(struct device *dev, const char *name)
   352	{
   353		struct clk_hw *hw;
   354		struct of_phandle_args clkspec;
   355		int ret;
   356	
   357		/* TODO: Support clkdev clk_lookups */
 > 358		ret = of_parse_clkspec(dev->of_node, -1, name, &clkspec);
   359		if (ret)
   360			return NULL;
   361	
 > 362		hw = of_clk_get_hw_from_clkspec(&clkspec);
   363		of_node_put(clkspec.np);
   364		if (IS_ERR_OR_NULL(hw))
   365			return NULL;
   366	
   367		return hw->core;
   368	}
   369	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30695 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-12-20  2:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-20  2:34 [clk:clk-parent-rewrite 7/9] drivers//clk/clk.c:358:8: error: implicit declaration of function 'of_parse_clkspec'; did you mean 'of_parse_phandle'? kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).