* [PATCH] clk: qoriq: fix refcount leak in clockgen_init()
@ 2018-12-26 13:14 Yangtao Li
2018-12-28 19:22 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2018-12-26 13:14 UTC (permalink / raw)
To: mturquette, sboyd; +Cc: linux-clk, linux-kernel, Yangtao Li
The of_find_compatible_node() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/clk/clk-qoriq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
index 4c30b6e799ed..97a0029a1cca 100644
--- a/drivers/clk/clk-qoriq.c
+++ b/drivers/clk/clk-qoriq.c
@@ -1389,6 +1389,7 @@ static void __init clockgen_init(struct device_node *np)
pr_err("%s: Couldn't map %pOF regs\n", __func__,
guts);
}
+ of_node_put(guts);
}
}
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: qoriq: fix refcount leak in clockgen_init()
2018-12-26 13:14 [PATCH] clk: qoriq: fix refcount leak in clockgen_init() Yangtao Li
@ 2018-12-28 19:22 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2018-12-28 19:22 UTC (permalink / raw)
To: Yangtao Li, mturquette; +Cc: linux-clk, linux-kernel, Yangtao Li
Quoting Yangtao Li (2018-12-26 05:14:42)
> The of_find_compatible_node() returns a node pointer with refcount
> incremented, but there is the lack of use of the of_node_put() when
> done. Add the missing of_node_put() to release the refcount.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-28 19:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-26 13:14 [PATCH] clk: qoriq: fix refcount leak in clockgen_init() Yangtao Li
2018-12-28 19:22 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).