From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: ulf.hansson@linaro.org, robh+dt@kernel.org, sboyd@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
thomas.liau@actions-semi.com, linux-actions@lists.infradead.org,
linus.walleij@linaro.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 4/7] arm64: dts: actions: Add uSD and eMMC support for Bubblegum96
Date: Mon, 10 Jun 2019 21:41:28 +0530 [thread overview]
Message-ID: <20190610161128.GC31461@mani> (raw)
In-Reply-To: <1381305a-8585-9dcf-6b43-34e852e785ab@suse.de>
Hi Andreas,
On Mon, Jun 10, 2019 at 04:08:26PM +0200, Andreas Färber wrote:
> Hi Mani,
>
> Am 08.06.19 um 21:53 schrieb Manivannan Sadhasivam:
> > Add uSD and eMMC support for Bubblegum96 board based on Actions Semi
> > Owl SoC.
>
> What information does "based on Actions Semi Owl SoC" give us? :)
> The board name should be unique enough - Owl is a family of SoCs,
> "actions:" is in the subject and "s900-" is in the filename.
>
Makes sense!
> > SD0 is connected to uSD slot and SD2 is connected to eMMC.
>
> Suggest to add that as comments above the two nodes instead.
>
Okay.
> > Since there is no PMIC support added yet, fixed regulator has been
> > used as a regulator node.
>
> Fine with me - maybe add a comment and make sure it's aligned with the
> schematics naming wrt PMIC.
>
Okay.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > .../boot/dts/actions/s900-bubblegum-96.dts | 50 +++++++++++++++++++
> > 1 file changed, 50 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/actions/s900-bubblegum-96.dts b/arch/arm64/boot/dts/actions/s900-bubblegum-96.dts
> > index 732daaa6e9d3..3b596d72de25 100644
> > --- a/arch/arm64/boot/dts/actions/s900-bubblegum-96.dts
> > +++ b/arch/arm64/boot/dts/actions/s900-bubblegum-96.dts
> > @@ -13,6 +13,9 @@
> >
> > aliases {
> > serial5 = &uart5;
> > + mmc0 = &mmc0;
> > + mmc1 = &mmc1;
> > + mmc2 = &mmc2;
>
> Sort them alphabetically?
>
Ack.
> > };
> >
> > chosen {
> > @@ -23,6 +26,14 @@
> > device_type = "memory";
> > reg = <0x0 0x0 0x0 0x80000000>;
> > };
> > +
> > + reg_3p1v: regulator-3p1v {
> > + compatible = "regulator-fixed";
> > + regulator-name = "fixed-3.1V";
> > + regulator-min-microvolt = <3100000>;
> > + regulator-max-microvolt = <3100000>;
> > + regulator-always-on;
> > + };
> > };
> >
> > &i2c0 {
> > @@ -241,6 +252,45 @@
> > bias-pull-up;
> > };
> > };
> > +
> > + mmc0_default: mmc0_default {
> > + pinmux {
> > + groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp",
> > + "sd0_cmd_mfp", "sd0_clk_mfp";
> > + function = "sd0";
> > + };
> > + };
> > +
> > + mmc2_default: mmc2_default {
> > + pinmux {
> > + groups = "nand0_d0_ceb3_mfp";
> > + function = "sd2";
> > + };
> > + };
>
> Wouldn't it make more sense to move these and the below pinctrl-* to
> s900.dtsi for sharing with other theoretical boards? I really dislike
> the imx model where pin muxing is duplicated into each individual board.
>
Matter of taste. IMO pinctrl config belongs to the board design and I don't
wanna dump all combinations in the soc dtsi.
Thanks,
Mani
> Regards,
> Andreas
>
> > +};
> > +
> > +&mmc0 {
> > + status = "okay";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&mmc0_default>;
> > + no-sdio;
> > + no-mmc;
> > + no-1-8-v;
> > + cd-gpios = <&pinctrl 120 GPIO_ACTIVE_LOW>;
> > + bus-width = <4>;
> > + vmmc-supply = <®_3p1v>;
> > + vqmmc-supply = <®_3p1v>;
> > +};
> > +
> > +&mmc2 {
> > + status = "okay";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&mmc2_default>;
> > + no-sdio;
> > + no-sd;
> > + non-removable;
> > + bus-width = <8>;
> > + vmmc-supply = <®_3p1v>;
> > };
> >
> > &timer {
>
> --
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
> HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2019-06-10 16:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 19:53 [PATCH 0/7] Add SD/MMC driver for Actions Semi S900 SoC Manivannan Sadhasivam
2019-06-08 19:53 ` [PATCH 1/7] clk: actions: Fix factor clk struct member access Manivannan Sadhasivam
2019-06-10 13:36 ` Andreas Färber
2019-06-10 16:05 ` Manivannan Sadhasivam
2019-06-10 15:01 ` Stephen Boyd
2019-06-08 19:53 ` [PATCH 2/7] dt-bindings: mmc: Add Actions Semi SD/MMC/SDIO controller binding Manivannan Sadhasivam
2019-06-10 13:45 ` Andreas Färber
2019-06-10 16:04 ` Manivannan Sadhasivam
2019-07-09 2:16 ` Rob Herring
2019-06-08 19:53 ` [PATCH 3/7] arm64: dts: actions: Add MMC controller support for S900 Manivannan Sadhasivam
2019-06-08 19:53 ` [PATCH 4/7] arm64: dts: actions: Add uSD and eMMC support for Bubblegum96 Manivannan Sadhasivam
2019-06-10 14:08 ` Andreas Färber
2019-06-10 16:11 ` Manivannan Sadhasivam [this message]
2019-06-08 19:53 ` [PATCH 5/7] mmc: Add Actions Semi Owl SoCs SD/MMC driver Manivannan Sadhasivam
2019-07-22 13:41 ` Ulf Hansson
2019-08-21 2:26 ` Manivannan Sadhasivam
2019-06-08 19:53 ` [PATCH 6/7] MAINTAINERS: Add entry for Actions Semi SD/MMC driver and binding Manivannan Sadhasivam
2019-06-08 19:53 ` [PATCH 7/7] arm64: configs: Enable Actions Semi platform in defconfig Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610161128.GC31461@mani \
--to=manivannan.sadhasivam@linaro.org \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thomas.liau@actions-semi.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).