* [PATCH] clk: spear: Make structure i2s_sclk_masks constant
@ 2019-08-13 8:57 Nishka Dasgupta
2019-08-19 2:20 ` Viresh Kumar
2019-09-06 17:27 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Nishka Dasgupta @ 2019-08-13 8:57 UTC (permalink / raw)
To: vireshk, mturquette, sboyd, linux-arm-kernel, linux-clk; +Cc: Nishka Dasgupta
Static structure i2s_sclk_masks, having type aux_clk_masks, is only used
when it is passed as the sixth argument to function clk_register_aux().
However, clk_register_aux() is defined with its sixth argument as const.
Hence i2s_sclk_masks is not modified by clk_register_aux, which is also
the only usage of the former. Therefore make i2s_sclk_masks constant as
it is never modified.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
drivers/clk/spear/spear1340_clock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/spear/spear1340_clock.c b/drivers/clk/spear/spear1340_clock.c
index e5bc8c828cf0..9163bbb46411 100644
--- a/drivers/clk/spear/spear1340_clock.c
+++ b/drivers/clk/spear/spear1340_clock.c
@@ -335,7 +335,7 @@ static const struct aux_clk_masks i2s_prs1_masks = {
};
/* i2s sclk (bit clock) syynthesizers masks */
-static struct aux_clk_masks i2s_sclk_masks = {
+static const struct aux_clk_masks i2s_sclk_masks = {
.eq_sel_mask = AUX_EQ_SEL_MASK,
.eq_sel_shift = SPEAR1340_I2S_SCLK_EQ_SEL_SHIFT,
.eq1_mask = AUX_EQ1_SEL,
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: spear: Make structure i2s_sclk_masks constant
2019-08-13 8:57 [PATCH] clk: spear: Make structure i2s_sclk_masks constant Nishka Dasgupta
@ 2019-08-19 2:20 ` Viresh Kumar
2019-09-06 17:27 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2019-08-19 2:20 UTC (permalink / raw)
To: Nishka Dasgupta; +Cc: vireshk, mturquette, sboyd, linux-arm-kernel, linux-clk
On 13-08-19, 14:27, Nishka Dasgupta wrote:
> Static structure i2s_sclk_masks, having type aux_clk_masks, is only used
> when it is passed as the sixth argument to function clk_register_aux().
> However, clk_register_aux() is defined with its sixth argument as const.
> Hence i2s_sclk_masks is not modified by clk_register_aux, which is also
> the only usage of the former. Therefore make i2s_sclk_masks constant as
> it is never modified.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
> drivers/clk/spear/spear1340_clock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/spear/spear1340_clock.c b/drivers/clk/spear/spear1340_clock.c
> index e5bc8c828cf0..9163bbb46411 100644
> --- a/drivers/clk/spear/spear1340_clock.c
> +++ b/drivers/clk/spear/spear1340_clock.c
> @@ -335,7 +335,7 @@ static const struct aux_clk_masks i2s_prs1_masks = {
> };
>
> /* i2s sclk (bit clock) syynthesizers masks */
> -static struct aux_clk_masks i2s_sclk_masks = {
> +static const struct aux_clk_masks i2s_sclk_masks = {
> .eq_sel_mask = AUX_EQ_SEL_MASK,
> .eq_sel_shift = SPEAR1340_I2S_SCLK_EQ_SEL_SHIFT,
> .eq1_mask = AUX_EQ1_SEL,
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: spear: Make structure i2s_sclk_masks constant
2019-08-13 8:57 [PATCH] clk: spear: Make structure i2s_sclk_masks constant Nishka Dasgupta
2019-08-19 2:20 ` Viresh Kumar
@ 2019-09-06 17:27 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2019-09-06 17:27 UTC (permalink / raw)
To: Nishka Dasgupta, linux-arm-kernel, linux-clk, mturquette, vireshk
Cc: Nishka Dasgupta
Quoting Nishka Dasgupta (2019-08-13 01:57:14)
> Static structure i2s_sclk_masks, having type aux_clk_masks, is only used
> when it is passed as the sixth argument to function clk_register_aux().
> However, clk_register_aux() is defined with its sixth argument as const.
> Hence i2s_sclk_masks is not modified by clk_register_aux, which is also
> the only usage of the former. Therefore make i2s_sclk_masks constant as
> it is never modified.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-06 17:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 8:57 [PATCH] clk: spear: Make structure i2s_sclk_masks constant Nishka Dasgupta
2019-08-19 2:20 ` Viresh Kumar
2019-09-06 17:27 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).