From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: kholk11@gmail.com
Cc: linux-arm-msm@vger.kernel.org, marijns95@gmail.com,
agross@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linus.walleij@linaro.org, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/5] pinctrl: qcom: Add a pinctrl driver for MSM8976 and 8956
Date: Fri, 4 Oct 2019 20:59:31 -0700 [thread overview]
Message-ID: <20191005035931.GC2999@tuxbook-pro> (raw)
In-Reply-To: <20190921101207.65042-2-kholk11@gmail.com>
On Sat 21 Sep 03:12 PDT 2019, kholk11@gmail.com wrote:
> From: "Angelo G. Del Regno" <kholk11@gmail.com>
>
> Add the pinctrl driver to support pin configuration with the
> pinctrl framework on MSM8976, MSM8956, APQ8056, APQ8076.
>
> Signed-off-by: Angelo G. Del Regno <kholk11@gmail.com>
> ---
> .../bindings/pinctrl/qcom,msm8976-pinctrl.txt | 183 +++
> drivers/pinctrl/qcom/Kconfig | 10 +
> drivers/pinctrl/qcom/Makefile | 1 +
> drivers/pinctrl/qcom/pinctrl-msm8976.c | 1128 +++++++++++++++++
> 4 files changed, 1322 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,msm8976-pinctrl.txt
> create mode 100644 drivers/pinctrl/qcom/pinctrl-msm8976.c
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8976-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8976-pinctrl.txt
> new file mode 100644
> index 000000000000..4e944f84b7d7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8976-pinctrl.txt
> @@ -0,0 +1,183 @@
> +Qualcomm MSM8976 TLMM block
As Linus indicated, please send your the DT bindings in separate
patches.
> +
[..]
> +Example:
> +
> + tlmm: pinctrl@1000000 {
> + compatible = "qcom,msm8976-pinctrl";
> + reg = <0x1000000 0x300000>;
> + interrupts = <0 208 0>;
<GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&tlmm 0 0 145>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +
> + blsp1_uart2_active: blsp1_uart2_active {
> + mux {
> + pins = "gpio4", "gpio5", "gpio6", "gpio7";
> + function = "blsp_uart2";
> + };
> +
> + config {
> + pins = "gpio4", "gpio5", "gpio6", "gpio7";
> + drive-strength = <2>;
> + bias-disable;
> + };
> + };
> + };
> diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
[..]
> +static struct platform_driver msm8976_pinctrl_driver = {
> + .driver = {
> + .name = "msm8976-pinctrl",
> + .owner = THIS_MODULE,
No need to specify .onwer on platform_drivers anymore.
Apart from that, I think this patch looks good.
Regards,
Bjorn
next prev parent reply other threads:[~2019-10-05 3:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 10:12 [PATCH 0/5] Add core MSM8956/76 SoC support drivers kholk11
2019-09-21 10:12 ` [PATCH 1/5] pinctrl: qcom: Add a pinctrl driver for MSM8976 and 8956 kholk11
2019-10-04 21:16 ` Linus Walleij
2019-10-05 3:59 ` Bjorn Andersson [this message]
2019-10-05 9:19 ` AngeloGioacchino Del Regno
2019-09-21 10:12 ` [PATCH 3/5] soc: qcom: smd-rpm: Add MSM8976 compatible kholk11
2019-10-05 4:23 ` Bjorn Andersson
2019-09-21 10:12 ` [PATCH 4/5] dt-bindings: power: Add missing rpmpd smd performance level kholk11
2019-10-05 4:27 ` Bjorn Andersson
2019-09-21 10:12 ` [PATCH 5/5] soc: qcom: rpmpd: Add rpm power domains for msm8956 kholk11
2019-10-05 4:25 ` Bjorn Andersson
2019-10-05 9:23 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005035931.GC2999@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=kholk11@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=marijns95@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).