* [PATCH -next] clk: tegra: Fix build error without CONFIG_PM_SLEEP
@ 2019-10-30 12:56 YueHaibing
2019-11-01 9:50 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-10-30 12:56 UTC (permalink / raw)
To: pdeschrijver, pgaikwad, mturquette, sboyd, treding, jonathanh,
skomatineni, digetx
Cc: linux-clk, linux-tegra, linux-kernel, YueHaibing
If CONFIG_PM_SLEEP is n, build fails:
drivers/clk/tegra/clk-tegra210.c:3426:13: error:
tegra210_clk_suspend undeclared here (not in a function); did you mean tegra_clk_ndspeed?
.suspend = tegra210_clk_suspend,
^~~~~~~~~~~~~~~~~~~~
tegra_clk_ndspeed
drivers/clk/tegra/clk-tegra210.c:3427:12: error:
tegra210_clk_resume undeclared here (not in a function); did you mean tegra210_clk_suspend?
.resume = tegra210_clk_resume,
Use ifdef to guard this.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 27d10d548c04 ("clk: tegra: Add suspend and resume support on Tegra210")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/clk/tegra/clk-tegra210.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c
index d038fed..762cd18 100644
--- a/drivers/clk/tegra/clk-tegra210.c
+++ b/drivers/clk/tegra/clk-tegra210.c
@@ -3423,8 +3423,10 @@ static void tegra210_cpu_clock_resume(void)
#endif
static struct syscore_ops tegra_clk_syscore_ops = {
+#ifdef CONFIG_PM_SLEEP
.suspend = tegra210_clk_suspend,
.resume = tegra210_clk_resume,
+#endif
};
static struct tegra_cpu_car_ops tegra210_cpu_car_ops = {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] clk: tegra: Fix build error without CONFIG_PM_SLEEP
2019-10-30 12:56 [PATCH -next] clk: tegra: Fix build error without CONFIG_PM_SLEEP YueHaibing
@ 2019-11-01 9:50 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2019-11-01 9:50 UTC (permalink / raw)
To: YueHaibing
Cc: pdeschrijver, pgaikwad, mturquette, sboyd, treding, jonathanh,
skomatineni, digetx, linux-clk, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 896 bytes --]
On Wed, Oct 30, 2019 at 08:56:50PM +0800, YueHaibing wrote:
> If CONFIG_PM_SLEEP is n, build fails:
>
> drivers/clk/tegra/clk-tegra210.c:3426:13: error:
> tegra210_clk_suspend undeclared here (not in a function); did you mean tegra_clk_ndspeed?
> .suspend = tegra210_clk_suspend,
> ^~~~~~~~~~~~~~~~~~~~
> tegra_clk_ndspeed
> drivers/clk/tegra/clk-tegra210.c:3427:12: error:
> tegra210_clk_resume undeclared here (not in a function); did you mean tegra210_clk_suspend?
> .resume = tegra210_clk_resume,
>
> Use ifdef to guard this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 27d10d548c04 ("clk: tegra: Add suspend and resume support on Tegra210")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/clk/tegra/clk-tegra210.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied to for-5.5/clk, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-01 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30 12:56 [PATCH -next] clk: tegra: Fix build error without CONFIG_PM_SLEEP YueHaibing
2019-11-01 9:50 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).