From: Stephen Boyd <sboyd@kernel.org>
To: Leo Li <leoyang.li@nxp.com>, Mark Rutland <mark.rutland@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>, Wen He <wen.he_1@nxp.com>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-devel@linux.nxdi.nxp.com, linux-kernel@vger.kernel.org
Subject: RE: [v6 2/2] clk: ls1028a: Add clock driver for Display output interface
Date: Thu, 07 Nov 2019 14:57:44 -0800 [thread overview]
Message-ID: <20191107225745.1A01C2178F@mail.kernel.org> (raw)
In-Reply-To: <DB7PR04MB51956205E7FE92C9EB00A882E2780@DB7PR04MB5195.eurprd04.prod.outlook.com>
Quoting Wen He (2019-11-06 19:13:48)
>
> > > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index
> > > 0138fb14e6f8..d23b7464aba8 100644
> > > --- a/drivers/clk/Makefile
> > > +++ b/drivers/clk/Makefile
> > > @@ -45,6 +45,7 @@ obj-$(CONFIG_COMMON_CLK_OXNAS) +=
> > > clk-oxnas.o
> > > obj-$(CONFIG_COMMON_CLK_PALMAS) += clk-palmas.o
> > > obj-$(CONFIG_COMMON_CLK_PWM) += clk-pwm.o
> > > obj-$(CONFIG_CLK_QORIQ) += clk-qoriq.o
> > > +obj-$(CONFIG_CLK_LS1028A_PLLDIG) += clk-plldig.o
> >
> > Wrong ordering. This section of Makefile requires ordering by driver file
> > name:
> >
> > # hardware specific clock types
> > # please keep this section sorted lexicographically by file path name
> >
>
> Hi Leo,
>
> Stephen once suggest the Kconfig variable name should be given a more
> specific name like CLK_LS1028A_PLLDIG, so I have to changed it.
>
> Hi Stephen,
>
> How do you think?
>
Config name looks fine to me, but you haven't sorted this based on the
file name, i.e. clk-plldig.o, so please insert this in the right place
in this file.
next prev parent reply other threads:[~2019-11-07 22:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 9:02 [v6 1/2] dt/bindings: clk: Add YAML schemas for LS1028A Display Clock bindings Wen He
2019-11-05 9:02 ` [v6 2/2] clk: ls1028a: Add clock driver for Display output interface Wen He
2019-11-05 21:10 ` Leo Li
2019-11-07 3:13 ` Wen He
2019-11-07 22:57 ` Stephen Boyd [this message]
2019-11-08 2:19 ` [EXT] " Wen He
2019-11-08 20:20 ` Li Yang
2019-11-11 2:02 ` Wen He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107225745.1A01C2178F@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-devel@linux.nxdi.nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=wen.he_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).