Potential uninitialized variable "reg" in clk: axi-clkgen

Potential uninitialized variable "reg" in clk: axi-clkgen

[Yizhuo Zhai]

Hi All:
drivers/clk/clk-axi-clkgen.c:

Inside function axi_clkgen_recalc_rate(), variable "reg" could be
uninitialized if axi_clkgen_mmcm_read() fails. However, "reg" is used
to decide the control flow later in the if statement, which is
potentially unsafe.

The patch for this case is not easy since the error return is not an
acceptable return value for axi_clkgen_recalc_rate().

-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside

Re: Potential uninitialized variable "reg" in clk: axi-clkgen

[Stephen Boyd]

Quoting Yizhuo Zhai (2019-10-09 17:55:06)
> Hi All:
> drivers/clk/clk-axi-clkgen.c:
> 
> Inside function axi_clkgen_recalc_rate(), variable "reg" could be
> uninitialized if axi_clkgen_mmcm_read() fails. However, "reg" is used
> to decide the control flow later in the if statement, which is
> potentially unsafe.
> 
> The patch for this case is not easy since the error return is not an
> acceptable return value for axi_clkgen_recalc_rate().
> 

I think we will do nothing unless you send some sort of patch. Sorry.